ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.C5W3KQhQJn and /tmp/tmp.ZR37nutCtw
Tree base:
cf0d9080c6f7 ("Merge branch 'net-hsr-subsystem-cleanups-and-modernization'")
Now at:
bc9890b9f2d2 ("selftests: netfilter: conntrack_sctp_collision.sh: Introduce SCTP INIT collision test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/conntrack_sctp_collision.sh - fa30c5843b9afe2bfd2fc2064d6b85796f74de9166222e6ce19c04ae5033d3e2


In conntrack_sctp_collision.sh line 29:
	ip -n "$SERVER_NS" link add link0 type veth peer name link1 netns "$ROUTER_NS"
               ^--------^ SC2153 (info): Possible misspelling: SERVER_NS may not be assigned. Did you mean SERVER_GW?


In conntrack_sctp_collision.sh line 30:
	ip -n "$CLIENT_NS" link add link3 type veth peer name link2 netns "$ROUTER_NS"
               ^--------^ SC2153 (info): Possible misspelling: CLIENT_NS may not be assigned. Did you mean CLIENT_GW?


In conntrack_sctp_collision.sh line 66:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling: CLIENT_NS m...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/conntrack_sctp_collision.sh - fa30c5843b9afe2bfd2fc2064d6b85796f74de9166222e6ce19c04ae5033d3e2


In conntrack_sctp_collision.sh line 30:
		echo "FAIL: ${@}"
                            ^--^ SC2145 (error): Argument mixes string and array. Use * or separate argument.


In conntrack_sctp_collision.sh line 33:
		echo "PASS: ${@}"
                            ^--^ SC2145 (error): Argument mixes string and array. Use * or separate argument.


In conntrack_sctp_collision.sh line 40:
	ip -n "$SERVER_NS" link add link0 type veth peer name link1 netns "$ROUTER_NS"
               ^--------^ SC2153 (info): Possible misspelling: SERVER_NS may not be assigned. Did you mean SERVER_GW?


In conntrack_sctp_collision.sh line 41:
	ip -n "$CLIENT_NS" link add link3 type veth peer name link2 netns "$ROUTER_NS"
               ^--------^ SC2153 (info): Possible misspelling: CLIENT_NS may not be assigned. Did you mean CLIENT_GW?

For more information:
  https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
  https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling: CLIENT_NS m...