ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.GTqWHszbOX and /tmp/tmp.GDmhGqL32F Tree base: d1e59a469737 ("tcp: add cwnd_event_tx_start to tcp_congestion_ops") Now at: f98998fbdff5 ("selftests: net: broadcast_pmtu: Fix false failure from incorrect ping exit code logic") ====== Checking before the patch ====== Checking tools/testing/selftests/net/broadcast_pmtu.sh - ee13ba3074be1a2f68a6ad919aa809a34457d90ff2058debb285d01de53a2b82 In broadcast_pmtu.sh line 34: cleanup() { ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). For more information: https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/broadcast_pmtu.sh - ee13ba3074be1a2f68a6ad919aa809a34457d90ff2058debb285d01de53a2b82 In broadcast_pmtu.sh line 34: cleanup() { ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In broadcast_pmtu.sh line 52: exit ${exit_code} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "${exit_code}" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...