====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/veth_bql_test.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.E9ybktT51b 2026-03-24 14:39:41.288354654 -0400 +++ /tmp/tmp.VmDseJgl3K 2026-03-24 14:39:41.929350952 -0400 @@ -0,0 +1,115 @@ + +In veth_bql_test.sh line 99: +cleanup() { +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In veth_bql_test.sh line 100: + [ -n "$BPFTRACE_PID" ] && kill_process $BPFTRACE_PID + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$BPFTRACE_PID" ] && kill_process "$BPFTRACE_PID" + + +In veth_bql_test.sh line 101: + [ -n "$FLOOD_PID" ] && kill_process $FLOOD_PID + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$FLOOD_PID" ] && kill_process "$FLOOD_PID" + + +In veth_bql_test.sh line 102: + [ -n "$SINK_PID" ] && kill_process $SINK_PID + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$SINK_PID" ] && kill_process "$SINK_PID" + + +In veth_bql_test.sh line 103: + [ -n "$PING_PID" ] && kill_process $PING_PID + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$PING_PID" ] && kill_process "$PING_PID" + + +In veth_bql_test.sh line 427: + tc qdisc replace dev "$VETH_A" root $qdisc $opts + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tc qdisc replace dev "$VETH_A" root "$qdisc" "$opts" + + +In veth_bql_test.sh line 428: + ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root $qdisc $opts + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root "$qdisc" "$opts" + + +In veth_bql_test.sh line 442: + ip netns exec "$NS" bash -c ' + ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that. + + +In veth_bql_test.sh line 487: + local bt_script="$(dirname -- "$0")/napi_poll_hist.bt" + ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In veth_bql_test.sh line 575: + set -- $line + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + set -- "$line" + + +In veth_bql_test.sh line 578: + read prev_p prev_sq < "$TMPDIR/softnet_cpu${cpu}" + ^--^ SC2162 (info): read without -r will mangle backslashes. + + +In veth_bql_test.sh line 587: + local n_active=$(echo $active_cpus | wc -w) + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local n_active=$(echo "$active_cpus" | wc -w) + + +In veth_bql_test.sh line 619: + set -- $line + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + set -- "$line" + + +In veth_bql_test.sh line 631: + exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "$EXIT_STATUS" + + +In veth_bql_test.sh line 693: + exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "$EXIT_STATUS" + +For more information: + https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... + https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...