ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.jaCu8fuAsC and /tmp/tmp.mPNcHhsXE5 Tree base: 2b05284dff94 ("seg6: add per-route tunnel source address") Now at: 856a3b015085 ("selftests: add check for seg6 tunsrc") ====== Checking before the patch ====== Checking tools/testing/selftests/net/srv6_hencap_red_l3vpn_test.sh - 27236f866c8cc6379746c47ffb7d17df227c837c6c9d6d5ef787820c50d56b7a In srv6_hencap_red_l3vpn_test.sh line 212: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hencap_red_l3vpn_test.sh line 303: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 306: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 338: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 369: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 435: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 482: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 483: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 617: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 640: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 652: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 778: for k in 0 1; do ^-^ SC2034 (warning): k appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2034 -- k appears unused. Verify use (or ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/srv6_hencap_red_l3vpn_test.sh - 27236f866c8cc6379746c47ffb7d17df227c837c6c9d6d5ef787820c50d56b7a In srv6_hencap_red_l3vpn_test.sh line 214: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In srv6_hencap_red_l3vpn_test.sh line 305: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 308: eval neigh_nsname=\${$(get_rtname "${neigh}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 340: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 382: eval nsname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 458: eval nsname=\${$(get_rtname "${dec_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 480: ip6tables -t raw -C ${drule} &>/dev/null; then ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip6tables -t raw -C "${drule}" &>/dev/null; then In srv6_hencap_red_l3vpn_test.sh line 481: ip netns exec "${nsname}" ip6tables -t raw -A ${drule} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "${nsname}" ip6tables -t raw -A "${drule}" In srv6_hencap_red_l3vpn_test.sh line 485: eval nsname=\${$(get_rtname "${encap_rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 497: encap seg6 mode "${mode}" ${tunsrc} segs "${policy}" \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: encap seg6 mode "${mode}" "${tunsrc}" segs "${policy}" \ In srv6_hencap_red_l3vpn_test.sh line 508: encap seg6 mode "${mode}" ${tunsrc} segs "${policy}" \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: encap seg6 mode "${mode}" "${tunsrc}" segs "${policy}" \ In srv6_hencap_red_l3vpn_test.sh line 532: eval hsname=\${$(get_hsname "${hs}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 533: eval rtname=\${$(get_rtname "${rt}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 667: eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 690: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 702: eval hssrc_nsname=\${$(get_hsname "${hssrc}")} ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it. ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it. In srv6_hencap_red_l3vpn_test.sh line 828: for k in 0 1; do ^-^ SC2034 (warning): k appears unused. Verify use (or export if used externally). In srv6_hencap_red_l3vpn_test.sh line 867: ip -netns "${tunsrc_ns}" link add veth0 type veth \ ^----------^ SC2154 (warning): tunsrc_ns is referenced but not assigned. For more information: https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi... https://www.shellcheck.net/wiki/SC2034 -- k appears unused. Verify use (or ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...