WARNING: line length of 92 exceeds 80 columns #107: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:281: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, WARNING: line length of 86 exceeds 80 columns #108: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:282: + "bpf_testmod:bpf_testmod_fentry_test*", NULL); CHECK: Alignment should match open parenthesis #108: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:282: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, + "bpf_testmod:bpf_testmod_fentry_test*", NULL); WARNING: line length of 89 exceeds 80 columns #109: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:283: + if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi")) WARNING: line length of 90 exceeds 80 columns #112: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:286: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, WARNING: line length of 86 exceeds 80 columns #113: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:287: + "bpf_testmod:bpf_testmod_fentry_test*", NULL); CHECK: Alignment should match open parenthesis #113: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:287: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, + "bpf_testmod:bpf_testmod_fentry_test*", NULL); WARNING: line length of 88 exceeds 80 columns #114: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:288: + if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi")) WARNING: Missing a blank line after declarations #128: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:302: + size_t cnt = ARRAY_SIZE(bpf_testmod_fentry_test); + LIBBPF_OPTS(bpf_tracing_multi_opts, opts); WARNING: line length of 92 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:319: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, CHECK: Alignment should match open parenthesis #146: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:320: + skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry, + NULL, &opts); WARNING: line length of 89 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:321: + if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi")) WARNING: line length of 90 exceeds 80 columns #150: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:324: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, CHECK: Alignment should match open parenthesis #151: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:325: + skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit, + NULL, &opts); WARNING: line length of 88 exceeds 80 columns #152: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:326: + if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi")) WARNING: line length of 93 exceeds 80 columns #191: FILE: tools/testing/selftests/bpf/progs/tracing_multi_attach_module.c:8: +__hidden extern void tracing_multi_arg_check(__u64 *ctx, __u64 *test_result, bool is_return); WARNING: externs should be avoided in .c files #217: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:21: +extern const void bpf_testmod_fentry_test1 __ksym; WARNING: externs should be avoided in .c files #218: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:22: +extern const void bpf_testmod_fentry_test2 __ksym; WARNING: externs should be avoided in .c files #219: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:23: +extern const void bpf_testmod_fentry_test3 __ksym; WARNING: externs should be avoided in .c files #220: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:24: +extern const void bpf_testmod_fentry_test7 __ksym; ERROR: "foo1 bar" should be "foo 1 bar" #221: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:25: +extern const void bpf_testmod_fentry_test11 __ksym; WARNING: externs should be avoided in .c files #221: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:25: +extern const void bpf_testmod_fentry_test11 __ksym; CHECK: No space is necessary after a cast #234: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:158: + a = (int) value; CHECK: No space is necessary after a cast #244: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:168: + a = (int) value; CHECK: No space is necessary after a cast #246: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:170: + b = (__u64) value; CHECK: No space is necessary after a cast #257: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:181: + a = (char) value; CHECK: No space is necessary after a cast #259: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:183: + b = (int) value; CHECK: No space is necessary after a cast #261: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:185: + c = (__u64) value; total: 1 errors, 17 warnings, 10 checks, 229 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit dd7edae784b0 ("selftests/bpf: Add tracing multi skel/pattern/ids module attach tests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.