CHECK: Please use a blank line after function/struct/union/enum declarations
#81: FILE: include/linux/bpf.h:1583:
 }
+static inline int bpf_trampoline_multi_attach(struct bpf_prog *prog, u32 *ids,

WARNING: line length of 82 exceeds 80 columns
#82: FILE: include/linux/bpf.h:1584:
+					      struct bpf_tracing_multi_link *link)

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#84: FILE: include/linux/bpf.h:1586:
+	return -ENOTSUPP;

CHECK: Please use a blank line after function/struct/union/enum declarations
#86: FILE: include/linux/bpf.h:1588:
+}
+static inline int bpf_trampoline_multi_detach(struct bpf_prog *prog,

WARNING: line length of 82 exceeds 80 columns
#87: FILE: include/linux/bpf.h:1589:
+					      struct bpf_tracing_multi_link *link)

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#89: FILE: include/linux/bpf.h:1591:
+	return -ENOTSUPP;

WARNING: please, no spaces at the start of a line
#144: FILE: kernel/bpf/trampoline.c:1443:
+    defined(CONFIG_HAVE_SINGLE_FTRACE_DIRECT_OPS) && \$

WARNING: please, no spaces at the start of a line
#145: FILE: kernel/bpf/trampoline.c:1444:
+    defined(CONFIG_BPF_SYSCALL)$

WARNING: line length of 86 exceeds 80 columns
#160: FILE: kernel/bpf/trampoline.c:1459:
+static int register_fentry_multi(struct bpf_trampoline *tr, void *new_addr, void *ptr)

CHECK: No space is necessary after a cast
#162: FILE: kernel/bpf/trampoline.c:1461:
+	unsigned long addr = (unsigned long) new_addr;

WARNING: line length of 93 exceeds 80 columns
#171: FILE: kernel/bpf/trampoline.c:1470:
+static int unregister_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, void *old_addr,

CHECK: No space is necessary after a cast
#174: FILE: kernel/bpf/trampoline.c:1473:
+	unsigned long addr = (unsigned long) old_addr;

WARNING: line length of 81 exceeds 80 columns
#180: FILE: kernel/bpf/trampoline.c:1479:
+	return add_ftrace_hash_entry_direct(data->unreg, ip, addr) ? 0 : -ENOMEM;

WARNING: line length of 89 exceeds 80 columns
#183: FILE: kernel/bpf/trampoline.c:1482:
+static int modify_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, void *old_addr,

WARNING: line length of 81 exceeds 80 columns
#184: FILE: kernel/bpf/trampoline.c:1483:
+			       void *new_addr, bool lock_direct_mutex, void *ptr)

CHECK: No space is necessary after a cast
#186: FILE: kernel/bpf/trampoline.c:1485:
+	unsigned long addr = (unsigned long) new_addr;

WARNING: line length of 82 exceeds 80 columns
#192: FILE: kernel/bpf/trampoline.c:1491:
+	return add_ftrace_hash_entry_direct(data->modify, ip, addr) ? 0 : -ENOMEM;

WARNING: line length of 84 exceeds 80 columns
#201: FILE: kernel/bpf/trampoline.c:1500:
+static int bpf_get_btf_id_target(struct btf *btf, struct bpf_prog *prog, u32 btf_id,

WARNING: line length of 91 exceeds 80 columns
#268: FILE: kernel/bpf/trampoline.c:1567:
+			err = btf_id_allow_sleepable(btf_id, tgt_info.tgt_addr, prog, btf);

WARNING: line length of 87 exceeds 80 columns
#290: FILE: kernel/bpf/trampoline.c:1589:
+		err = __bpf_trampoline_link_prog(&mnode->node, mnode->trampoline, NULL,

WARNING: line length of 81 exceeds 80 columns
#326: FILE: kernel/bpf/trampoline.c:1625:
+	 * and update modified (data.modify) sites, because those have previously

WARNING: line length of 90 exceeds 80 columns
#333: FILE: kernel/bpf/trampoline.c:1632:
+		WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,

CHECK: Alignment should match open parenthesis
#334: FILE: kernel/bpf/trampoline.c:1633:
+		WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,
+					NULL, &trampoline_multi_ops, &data));

WARNING: line length of 87 exceeds 80 columns
#338: FILE: kernel/bpf/trampoline.c:1637:
+		WARN_ON_ONCE(update_ftrace_direct_mod(&direct_ops, data.modify, true));

WARNING: line length of 91 exceeds 80 columns
#352: FILE: kernel/bpf/trampoline.c:1651:
+int bpf_trampoline_multi_detach(struct bpf_prog *prog, struct bpf_tracing_multi_link *link)

WARNING: line length of 90 exceeds 80 columns
#370: FILE: kernel/bpf/trampoline.c:1669:
+		WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,

CHECK: Alignment should match open parenthesis
#371: FILE: kernel/bpf/trampoline.c:1670:
+		WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline,
+					NULL, &trampoline_multi_ops, &data));

WARNING: line length of 87 exceeds 80 columns
#377: FILE: kernel/bpf/trampoline.c:1676:
+		WARN_ON_ONCE(update_ftrace_direct_mod(&direct_ops, data.modify, true));

WARNING: Block comments use * on subsequent lines
#389: FILE: kernel/bpf/trampoline.c:1688:
+#endif /* CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS &&
+	  CONFIG_HAVE_SINGLE_FTRACE_DIRECT_OPS &&

WARNING: Block comments use a trailing */ on a separate line
#390: FILE: kernel/bpf/trampoline.c:1689:
+	  CONFIG_BPF_SYSCALL */

total: 0 errors, 23 warnings, 7 checks, 329 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 26fc2077114f ("bpf: Add bpf_trampoline_multi_attach/detach functions") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 23 warnings, 7 checks, 329 lines checked