WARNING: Missing commit description - Add an appropriate one CHECK: Please don't use multiple blank lines #116: FILE: tools/kexec/uki_parser_bpf.c:40: + + CHECK: Alignment should match open parenthesis #120: FILE: tools/kexec/uki_parser_bpf.c:44: +static int fill_cmd(char *buf, __u32 cmd_word, __u32 pipeline_flag, + const char *src, __u32 data_len) WARNING: line length of 96 exceeds 80 columns #204: FILE: tools/kexec/uki_parser_bpf.c:128: + if (__builtin_memcmp(sec_name, linux_sect_name, sizeof(linux_sect_name)) == 0) { CHECK: braces {} should be used on all arms of this statement #204: FILE: tools/kexec/uki_parser_bpf.c:128: + if (__builtin_memcmp(sec_name, linux_sect_name, sizeof(linux_sect_name)) == 0) { [...] + else if (__builtin_memcmp(sec_name, initrd_sect_name, sizeof(initrd_sect_name)) == 0) [...] + else if (__builtin_memcmp(sec_name, cmdline_sect_name, sizeof(cmdline_sect_name)) == 0) [...] + else [...] WARNING: line length of 94 exceeds 80 columns #207: FILE: tools/kexec/uki_parser_bpf.c:131: + * .linux section may contain different format kernel, which should be WARNING: line length of 101 exceeds 80 columns #212: FILE: tools/kexec/uki_parser_bpf.c:136: + else if (__builtin_memcmp(sec_name, initrd_sect_name, sizeof(initrd_sect_name)) == 0) ERROR: else should follow close brace '}' #212: FILE: tools/kexec/uki_parser_bpf.c:136: + } + else if (__builtin_memcmp(sec_name, initrd_sect_name, sizeof(initrd_sect_name)) == 0) WARNING: line length of 103 exceeds 80 columns #214: FILE: tools/kexec/uki_parser_bpf.c:138: + else if (__builtin_memcmp(sec_name, cmdline_sect_name, sizeof(cmdline_sect_name)) == 0) CHECK: Alignment should match open parenthesis #230: FILE: tools/kexec/uki_parser_bpf.c:154: + ret = fill_cmd(scratch, + MAKE_CMD(KEXEC_BPF_CMD_COPY, subcmd), ERROR: else should follow close brace '}' #291: FILE: tools/kexec/uki_parser_bpf.c:215: + } + else { CHECK: Unbalanced braces around else statement #291: FILE: tools/kexec/uki_parser_bpf.c:215: + else { WARNING: unnecessary whitespace before a quoted newline #292: FILE: tools/kexec/uki_parser_bpf.c:216: + bpf_printk("fill KEXEC_BPF_CMD_DONE \n"); WARNING: line length of 88 exceeds 80 columns #293: FILE: tools/kexec/uki_parser_bpf.c:217: + ret = fill_cmd(scratch, MAKE_CMD(KEXEC_BPF_CMD_DONE, 0), CHECK: Alignment should match open parenthesis #294: FILE: tools/kexec/uki_parser_bpf.c:218: + ret = fill_cmd(scratch, MAKE_CMD(KEXEC_BPF_CMD_DONE, 0), + 0, NULL, 0); CHECK: Alignment should match open parenthesis #298: FILE: tools/kexec/uki_parser_bpf.c:222: + bpf_printk("parse_uki: inject KEXEC_BPF_CMD_DONE failed: %d\n", + ret); total: 2 errors, 7 warnings, 7 checks, 278 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 21f66c08e506 ("tools/kexec: Introduce a bpf-prog to handle UKI image") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.