WARNING: line length of 82 exceeds 80 columns #292: FILE: tools/kexec/template.c:65: + * This function ensures that the sections .rodata, .data, .rodata.str1.1 and .bss WARNING: Prefer __used over __attribute__((used)) #295: FILE: tools/kexec/template.c:68: +static const char dummy_rodata[16] __attribute__((used)) = "rodata"; WARNING: Prefer __used over __attribute__((used)) #296: FILE: tools/kexec/template.c:69: +static char dummy_data[16] __attribute__((used)) = "data"; WARNING: Prefer __used over __attribute__((used)) #297: FILE: tools/kexec/template.c:70: +static char *dummy_mergeable_str __attribute__((used)) = ".rodata.str1.1"; WARNING: Prefer __used over __attribute__((used)) #298: FILE: tools/kexec/template.c:71: +static char dummy_bss[16] __attribute__((used)); WARNING: Prefer __packed over __attribute__((packed)) #349: FILE: tools/kexec/zboot_parser_bpf.c:44: +} __attribute__((packed)); CHECK: Alignment should match open parenthesis #365: FILE: tools/kexec/zboot_parser_bpf.c:60: +static int fill_cmd(char *buf, __u16 cmd, __u16 subcmd, + const char *src, __u32 data_len) WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #409: FILE: tools/kexec/zboot_parser_bpf.c:104: + bpf_printk("do_zboot_decompress: PE image too large\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #425: FILE: tools/kexec/zboot_parser_bpf.c:120: + bpf_printk("do_zboot_decompress: VERIFY_SIG failed: %d\n", WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #434: FILE: tools/kexec/zboot_parser_bpf.c:129: + bpf_printk("do_zboot_decompress: failed to read zboot header\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #440: FILE: tools/kexec/zboot_parser_bpf.c:135: + bpf_printk("do_zboot_decompress: not a zboot image\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #446: FILE: tools/kexec/zboot_parser_bpf.c:141: + bpf_printk("do_zboot_decompress: payload offset=0x%x size=0x%x\n", WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #450: FILE: tools/kexec/zboot_parser_bpf.c:145: + bpf_printk("do_zboot_decompress: zboot payload too small\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #456: FILE: tools/kexec/zboot_parser_bpf.c:151: + bpf_printk("do_zboot_decompress: zboot payload out of bounds\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #462: FILE: tools/kexec/zboot_parser_bpf.c:157: + bpf_printk("do_zboot_decompress: zboot payload exceeds MAX_RECORD_SIZE\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #473: FILE: tools/kexec/zboot_parser_bpf.c:168: + bpf_printk("do_zboot_decompress: calling bpf_buffer_parser() for DECOMPRESS\n"); WARNING: Prefer using '"%s...", __func__' to using 'do_zboot_decompress', this function's name, in a string #476: FILE: tools/kexec/zboot_parser_bpf.c:171: + bpf_printk("do_zboot_decompress: decompression failed: %d\n", WARNING: line length of 81 exceeds 80 columns #485: FILE: tools/kexec/zboot_parser_bpf.c:180: +int BPF_PROG(parse_zboot, struct kexec_context *context, unsigned long parser_id) WARNING: line length of 98 exceeds 80 columns #595: FILE: tools/kexec/zboot_parser_bpf.c:290: + if (__builtin_memcmp(sec_name, initrd_sect_name, sizeof(initrd_sect_name)) == 0) { WARNING: line length of 100 exceeds 80 columns #611: FILE: tools/kexec/zboot_parser_bpf.c:306: + if (__builtin_memcmp(sec_name, cmdline_sect_name, sizeof(cmdline_sect_name)) == 0) { WARNING: line length of 94 exceeds 80 columns #627: FILE: tools/kexec/zboot_parser_bpf.c:322: + if (__builtin_memcmp(sec_name, linux_sect_name, sizeof(linux_sect_name)) != 0) WARNING: line length of 81 exceeds 80 columns #643: FILE: tools/kexec/zboot_parser_bpf.c:338: + bpf_printk("parse_zboot: KEXEC_BPF_CMD_DONE, failed: %d\n", ret); total: 0 errors, 21 warnings, 1 checks, 581 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b7fd298e9f4a ("tools/kexec: Introduce a bpf-prog to handle zboot image") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 1 checks, 581 lines checked