WARNING: Prefer __used over __attribute__((used)) #139: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:8: +__attribute__((used)) int BPF_PROG(parse_pe, struct kexec_context *context, CHECK: Alignment should match open parenthesis #140: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:9: +__attribute__((used)) int BPF_PROG(parse_pe, struct kexec_context *context, + unsigned long parser_id) WARNING: Improper SPDX comment style for 'kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h', please use '/*' instead #150: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:1: +// SPDX-License-Identifier: GPL-2.0-only WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #150: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:1: +// SPDX-License-Identifier: GPL-2.0-only CHECK: Please use a blank line after function/struct/union/enum declarations #202: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:53: +} +static void CHECK: Please use a blank line after function/struct/union/enum declarations #219: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:70: +} +static inline struct kexec_pe_parser_bpf * WARNING: Avoid line continuations in quoted strings #239: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:90: + static const char opts_data[] __attribute__((__aligned__(8))) = "\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #239: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:90: + static const char opts_data[] __attribute__((__aligned__(8))) = "\ WARNING: Avoid line continuations in quoted strings #350: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:201: + static const char opts_insn[] __attribute__((__aligned__(8))) = "\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #350: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:201: + static const char opts_insn[] __attribute__((__aligned__(8))) = "\ WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #509: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:360: +__attribute__((unused)) static void WARNING: line length of 82 exceeds 80 columns #510: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:361: +kexec_pe_parser_bpf__assert(struct kexec_pe_parser_bpf *s __attribute__((unused))) WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #510: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:361: +kexec_pe_parser_bpf__assert(struct kexec_pe_parser_bpf *s __attribute__((unused))) WARNING: It's generally not useful to have the filename in the file #531: FILE: kernel/kexec_bpf/template.c:5: +// Original file: kernel/kexec_bpf/template.c WARNING: line length of 82 exceeds 80 columns #591: FILE: kernel/kexec_bpf/template.c:65: + * This function ensures that the sections .rodata, .data, .rodata.str1.1 and .bss WARNING: Prefer __used over __attribute__((used)) #594: FILE: kernel/kexec_bpf/template.c:68: +static const char dummy_rodata[16] __attribute__((used)) = "rodata"; WARNING: Prefer __used over __attribute__((used)) #595: FILE: kernel/kexec_bpf/template.c:69: +static char dummy_data[16] __attribute__((used)) = "data"; WARNING: Prefer __used over __attribute__((used)) #596: FILE: kernel/kexec_bpf/template.c:70: +static char *dummy_mergeable_str __attribute__((used)) = ".rodata.str1.1"; WARNING: Prefer __used over __attribute__((used)) #597: FILE: kernel/kexec_bpf/template.c:71: +static char dummy_bss[16] __attribute__((used)); total: 0 errors, 16 warnings, 3 checks, 517 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c5e2cd6474a1 ("kexec_file: Introduce a bpf-prog lskel to run a format parser") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 16 warnings, 3 checks, 517 lines checked