CHECK: Prefer kernel type 'u16' over 'uint16_t' #70: FILE: kernel/kexec_bpf_loader.c:91: + uint16_t cmd; CHECK: Prefer kernel type 'u8' over 'uint8_t' #71: FILE: kernel/kexec_bpf_loader.c:92: + uint8_t subcmd; CHECK: Prefer kernel type 'u8' over 'uint8_t' #72: FILE: kernel/kexec_bpf_loader.c:93: + uint8_t pipeline_flag; CHECK: Prefer kernel type 'u32' over 'uint32_t' #74: FILE: kernel/kexec_bpf_loader.c:95: + uint32_t payload_len; CHECK: Prefer kernel type 'u16' over 'uint16_t' #76: FILE: kernel/kexec_bpf_loader.c:97: + uint16_t num_chunks; CHECK: Prefer kernel type 'u16' over 'uint16_t' #81: FILE: kernel/kexec_bpf_loader.c:102: + uint16_t type; CHECK: Prefer kernel type 'u32' over 'uint32_t' #82: FILE: kernel/kexec_bpf_loader.c:103: + uint32_t len; CHECK: Please don't use multiple blank lines #85: FILE: kernel/kexec_bpf_loader.c:106: + + CHECK: Prefer using the BIT macro #87: FILE: kernel/kexec_bpf_loader.c:108: +#define MAX_UNCOMPRESSED_BUF_SIZE (1 << 29) CHECK: Prefer using the BIT macro #88: FILE: kernel/kexec_bpf_loader.c:109: +#define CHUNK_SIZE (1 << 23) WARNING: line length of 81 exceeds 80 columns #111: FILE: kernel/kexec_bpf_loader.c:132: + if (unlikely((a->next_idx * a->chunk_size >= MAX_UNCOMPRESSED_BUF_SIZE))) CHECK: multiple assignments should be avoided #118: FILE: kernel/kexec_bpf_loader.c:139: + a->chunk_start = a->chunk_cur = p; CHECK: Alignment should match open parenthesis #124: FILE: kernel/kexec_bpf_loader.c:145: +static int merge_decompressed_data(struct decompress_mem_allocator *a, + char **out, unsigned long *size) CHECK: multiple assignments should be avoided #132: FILE: kernel/kexec_bpf_loader.c:153: + cur_dst = dst = __vmalloc(total_sz, GFP_KERNEL | __GFP_ACCOUNT); CHECK: Lines should not end with a '(' #152: FILE: kernel/kexec_bpf_loader.c:173: +static int decompress_mem_allocator_init( WARNING: line length of 85 exceeds 80 columns #156: FILE: kernel/kexec_bpf_loader.c:177: + unsigned long sz = (MAX_UNCOMPRESSED_BUF_SIZE / chunk_size) * sizeof(void *); CHECK: multiple assignments should be avoided #170: FILE: kernel/kexec_bpf_loader.c:191: + a->chunk_start = a->chunk_cur = buf; CHECK: Comparison to NULL could be written "a->chunk_base_addr[i]" #181: FILE: kernel/kexec_bpf_loader.c:202: + if (a->chunk_base_addr[i] != NULL) WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #204: FILE: kernel/kexec_bpf_loader.c:225: + BUG_ON(free < 0); CHECK: multiple assignments should be avoided #211: FILE: kernel/kexec_bpf_loader.c:232: + a->chunk_start = a->chunk_cur = allocate_chunk_memory(); WARNING: line length of 81 exceeds 80 columns #224: FILE: kernel/kexec_bpf_loader.c:245: + char **out_buf, unsigned long *out_sz, struct kexec_context *ctx) CHECK: Alignment should match open parenthesis #224: FILE: kernel/kexec_bpf_loader.c:245: +static int parser_cmd_decompress(char *compressed_data, int image_gz_sz, + char **out_buf, unsigned long *out_sz, struct kexec_context *ctx) CHECK: Alignment should match open parenthesis #241: FILE: kernel/kexec_bpf_loader.c:262: + pr_debug("Find decompressing method: %s, compressed sz:0x%x\n", + name, image_gz_sz); CHECK: Alignment should match open parenthesis #243: FILE: kernel/kexec_bpf_loader.c:264: + ret = decompressor(compressed_data, image_gz_sz, NULL, flush, + NULL, NULL, NULL); CHECK: Alignment should match open parenthesis #266: FILE: kernel/kexec_bpf_loader.c:287: + pr_info("Invalid payload size:0x%x, while buffer size:0x%x\n", + cmd->payload_len, pbuf->size); WARNING: line length of 85 exceeds 80 columns #274: FILE: kernel/kexec_bpf_loader.c:295: + ret = parser_cmd_decompress(buf, cmd->payload_len, &decompressed_buf, CHECK: Alignment should match open parenthesis #275: FILE: kernel/kexec_bpf_loader.c:296: + ret = parser_cmd_decompress(buf, cmd->payload_len, &decompressed_buf, + &decompressed_sz, ctx); total: 0 errors, 5 warnings, 22 checks, 258 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b819972708d1 ("kexec_file: Implement decompress method for parser") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 5 warnings, 22 checks, 258 lines checked