CHECK: Alignment should match open parenthesis #75: FILE: include/linux/bpf.h:4026: +struct bpf_parser_context *alloc_bpf_parser_context(bpf_parser_handler_t func, + void *data); WARNING: line length of 86 exceeds 80 columns #112: FILE: kernel/bpf/bpf_buffer_parser.c:15: +static inline unsigned int bpf_parser_context_hash_key(struct bpf_parser_context *ctx) WARNING: line length of 92 exceeds 80 columns #119: FILE: kernel/bpf/bpf_buffer_parser.c:22: + struct bpf_parser_context *ctx = container_of(kref, struct bpf_parser_context, ref); CHECK: Alignment should match open parenthesis #132: FILE: kernel/bpf/bpf_buffer_parser.c:35: +struct bpf_parser_context *alloc_bpf_parser_context(bpf_parser_handler_t func, + void *data) WARNING: Prefer kzalloc_obj over kzalloc with sizeof #137: FILE: kernel/bpf/bpf_buffer_parser.c:40: + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); CHECK: Please use a blank line after function/struct/union/enum declarations #200: FILE: kernel/bpf/bpf_buffer_parser.c:103: +} +CFI_NOSEAL(bpf_parser_context_release_dtor); CHECK: Comparison to NULL could be written "!buf" #210: FILE: kernel/bpf/bpf_buffer_parser.c:113: + if (buf == NULL || buf_sz <= 0) CHECK: Comparison to NULL could be written "!context->func" #213: FILE: kernel/bpf/bpf_buffer_parser.c:116: + if (unlikely(context->func == NULL)) CHECK: Comparison to NULL could be written "old_val" #218: FILE: kernel/bpf/bpf_buffer_parser.c:121: + if (old_val != NULL) CHECK: Please use a blank line after function/struct/union/enum declarations #249: FILE: kernel/bpf/bpf_buffer_parser.c:152: +} +__bpf_kfunc_end_defs(); ERROR: code indent should use tabs where possible #258: FILE: kernel/bpf/bpf_buffer_parser.c:161: + .owner = THIS_MODULE,$ WARNING: please, no spaces at the start of a line #258: FILE: kernel/bpf/bpf_buffer_parser.c:161: + .owner = THIS_MODULE,$ ERROR: code indent should use tabs where possible #259: FILE: kernel/bpf/bpf_buffer_parser.c:162: + .set = &buffer_parser_ids,$ WARNING: please, no spaces at the start of a line #259: FILE: kernel/bpf/bpf_buffer_parser.c:162: + .set = &buffer_parser_ids,$ CHECK: Please don't use multiple blank lines #262: FILE: kernel/bpf/bpf_buffer_parser.c:165: + + WARNING: line length of 89 exceeds 80 columns #277: FILE: kernel/bpf/bpf_buffer_parser.c:180: + ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING, &buffer_parser_kfunc_set); WARNING: line length of 83 exceeds 80 columns #279: FILE: kernel/bpf/bpf_buffer_parser.c:182: + ARRAY_SIZE(buffer_parser_dtors), total: 2 errors, 7 warnings, 8 checks, 219 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 3bb3032d2625 ("bpf: Introduce kfuncs to parser buffer content") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.