========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/veth_bql_test.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.1IofY5VMzK 2026-03-18 10:51:52.834372280 -0400 +++ /tmp/tmp.r5ydc2ehOb 2026-03-18 10:51:53.262366971 -0400 @@ -0,0 +1,72 @@ + +In veth_bql_test.sh line 95: +cleanup() { +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In veth_bql_test.sh line 96: + [ -n "$FLOOD_PID" ] && kill_process $FLOOD_PID + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$FLOOD_PID" ] && kill_process "$FLOOD_PID" + + +In veth_bql_test.sh line 97: + [ -n "$SINK_PID" ] && kill_process $SINK_PID + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$SINK_PID" ] && kill_process "$SINK_PID" + + +In veth_bql_test.sh line 98: + [ -n "$PING_PID" ] && kill_process $PING_PID + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + [ -n "$PING_PID" ] && kill_process "$PING_PID" + + +In veth_bql_test.sh line 366: + tc qdisc replace dev "$VETH_A" root $qdisc $opts + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + tc qdisc replace dev "$VETH_A" root "$qdisc" "$opts" + + +In veth_bql_test.sh line 367: + ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root $qdisc $opts + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root "$qdisc" "$opts" + + +In veth_bql_test.sh line 381: + ip netns exec "$NS" bash -c ' + ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that. + + +In veth_bql_test.sh line 500: + exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "$EXIT_STATUS" + + +In veth_bql_test.sh line 555: + exit $EXIT_STATUS + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "$EXIT_STATUS" + +For more information: + https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...