ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.1IofY5VMzK and /tmp/tmp.r5ydc2ehOb Tree base: c920117a3919 ("net: sched: add timeout count to NETDEV WATCHDOG message") Now at: 7fc2d60dc32d ("selftests: net: add veth BQL stress test") ====== Checking before the patch ====== ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/veth_bql_test.sh - 6b27e1c0d59869a390680e650dc4e1965bcab5b3d05f92971348b0a675881bd9 In veth_bql_test.sh line 95: cleanup() { ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In veth_bql_test.sh line 96: [ -n "$FLOOD_PID" ] && kill_process $FLOOD_PID ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ -n "$FLOOD_PID" ] && kill_process "$FLOOD_PID" In veth_bql_test.sh line 97: [ -n "$SINK_PID" ] && kill_process $SINK_PID ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ -n "$SINK_PID" ] && kill_process "$SINK_PID" In veth_bql_test.sh line 98: [ -n "$PING_PID" ] && kill_process $PING_PID ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ -n "$PING_PID" ] && kill_process "$PING_PID" In veth_bql_test.sh line 366: tc qdisc replace dev "$VETH_A" root $qdisc $opts ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$VETH_A" root "$qdisc" "$opts" In veth_bql_test.sh line 367: ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root $qdisc $opts ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$NS" tc qdisc replace dev "$VETH_B" root "$qdisc" "$opts" In veth_bql_test.sh line 381: ip netns exec "$NS" bash -c ' ^-- SC2016 (info): Expressions don't expand in single quotes, use double quotes for that. In veth_bql_test.sh line 500: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" In veth_bql_test.sh line 555: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C... Checking tools/testing/selftests/net/veth_bql_test_virtme.sh - 9ed5ec4ce32c7b7ca0c90f1d246ce67c8b82de0e36908a3de533bc3afccb231f tools/testing/selftests/net/veth_bql_test_virtme.sh is shellcheck compliant