====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.7k4F0IAgnh 2026-03-17 20:58:30.669297620 -0400 +++ /tmp/tmp.nXIK1loKe7 2026-03-17 20:58:32.187286667 -0400 @@ -2,3 +2,5 @@ -tools/testing/selftests/drivers/net/lib/py/env.py:167:0: C0301: Line too long (114/100) (line-too-long) -tools/testing/selftests/drivers/net/lib/py/env.py:196:0: C0301: Line too long (101/100) (line-too-long) -tools/testing/selftests/drivers/net/lib/py/env.py:197:0: C0301: Line too long (107/100) (line-too-long) +tools/testing/selftests/drivers/net/lib/py/env.py:168:0: C0301: Line too long (114/100) (line-too-long) +tools/testing/selftests/drivers/net/lib/py/env.py:197:0: C0301: Line too long (101/100) (line-too-long) +tools/testing/selftests/drivers/net/lib/py/env.py:198:0: C0301: Line too long (107/100) (line-too-long) +tools/testing/selftests/drivers/net/lib/py/env.py:399:0: C0301: Line too long (115/100) (line-too-long) +tools/testing/selftests/drivers/net/lib/py/env.py:523:0: C0301: Line too long (111/100) (line-too-long) @@ -6 +7,0 @@ -tools/testing/selftests/drivers/net/lib/py/env.py:8:0: E0401: Unable to import 'lib.py' (import-error) @@ -10,6 +11,6 @@ -tools/testing/selftests/drivers/net/lib/py/env.py:41:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -tools/testing/selftests/drivers/net/lib/py/env.py:53:20: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/lib/py/env.py:74:0: R0903: Too few public methods (1/2) (too-few-public-methods) -tools/testing/selftests/drivers/net/lib/py/env.py:103:0: R0902: Too many instance attributes (19/7) (too-many-instance-attributes) -tools/testing/selftests/drivers/net/lib/py/env.py:180:4: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/drivers/net/lib/py/env.py:185:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +tools/testing/selftests/drivers/net/lib/py/env.py:12:0: E0401: Unable to import 'lib.py' (import-error) +tools/testing/selftests/drivers/net/lib/py/env.py:42:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +tools/testing/selftests/drivers/net/lib/py/env.py:54:20: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:75:0: R0903: Too few public methods (1/2) (too-few-public-methods) +tools/testing/selftests/drivers/net/lib/py/env.py:104:0: R0902: Too many instance attributes (19/7) (too-many-instance-attributes) +tools/testing/selftests/drivers/net/lib/py/env.py:181:4: C0116: Missing function or method docstring (missing-function-docstring) @@ -17,9 +18,12 @@ -tools/testing/selftests/drivers/net/lib/py/env.py:221:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/lib/py/env.py:224:4: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/drivers/net/lib/py/env.py:231:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/lib/py/env.py:233:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/lib/py/env.py:250:4: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/drivers/net/lib/py/env.py:269:4: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/drivers/net/lib/py/env.py:297:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes) -tools/testing/selftests/drivers/net/lib/py/env.py:468:8: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/lib/py/env.py:491:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:187:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +tools/testing/selftests/drivers/net/lib/py/env.py:222:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:225:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/lib/py/env.py:232:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:234:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:251:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/lib/py/env.py:270:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/lib/py/env.py:298:0: R0902: Too many instance attributes (17/7) (too-many-instance-attributes) +tools/testing/selftests/drivers/net/lib/py/env.py:477:8: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:500:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:529:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/lib/py/env.py:543:12: W0719: Raising too general exception: Exception (broad-exception-raised) @@ -28 +32 @@ -Your code has been rated at 8.73/10 (previous run: 8.73/10, +0.00) +Your code has been rated at 8.75/10 (previous run: 8.73/10, +0.02) @@ -31,3 +35,50 @@ -tools/testing/selftests/drivers/net/psp.py:521:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) -tools/testing/selftests/drivers/net/psp.py:523:4: W0212: Access to a protected member _ns of a client class (protected-access) -tools/testing/selftests/drivers/net/psp.py:525:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) +tools/testing/selftests/drivers/net/psp.py:415:0: C0301: Line too long (113/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:457:0: C0301: Line too long (116/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:472:0: C0301: Line too long (113/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:505:0: C0301: Line too long (116/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:519:0: C0301: Line too long (113/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:531:0: C0301: Line too long (105/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:552:0: C0301: Line too long (116/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:567:0: C0301: Line too long (113/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:615:0: C0301: Line too long (116/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:669:0: C0301: Line too long (113/100) (line-too-long) +tools/testing/selftests/drivers/net/psp.py:1:0: C0302: Too many lines in module (1074/1000) (too-many-lines) +tools/testing/selftests/drivers/net/psp.py:403:0: R0914: Too many local variables (16/15) (too-many-locals) +tools/testing/selftests/drivers/net/psp.py:412:39: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:418:4: W0612: Unused variable 'remote_addr' (unused-variable) +tools/testing/selftests/drivers/net/psp.py:419:4: W0612: Unused variable 'nk_guest_addr' (unused-variable) +tools/testing/selftests/drivers/net/psp.py:469:39: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:494:19: W0718: Catching too general exception Exception (broad-exception-caught) +tools/testing/selftests/drivers/net/psp.py:463:46: W0613: Unused argument 'version' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:463:55: W0613: Unused argument 'ipver' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:488:12: W0612: Unused variable 'i' (unused-variable) +tools/testing/selftests/drivers/net/psp.py:516:39: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:541:19: W0718: Catching too general exception Exception (broad-exception-caught) +tools/testing/selftests/drivers/net/psp.py:510:44: W0613: Unused argument 'version' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:510:53: W0613: Unused argument 'ipver' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:535:12: W0612: Unused variable 'i' (unused-variable) +tools/testing/selftests/drivers/net/psp.py:564:39: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:557:45: W0613: Unused argument 'version' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:557:54: W0613: Unused argument 'ipver' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:627:38: W0212: Access to a protected member _nk_host_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:666:39: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:682:19: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:686:4: W0212: Access to a protected member _nk_host_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:687:4: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:822:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) +tools/testing/selftests/drivers/net/psp.py:824:4: W0212: Access to a protected member _ns of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:826:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) +tools/testing/selftests/drivers/net/psp.py:879:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:888:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:897:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:906:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:915:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:924:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:933:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:933:27: W0613: Unused argument 'version' (unused-argument) +tools/testing/selftests/drivers/net/psp.py:953:7: W0212: Access to a protected member _ns of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:955:22: W0212: Access to a protected member _ns of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:960:27: W0212: Access to a protected member _ns_peer of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:994:10: W0212: Access to a protected member _netns of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:998:60: W0212: Access to a protected member _nk_guest_ifname of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:22:0: W0611: Unused cmd imported from lib.py (unused-import) @@ -36 +87 @@ -Your code has been rated at 9.92/10 (previous run: 9.13/10, +0.79) +Your code has been rated at 9.13/10 (previous run: 9.92/10, -0.79)