ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.DakOTT9gtP and /tmp/tmp.MGTlPSBi2z
Tree base:
8f921f610054 ("netlink: update outdated comment")
Now at:
5a49158e765a ("selftests/vsock: fix vmtest.sh for read-only nested VM runners")
 ====== Checking before the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 14:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 15:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 44:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 230:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 265:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 372:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 378:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 382:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 410:
terminate_pids() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 452:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 483:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 518:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 529:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 556:
vm_dmesg_check() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 578:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 605:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 613:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 616:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 650:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 658:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 692:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 696:
ns_get_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 702:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 716:
test_ns_diff_global_host_connect_to_global_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 769:
test_ns_diff_global_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 812:
test_ns_diff_global_vm_connect_to_global_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 875:
test_ns_diff_global_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 926:
test_ns_diff_local_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 971:
test_ns_diff_local_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1019:
__test_loopback_two_netns() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1049:
test_ns_diff_global_to_local_loopback_local_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1059:
test_ns_diff_local_to_global_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1069:
test_ns_diff_local_to_local_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1079:
test_ns_diff_global_to_global_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1089:
test_ns_same_local_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1099:
test_ns_same_local_host_connect_to_local_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1142:
test_ns_same_local_vm_connect_to_local_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1178:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1200:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1210:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1220:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1230:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1240:
test_ns_host_vsock_child_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1262:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1274:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1286:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1303:
check_ns_delete_doesnt_break_connection() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1363:
test_ns_delete_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1367:
test_ns_delete_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1371:
test_ns_delete_both_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1438:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 14:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 15:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 44:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 45:
readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX)
         ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 232:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 272:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 380:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 386:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 390:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 423:
terminate_pids() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 465:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 467:
		--rwdir=/root=${TEST_HOME} \
                              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		--rwdir=/root="${TEST_HOME}" \


In vmtest.sh line 499:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 534:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 545:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 572:
vm_dmesg_check() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 594:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 621:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 629:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 632:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 666:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 674:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 708:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 712:
ns_get_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 718:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 732:
test_ns_diff_global_host_connect_to_global_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 785:
test_ns_diff_global_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 828:
test_ns_diff_global_vm_connect_to_global_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 891:
test_ns_diff_global_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 942:
test_ns_diff_local_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 987:
test_ns_diff_local_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1035:
__test_loopback_two_netns() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1065:
test_ns_diff_global_to_local_loopback_local_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1075:
test_ns_diff_local_to_global_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1085:
test_ns_diff_local_to_local_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1095:
test_ns_diff_global_to_global_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1105:
test_ns_same_local_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1115:
test_ns_same_local_host_connect_to_local_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1158:
test_ns_same_local_vm_connect_to_local_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1194:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1216:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1226:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1236:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1246:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1256:
test_ns_host_vsock_child_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1278:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1290:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1302:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1319:
check_ns_delete_doesnt_break_connection() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1379:
test_ns_delete_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1383:
test_ns_delete_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1387:
test_ns_delete_both_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1454:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...