====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/netem.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.BVmGkJMbcr 2026-03-13 18:11:53.101922275 -0400 +++ /tmp/tmp.YWhzDVM8qP 2026-03-13 18:11:53.593914837 -0400 @@ -0,0 +1,44 @@ + +In netem.sh line 62: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In netem.sh line 128: + $ksft_skip) + ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob. + + +In netem.sh line 140: +run_cmd() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In netem.sh line 384: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In netem.sh line 418: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In netem.sh line 475: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In netem.sh line 712: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In netem.sh line 753: +if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + +For more information: + https://www.shellcheck.net/wiki/SC2254 -- Quote expansions in case patterns... + https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C... + https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...