CHECK: Macro argument 'OL_TYPE' may be better as '(OL_TYPE)' to avoid precedence issues #62: FILE: drivers/net/netdevsim/tc.c:20: +#define QH(NAME, OL_TYPE, CMD_FLD, O_REPLACE, O_DESTROY, O_STATS, STATS_FLD) \ +static int handle_##NAME(struct net_device *dev, struct OL_TYPE *offload) \ +{ \ + switch (offload->CMD_FLD) { \ + case O_REPLACE: \ + case O_DESTROY: \ + /* Do nothing, accept offload */ \ + return 0; \ + case O_STATS: \ + /* Zero out the requested stats block */ \ + memset(&offload->STATS_FLD, 0, sizeof(offload->STATS_FLD)); \ + return 0; \ + default: \ + return -EOPNOTSUPP; \ + } \ } CHECK: Macro argument 'CMD_FLD' may be better as '(CMD_FLD)' to avoid precedence issues #62: FILE: drivers/net/netdevsim/tc.c:20: +#define QH(NAME, OL_TYPE, CMD_FLD, O_REPLACE, O_DESTROY, O_STATS, STATS_FLD) \ +static int handle_##NAME(struct net_device *dev, struct OL_TYPE *offload) \ +{ \ + switch (offload->CMD_FLD) { \ + case O_REPLACE: \ + case O_DESTROY: \ + /* Do nothing, accept offload */ \ + return 0; \ + case O_STATS: \ + /* Zero out the requested stats block */ \ + memset(&offload->STATS_FLD, 0, sizeof(offload->STATS_FLD)); \ + return 0; \ + default: \ + return -EOPNOTSUPP; \ + } \ } CHECK: Macro argument 'STATS_FLD' may be better as '(STATS_FLD)' to avoid precedence issues #62: FILE: drivers/net/netdevsim/tc.c:20: +#define QH(NAME, OL_TYPE, CMD_FLD, O_REPLACE, O_DESTROY, O_STATS, STATS_FLD) \ +static int handle_##NAME(struct net_device *dev, struct OL_TYPE *offload) \ +{ \ + switch (offload->CMD_FLD) { \ + case O_REPLACE: \ + case O_DESTROY: \ + /* Do nothing, accept offload */ \ + return 0; \ + case O_STATS: \ + /* Zero out the requested stats block */ \ + memset(&offload->STATS_FLD, 0, sizeof(offload->STATS_FLD)); \ + return 0; \ + default: \ + return -EOPNOTSUPP; \ + } \ } CHECK: Macro argument 'OL_TYPE' may be better as '(OL_TYPE)' to avoid precedence issues #94: FILE: drivers/net/netdevsim/tc.c:49: +#define SC(SETUP_LABEL, OL_TYPE, NAME) \ + case SETUP_LABEL: \ + { \ + return handle_##NAME(dev, (struct OL_TYPE *)type_data); \ + } total: 0 errors, 0 warnings, 4 checks, 73 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit fbca050eb558 ("netdevsim: generalize taprio offload") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 4 checks, 73 lines checked