CHECK: No space is necessary after a cast
#75: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:27:
+	const char *pa = *(const char **) ppa;

CHECK: No space is necessary after a cast
#76: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:28:
+	const char *pb = *(const char **) ppb;

WARNING: line length of 81 exceeds 80 columns
#81: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:33:
+static __u32 *get_ids(const char * const funcs[], int funcs_cnt, const char *mod)

WARNING: line length of 84 exceeds 80 columns
#137: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:89:
+		 * We keep pointer for each function name so we can get the original

WARNING: line length of 85 exceeds 80 columns
#138: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:90:
+		 * array index and have the resulting ids array matching the original

WARNING: line length of 81 exceeds 80 columns
#141: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:93:
+		 * Doing it this way allow us to easily test the cookies support,

WARNING: line length of 86 exceeds 80 columns
#170: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:122:
+	ASSERT_EQ(skel->bss->test_result_fentry, FUNCS_CNT + 1, "test_result_fentry");

WARNING: line length of 84 exceeds 80 columns
#171: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:123:
+	ASSERT_EQ(skel->bss->test_result_fexit, FUNCS_CNT + 1, "test_result_fexit");

WARNING: line length of 92 exceeds 80 columns
#205: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:157:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,

CHECK: Alignment should match open parenthesis
#206: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:158:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
+					"bpf_fentry_test*", NULL);

WARNING: line length of 89 exceeds 80 columns
#207: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:159:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))

WARNING: line length of 90 exceeds 80 columns
#210: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:162:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,

CHECK: Alignment should match open parenthesis
#211: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:163:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,
+					"bpf_fentry_test*", NULL);

WARNING: line length of 88 exceeds 80 columns
#212: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:164:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi"))

WARNING: line length of 96 exceeds 80 columns
#215: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:167:
+	skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s,

CHECK: Alignment should match open parenthesis
#216: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:168:
+	skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s,
+					"bpf_fentry_test1", NULL);

WARNING: line length of 91 exceeds 80 columns
#217: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:169:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry_s, "bpf_program__attach_tracing_multi"))

WARNING: line length of 94 exceeds 80 columns
#220: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:172:
+	skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s,

CHECK: Alignment should match open parenthesis
#221: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:173:
+	skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s,
+					"bpf_fentry_test1", NULL);

WARNING: line length of 90 exceeds 80 columns
#222: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:174:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit_s, "bpf_program__attach_tracing_multi"))

WARNING: line length of 92 exceeds 80 columns
#251: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:203:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,

CHECK: Alignment should match open parenthesis
#252: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:204:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
+						NULL, &opts);

WARNING: line length of 89 exceeds 80 columns
#253: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:205:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))

WARNING: line length of 90 exceeds 80 columns
#256: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:208:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,

CHECK: Alignment should match open parenthesis
#257: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:209:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,
+						NULL, &opts);

WARNING: line length of 88 exceeds 80 columns
#258: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:210:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi"))

WARNING: line length of 96 exceeds 80 columns
#263: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:215:
+	skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s,

CHECK: Alignment should match open parenthesis
#264: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:216:
+	skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s,
+						NULL, &opts);

WARNING: line length of 91 exceeds 80 columns
#265: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:217:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry_s, "bpf_program__attach_tracing_multi"))

WARNING: line length of 94 exceeds 80 columns
#268: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:220:
+	skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s,

CHECK: Alignment should match open parenthesis
#269: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:221:
+	skel->links.test_fexit_s = bpf_program__attach_tracing_multi(skel->progs.test_fexit_s,
+						NULL, &opts);

WARNING: line length of 90 exceeds 80 columns
#270: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:222:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit_s, "bpf_program__attach_tracing_multi"))

WARNING: line length of 92 exceeds 80 columns
#307: FILE: tools/testing/selftests/bpf/progs/tracing_multi_attach.c:9:
+__hidden extern int tracing_multi_arg_check(__u64 *ctx, __u64 *test_result, bool is_return);

WARNING: externs should be avoided in .c files
#355: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:11:
+extern const void bpf_fentry_test1 __ksym;

WARNING: externs should be avoided in .c files
#356: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:12:
+extern const void bpf_fentry_test2 __ksym;

WARNING: externs should be avoided in .c files
#357: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:13:
+extern const void bpf_fentry_test3 __ksym;

WARNING: externs should be avoided in .c files
#358: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:14:
+extern const void bpf_fentry_test4 __ksym;

WARNING: externs should be avoided in .c files
#359: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:15:
+extern const void bpf_fentry_test5 __ksym;

WARNING: externs should be avoided in .c files
#360: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:16:
+extern const void bpf_fentry_test6 __ksym;

WARNING: externs should be avoided in .c files
#361: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:17:
+extern const void bpf_fentry_test7 __ksym;

WARNING: externs should be avoided in .c files
#362: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:18:
+extern const void bpf_fentry_test8 __ksym;

WARNING: externs should be avoided in .c files
#363: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:19:
+extern const void bpf_fentry_test9 __ksym;

ERROR: "foo0 bar" should be "foo 0 bar"
#364: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:20:
+extern const void bpf_fentry_test10 __ksym;

WARNING: externs should be avoided in .c files
#364: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:20:
+extern const void bpf_fentry_test10 __ksym;

CHECK: No space is necessary after a cast
#368: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:24:
+	void *ip = (void *) bpf_get_func_ip(ctx);

CHECK: No space is necessary after a cast
#382: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:38:
+		a = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#386: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:42:
+		*test_result += err == 0 && a == 1;
 		                         ^

CHECK: No space is necessary after a cast
#392: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:48:
+		a = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#398: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:54:
+		*test_result += err == 0 && a == 2 && b == 3;
 		                         ^

CHECK: No space is necessary after a cast
#405: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:61:
+		a = (char) value;

CHECK: No space is necessary after a cast
#407: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:63:
+		b = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#413: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:69:
+		*test_result += err == 0 && a == 4 && b == 5 && c == 6;
 		                         ^

CHECK: No space is necessary after a cast
#421: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:77:
+		a = (void *) value;

CHECK: No space is necessary after a cast
#423: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:79:
+		b = (char) value;

CHECK: No space is necessary after a cast
#425: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:81:
+		c = (int) value;

WARNING: line length of 91 exceeds 80 columns
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;

CHECK: No space is necessary after a cast
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;

ERROR: space prohibited after that '&&' (ctx:WxW)
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;
 		                         ^

CHECK: No space is necessary after a cast
#442: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:98:
+		b = (void *) value;

CHECK: No space is necessary after a cast
#444: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:100:
+		c = (short) value;

CHECK: No space is necessary after a cast
#446: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:102:
+		d = (int) value;

WARNING: line length of 105 exceeds 80 columns
#452: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;

CHECK: No space is necessary after a cast
#452: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;

ERROR: space prohibited after that '&&' (ctx:WxW)
#452: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;
 		                         ^

CHECK: No space is necessary after a cast
#464: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:120:
+		b = (void *) value;

CHECK: No space is necessary after a cast
#466: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:122:
+		c = (short) value;

CHECK: No space is necessary after a cast
#468: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:124:
+		d = (int) value;

CHECK: No space is necessary after a cast
#470: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:126:
+		e = (void *) value;

WARNING: line length of 125 exceeds 80 columns
#476: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;

CHECK: No space is necessary after a cast
#476: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;

ERROR: space prohibited after that '&&' (ctx:WxW)
#476: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;
 		                         ^

total: 7 errors, 36 warnings, 28 checks, 451 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 950a73688996 ("selftests/bpf: Add tracing multi skel/pattern/ids attach tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.