WARNING: please, no spaces at the start of a line #117: FILE: kernel/bpf/trampoline.c:1446: + defined(CONFIG_HAVE_SINGLE_FTRACE_DIRECT_OPS)$ WARNING: line length of 86 exceeds 80 columns #132: FILE: kernel/bpf/trampoline.c:1461: +static int register_fentry_multi(struct bpf_trampoline *tr, void *new_addr, void *ptr) CHECK: No space is necessary after a cast #134: FILE: kernel/bpf/trampoline.c:1463: + unsigned long addr = (unsigned long) new_addr; WARNING: line length of 93 exceeds 80 columns #143: FILE: kernel/bpf/trampoline.c:1472: +static int unregister_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, void *old_addr, CHECK: No space is necessary after a cast #146: FILE: kernel/bpf/trampoline.c:1475: + unsigned long addr = (unsigned long) old_addr; WARNING: line length of 81 exceeds 80 columns #152: FILE: kernel/bpf/trampoline.c:1481: + return add_ftrace_hash_entry_direct(data->unreg, ip, addr) ? 0 : -ENOMEM; WARNING: line length of 89 exceeds 80 columns #155: FILE: kernel/bpf/trampoline.c:1484: +static int modify_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, void *old_addr, WARNING: line length of 81 exceeds 80 columns #156: FILE: kernel/bpf/trampoline.c:1485: + void *new_addr, bool lock_direct_mutex, void *ptr) CHECK: No space is necessary after a cast #158: FILE: kernel/bpf/trampoline.c:1487: + unsigned long addr = (unsigned long) new_addr; WARNING: line length of 82 exceeds 80 columns #164: FILE: kernel/bpf/trampoline.c:1493: + return add_ftrace_hash_entry_direct(data->modify, ip, addr) ? 0 : -ENOMEM; WARNING: line length of 84 exceeds 80 columns #173: FILE: kernel/bpf/trampoline.c:1502: +static int bpf_get_btf_id_target(struct btf *btf, struct bpf_prog *prog, u32 btf_id, WARNING: line length of 91 exceeds 80 columns #240: FILE: kernel/bpf/trampoline.c:1569: + err = btf_id_allow_sleepable(btf_id, tgt_info.tgt_addr, prog, btf); WARNING: line length of 86 exceeds 80 columns #245: FILE: kernel/bpf/trampoline.c:1574: + key = bpf_trampoline_compute_key(NULL, prog->aux->attach_btf, btf_id); WARNING: line length of 87 exceeds 80 columns #262: FILE: kernel/bpf/trampoline.c:1591: + err = __bpf_trampoline_link_prog(&mnode->node, mnode->trampoline, NULL, WARNING: line length of 86 exceeds 80 columns #277: FILE: kernel/bpf/trampoline.c:1606: + WARN_ON_ONCE(update_ftrace_direct_del(&direct_ops, data.reg)); WARNING: line length of 90 exceeds 80 columns #290: FILE: kernel/bpf/trampoline.c:1619: + WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline, CHECK: Alignment should match open parenthesis #291: FILE: kernel/bpf/trampoline.c:1620: + WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline, + NULL, &trampoline_multi_ops, &data)); WARNING: line length of 91 exceeds 80 columns #305: FILE: kernel/bpf/trampoline.c:1634: +int bpf_trampoline_multi_detach(struct bpf_prog *prog, struct bpf_tracing_multi_link *link) WARNING: line length of 90 exceeds 80 columns #323: FILE: kernel/bpf/trampoline.c:1652: + WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline, CHECK: Alignment should match open parenthesis #324: FILE: kernel/bpf/trampoline.c:1653: + WARN_ON_ONCE(__bpf_trampoline_unlink_prog(&mnode->node, mnode->trampoline, + NULL, &trampoline_multi_ops, &data)); WARNING: line length of 87 exceeds 80 columns #330: FILE: kernel/bpf/trampoline.c:1659: + WARN_ON_ONCE(update_ftrace_direct_mod(&direct_ops, data.modify, true)); WARNING: line length of 93 exceeds 80 columns #341: FILE: kernel/bpf/trampoline.c:1670: +#endif /* CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS) && CONFIG_HAVE_SINGLE_FTRACE_DIRECT_OPS */ total: 0 errors, 17 warnings, 5 checks, 284 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e65008e02018 ("bpf: Add bpf_trampoline_multi_attach/detach functions") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 17 warnings, 5 checks, 284 lines checked