WARNING: line length of 84 exceeds 80 columns #25: FILE: include/trace/events/f2fs.h:12: +#define show_dev_ino(entry) show_dev(entry->dev), (unsigned long long)entry->ino ERROR: Macros with complex values should be enclosed in parentheses #25: FILE: include/trace/events/f2fs.h:12: +#define show_dev_ino(entry) show_dev(entry->dev), (unsigned long long)entry->ino BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. CHECK: Macro argument 'entry' may be better as '(entry)' to avoid precedence issues #25: FILE: include/trace/events/f2fs.h:12: +#define show_dev_ino(entry) show_dev(entry->dev), (unsigned long long)entry->ino CHECK: Alignment should match open parenthesis #76: FILE: include/trace/events/f2fs.h:262: + TP_printk("dev = (%d,%d), ino = %llu, type: %s, mode = 0%o, ret = %d", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #136: FILE: include/trace/events/f2fs.h:431: + TP_printk("dev = (%d,%d), ino = %llu, nid = %u, offset = %u, freed = %d", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #178: FILE: include/trace/events/f2fs.h:516: + TP_printk("dev = (%d,%d), ino = %llu, nid = %u, block_address = 0x%llx", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #243: FILE: include/trace/events/f2fs.h:632: + TP_printk("dev = (%d,%d), ino = %llu, i_size = %lld offset:%llu, len:%llu, advise:%d", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #281: FILE: include/trace/events/f2fs.h:902: + TP_printk("dev = (%d,%d), pino = %llu, name:%s, flags:%u", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #300: FILE: include/trace/events/f2fs.h:931: + TP_printk("dev = (%d,%d), pino = %llu, name:%s, ino:%u, err:%d", show_dev_ino(__entry), WARNING: quoted string split across lines #323: FILE: include/trace/events/f2fs.h:964: + TP_printk("dev = (%d,%d), old_dir = %llu, old_name: %s, " + "new_dir = %llu, new_name: %s, flags = %u", CHECK: Alignment should match open parenthesis #365: FILE: include/trace/events/f2fs.h:1029: + TP_printk("dev = (%d,%d), ino = %llu, start_pos:%llu, end_pos:%llu, err:%d", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #416: FILE: include/trace/events/f2fs.h:1102: + TP_printk("dev = (%d,%d), ino = %llu pos = %lld len = %lu ki_flags = %x ki_ioprio = %x rw = %d", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #480: FILE: include/trace/events/f2fs.h:1323: + TP_printk("dev = (%d,%d), ino = %llu, pos = %llu, len = %u", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #501: FILE: include/trace/events/f2fs.h:1352: + TP_printk("dev = (%d,%d), ino = %llu, pos = %llu, len = %u, copied = %u", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #571: FILE: include/trace/events/f2fs.h:1493: + TP_printk("dev = (%d,%d), ino = %llu, index = %lu, flags: %s, ret: %s", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #623: FILE: include/trace/events/f2fs.h:1597: + TP_printk("dev = (%d,%d), ino = %llu, start = %lu nrpage = %u", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #642: FILE: include/trace/events/f2fs.h:1755: + TP_printk("dev = (%d,%d), ino = %llu, pgofs = %u, type = %s", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #750: FILE: include/trace/events/f2fs.h:1955: + TP_printk("dev = (%d,%d), ino = %llu, destroyed: node_cnt = %u, type = %s", show_dev_ino(__entry), CHECK: Alignment should match open parenthesis #814: FILE: include/trace/events/f2fs.h:2328: + TP_printk("dev = (%d,%d), ino = %llu, lblock:%lld, pblock:%lld", show_dev_ino(__entry), WARNING: quoted string split across lines #862: FILE: include/trace/events/f2fs.h:2405: TP_printk("entry_name %s, offset %llu, bytes %d, cmdline %s," + " pid %d, i_size %llu, ino %llu", CHECK: Alignment should match open parenthesis #886: FILE: include/trace/events/f2fs.h:2430: + TP_printk("ino %llu, offset %llu, bytes %d", + __entry->ino, total: 1 errors, 3 warnings, 17 checks, 791 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 6879891f6730 ("f2fs: widen trace event i_ino fields to u64") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.