WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #34: FILE: drivers/net/dsa/Kconfig:73: +config NET_DSA_MT7628 + tristate "MT7628 Embedded ethernet switch support" + select NET_DSA_TAG_MT7628 + help + This enables support for the switch in the MT7628 SoC. + CHECK: Lines should not end with a '(' #239: FILE: drivers/net/dsa/mt7628.c:179: + ret = regmap_write( CHECK: Lines should not end with a '(' #304: FILE: drivers/net/dsa/mt7628.c:244: + regmap_write( CHECK: Lines should not end with a '(' #369: FILE: drivers/net/dsa/mt7628.c:309: + regmap_update_bits( WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #374: FILE: drivers/net/dsa/mt7628.c:314: +static void esw_set_vlan_id(struct mt7628_esw *esw, unsigned vlan, unsigned vid) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #374: FILE: drivers/net/dsa/mt7628.c:314: +static void esw_set_vlan_id(struct mt7628_esw *esw, unsigned vlan, unsigned vid) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #376: FILE: drivers/net/dsa/mt7628.c:316: + unsigned s = MT7628_ESW_VLANI_VID_S * (vlan % 2); WARNING: Missing a blank line after declarations #377: FILE: drivers/net/dsa/mt7628.c:317: + unsigned s = MT7628_ESW_VLANI_VID_S * (vlan % 2); + regmap_update_bits(esw->regmap, MT7628_ESW_REG_VLANI(vlan / 2), WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #382: FILE: drivers/net/dsa/mt7628.c:322: +static void esw_set_pvid(struct mt7628_esw *esw, unsigned port, unsigned pvid) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #382: FILE: drivers/net/dsa/mt7628.c:322: +static void esw_set_pvid(struct mt7628_esw *esw, unsigned port, unsigned pvid) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #384: FILE: drivers/net/dsa/mt7628.c:324: + unsigned s = MT7628_ESW_PVIDC_PVID_S * (port % 2); WARNING: Missing a blank line after declarations #385: FILE: drivers/net/dsa/mt7628.c:325: + unsigned s = MT7628_ESW_PVIDC_PVID_S * (port % 2); + regmap_update_bits(esw->regmap, MT7628_ESW_REG_PVIDC(port / 2), WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #390: FILE: drivers/net/dsa/mt7628.c:330: +static void esw_set_vmsc(struct mt7628_esw *esw, unsigned vlan, unsigned msc) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #390: FILE: drivers/net/dsa/mt7628.c:330: +static void esw_set_vmsc(struct mt7628_esw *esw, unsigned vlan, unsigned msc) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #392: FILE: drivers/net/dsa/mt7628.c:332: + unsigned s = MT7628_ESW_VMSC_MSC_S * (vlan % 4); WARNING: Missing a blank line after declarations #393: FILE: drivers/net/dsa/mt7628.c:333: + unsigned s = MT7628_ESW_VMSC_MSC_S * (vlan % 4); + regmap_update_bits(esw->regmap, MT7628_ESW_REG_VMSC(vlan / 4), WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #398: FILE: drivers/net/dsa/mt7628.c:338: +static void esw_set_vub(struct mt7628_esw *esw, unsigned vlan, unsigned msc) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #398: FILE: drivers/net/dsa/mt7628.c:338: +static void esw_set_vub(struct mt7628_esw *esw, unsigned vlan, unsigned msc) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #400: FILE: drivers/net/dsa/mt7628.c:340: + unsigned s = MT7628_ESW_VUB_S * (vlan % 4); WARNING: Missing a blank line after declarations #401: FILE: drivers/net/dsa/mt7628.c:341: + unsigned s = MT7628_ESW_VUB_S * (vlan % 4); + regmap_update_bits(esw->regmap, MT7628_ESW_REG_VUB(vlan / 4), WARNING: Missing a blank line after declarations #410: FILE: drivers/net/dsa/mt7628.c:350: + int i; + for (i = 0; i < MT7628_NUM_VLANS; i++) { WARNING: Missing a blank line after declarations #412: FILE: drivers/net/dsa/mt7628.c:352: + struct mt7628_vlan *vlan = &esw->vlans[i]; + esw_set_vmsc(esw, i, vlan->members); WARNING: Missing a blank line after declarations #424: FILE: drivers/net/dsa/mt7628.c:364: + struct mt7628_esw *esw = ds->priv; + reset_control_reset(esw->rst_esw); WARNING: Missing a blank line after declarations #444: FILE: drivers/net/dsa/mt7628.c:384: + struct mt7628_esw *esw = ds->priv; + regmap_clear_bits(esw->regmap, MT7628_ESW_REG_POC0, WARNING: Missing a blank line after declarations #452: FILE: drivers/net/dsa/mt7628.c:392: + struct mt7628_esw *esw = ds->priv; + regmap_set_bits(esw->regmap, MT7628_ESW_REG_POC0, WARNING: Missing a blank line after declarations #478: FILE: drivers/net/dsa/mt7628.c:418: + struct mt7628_vlan *check_vlan = &esw->vlans[i]; + if (!check_vlan->active) { WARNING: Missing a blank line after declarations #510: FILE: drivers/net/dsa/mt7628.c:450: + struct mt7628_vlan *check_vlan = &esw->vlans[i]; + if (check_vlan->active || check_vlan->vid != vid) WARNING: Missing a blank line after declarations #588: FILE: drivers/net/dsa/mt7628.c:528: + struct mt7628_esw *esw = platform_get_drvdata(pdev); + if (!esw) WARNING: Missing a blank line after declarations #597: FILE: drivers/net/dsa/mt7628.c:537: + struct mt7628_esw *esw = platform_get_drvdata(pdev); + if (!esw) WARNING: DT compatible string "mediatek,mt7628-esw" appears un-documented -- check ./Documentation/devicetree/bindings/ #606: FILE: drivers/net/dsa/mt7628.c:546: + .compatible = "mediatek,mt7628-esw", WARNING: please, no spaces at the start of a line #614: FILE: drivers/net/dsa/mt7628.c:554: + .driver = {$ ERROR: code indent should use tabs where possible #615: FILE: drivers/net/dsa/mt7628.c:555: + .name = "mt7628-esw",$ WARNING: please, no spaces at the start of a line #615: FILE: drivers/net/dsa/mt7628.c:555: + .name = "mt7628-esw",$ ERROR: code indent should use tabs where possible #616: FILE: drivers/net/dsa/mt7628.c:556: + .of_match_table = mt7628_of_match,$ WARNING: please, no spaces at the start of a line #616: FILE: drivers/net/dsa/mt7628.c:556: + .of_match_table = mt7628_of_match,$ WARNING: please, no spaces at the start of a line #617: FILE: drivers/net/dsa/mt7628.c:557: + },$ WARNING: please, no spaces at the start of a line #618: FILE: drivers/net/dsa/mt7628.c:558: + .probe = mt7628_probe,$ WARNING: please, no spaces at the start of a line #619: FILE: drivers/net/dsa/mt7628.c:559: + .remove = mt7628_remove,$ WARNING: please, no spaces at the start of a line #620: FILE: drivers/net/dsa/mt7628.c:560: + .shutdown = mt7628_shutdown,$ WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #627: FILE: drivers/net/dsa/mt7628.c:567: +MODULE_LICENSE("GPL v2"); total: 2 errors, 35 warnings, 3 checks, 586 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 6e317b532c04 ("net: dsa: initial support for MT7628 embedded switch") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.