WARNING: line length of 84 exceeds 80 columns #43: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:13: + if (!ASSERT_OK(bpf_map_get_info_by_fd(map_fd, &info, &len), "get_map_info")) WARNING: line length of 84 exceeds 80 columns #53: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:23: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.count_ref), &opts); CHECK: Alignment should match open parenthesis #64: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:34: + LIBBPF_OPTS(bpf_test_run_opts, opts, + .data_in = &pkt_v4, WARNING: line length of 89 exceeds 80 columns #75: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:45: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.test_htab_leak), &opts); WARNING: Prefer using '"%s...", __func__' to using 'test_htab_leak', this function's name, in a string #76: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:46: + if (!ASSERT_OK(ret, "test_htab_leak run")) WARNING: Prefer using '"%s...", __func__' to using 'test_htab_leak', this function's name, in a string #78: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:48: + if (!ASSERT_OK(opts.retval, "test_htab_leak retval")) WARNING: line length of 89 exceeds 80 columns #93: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:63: + watcher->links.htab_map_free = bpf_program__attach(watcher->progs.htab_map_free); CHECK: Alignment should match open parenthesis #117: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:87: + LIBBPF_OPTS(bpf_test_run_opts, opts, + .data_in = &pkt_v4, WARNING: line length of 96 exceeds 80 columns #136: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:106: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.test_percpu_htab_leak), &opts); WARNING: Prefer using '"%s...", __func__' to using 'test_percpu_htab_leak', this function's name, in a string #137: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:107: + if (!ASSERT_OK(ret, "test_percpu_htab_leak run")) WARNING: Prefer using '"%s...", __func__' to using 'test_percpu_htab_leak', this function's name, in a string #139: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:109: + if (!ASSERT_OK(opts.retval, "test_percpu_htab_leak retval")) WARNING: line length of 89 exceeds 80 columns #154: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:124: + watcher->links.htab_map_free = bpf_program__attach(watcher->progs.htab_map_free); WARNING: line length of 85 exceeds 80 columns #215: FILE: tools/testing/selftests/bpf/prog_tests/map_kptr_race.c:185: + watcher->links.sk_map_free = bpf_program__attach(watcher->progs.sk_map_free); CHECK: spaces preferred around that '*' (ctx:WxV) #263: FILE: tools/testing/selftests/bpf/progs/map_kptr_race.c:9: + struct prog_test_ref_kfunc __kptr *ref_ptr; ^ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #293: FILE: tools/testing/selftests/bpf/progs/map_kptr_race.c:39: +const volatile int nr_cpus; CHECK: Alignment should match open parenthesis #385: FILE: tools/testing/selftests/bpf/progs/map_kptr_race.c:131: + v = bpf_sk_storage_get(&race_sk_ls_map, sk, NULL, + BPF_SK_STORAGE_GET_F_CREATE); total: 0 errors, 12 warnings, 4 checks, 415 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0178132ddfee ("selftests/bpf: Add tests for special fields races") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 4 checks, 415 lines checked