ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.j0SaadG5vQ and /tmp/tmp.CnDnPBdeTy Tree base: df0cfe5e557a ("netdevsim: Add devlink port resource registration") Now at: 7f2b87eb7335 ("selftest: netdevsim: Add devlink port resource test") ====== Checking before the patch ====== Checking tools/testing/selftests/drivers/net/netdevsim/devlink.sh - f1444de82439af96e37a8691454de2b2a7f6ecedf0f4a3b16dfb249a22e93677 In devlink.sh line 4: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In devlink.sh line 6: ALL_TESTS="fw_flash_test params_test \ ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In devlink.sh line 10: NUM_NETIFS=0 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In devlink.sh line 11: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In devlink.sh line 21: wait_for_devlink() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 23: "$@" | grep -q $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$@" | grep -q "$DL_HANDLE" In devlink.sh line 26: devlink_wait() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 33: fw_flash_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 44: echo "10"> $DEBUGFS_DIR/fw_update_flash_chunk_time_ms ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "10"> "$DEBUGFS_DIR"/fw_update_flash_chunk_time_ms In devlink.sh line 46: devlink dev flash $DL_HANDLE file $DUMMYFILE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" In devlink.sh line 49: devlink dev flash $DL_HANDLE file $DUMMYFILE component fw.mgmt ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" component fw.mgmt In devlink.sh line 52: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite settings In devlink.sh line 55: echo "1"> $DEBUGFS_DIR/fw_update_overwrite_mask ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "1"> "$DEBUGFS_DIR"/fw_update_overwrite_mask In devlink.sh line 58: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite settings In devlink.sh line 61: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite identifiers ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite identifiers In devlink.sh line 64: echo "3"> $DEBUGFS_DIR/fw_update_overwrite_mask ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "3"> "$DEBUGFS_DIR"/fw_update_overwrite_mask In devlink.sh line 67: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite identifiers overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite identifiers overwrite settings In devlink.sh line 70: echo "n"> $DEBUGFS_DIR/fw_update_status ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/fw_update_status In devlink.sh line 73: devlink dev flash $DL_HANDLE file $DUMMYFILE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" In devlink.sh line 79: param_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 89: param_set() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 95: devlink dev param set $DL_HANDLE name $name cmode $cmode value $value ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev param set "$DL_HANDLE" name "$name" cmode "$cmode" value "$value" In devlink.sh line 98: param_set_default() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 103: devlink dev param set $DL_HANDLE name $name default cmode $cmode ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev param set "$DL_HANDLE" name "$name" default cmode "$cmode" In devlink.sh line 106: check_value() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 120: value=$(param_get $name $attr $cmode) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: value=$(param_get "$name" "$attr" "$cmode") In devlink.sh line 124: value=$(<$DEBUGFS_DIR/$name) ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: value=$(<"$DEBUGFS_DIR"/"$name") In devlink.sh line 130: params_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 134: local max_macs ^------^ SC2034 (warning): max_macs appears unused. Verify use (or export if used externally). In devlink.sh line 135: local test1 ^---^ SC2034 (warning): test1 appears unused. Verify use (or export if used externally). In devlink.sh line 148: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 156: value_to_debugfs() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 173: test_default() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 183: default_debugfs=$(value_to_debugfs $expected_default) ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: default_debugfs=$(value_to_debugfs "$expected_default") In devlink.sh line 184: new_debugfs=$(value_to_debugfs $new_value) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_debugfs=$(value_to_debugfs "$new_value") In devlink.sh line 187: check_value $param_name initial-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" initial-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 189: param_set $param_name $new_value $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: param_set "$param_name" "$new_value" "$cmode" In devlink.sh line 193: check_value $param_name post-set $new_value $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-set "$new_value" "$expected_debugfs" "$cmode" In devlink.sh line 195: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 199: check_value $param_name post-reload-new-value $new_value $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-reload-new-value "$new_value" "$expected_debugfs" "$cmode" In devlink.sh line 201: param_set_default $param_name $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: param_set_default "$param_name" "$cmode" In devlink.sh line 205: check_value $param_name post-set-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-set-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 207: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 211: check_value $param_name post-reload-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-reload-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 214: params_default_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 232: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 242: check_region_size() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 247: size=$(devlink region show $DL_HANDLE/$name -j | jq -e -r '.[][].size') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: size=$(devlink region show "$DL_HANDLE"/"$name" -j | jq -e -r '.[][].size') In devlink.sh line 249: [ $size -eq 32768 ] ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$size" -eq 32768 ] In devlink.sh line 253: check_region_snapshot_count() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 260: count=$(devlink region show $DL_HANDLE/$name -j | jq -e -r '.[][].snapshot | length') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: count=$(devlink region show "$DL_HANDLE"/"$name" -j | jq -e -r '.[][].snapshot | length') In devlink.sh line 261: [ $count -eq $expected_count ] ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$count" -eq "$expected_count" ] In devlink.sh line 265: regions_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 274: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 278: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 282: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 286: devlink region del $DL_HANDLE/dummy snapshot 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot 1 In devlink.sh line 291: devlink region new $DL_HANDLE/dummy snapshot 25 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region new "$DL_HANDLE"/dummy snapshot 25 In devlink.sh line 296: devlink region dump $DL_HANDLE/dummy snapshot 25 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region dump "$DL_HANDLE"/dummy snapshot 25 >> /dev/null In devlink.sh line 299: devlink region read $DL_HANDLE/dummy snapshot 25 addr 0 len 1 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 0 len 1 >> /dev/null In devlink.sh line 302: devlink region read $DL_HANDLE/dummy snapshot 25 addr 128 len 128 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 128 len 128 >> /dev/null In devlink.sh line 305: devlink region read $DL_HANDLE/dummy snapshot 25 addr 128 len $((1<<32)) >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 128 len $((1<<32)) >> /dev/null In devlink.sh line 308: devlink region read $DL_HANDLE/dummy snapshot 25 addr $((1<<32)) len 128 >> /dev/null 2>&1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr $((1<<32)) len 128 >> /dev/null 2>&1 In devlink.sh line 311: devlink region del $DL_HANDLE/dummy snapshot 25 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot 25 In devlink.sh line 316: sid=$(devlink -j region new $DL_HANDLE/dummy | jq '.[][][][]') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sid=$(devlink -j region new "$DL_HANDLE"/dummy | jq '.[][][][]') In devlink.sh line 321: devlink region dump $DL_HANDLE/dummy snapshot $sid >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region dump "$DL_HANDLE"/dummy snapshot "$sid" >> /dev/null In devlink.sh line 324: devlink region del $DL_HANDLE/dummy snapshot $sid ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot "$sid" In devlink.sh line 332: reload_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 336: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 339: echo "y"> $DEBUGFS_DIR/fail_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "y"> "$DEBUGFS_DIR"/fail_reload In devlink.sh line 342: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 345: echo "n"> $DEBUGFS_DIR/fail_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/fail_reload In devlink.sh line 348: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 351: echo "y"> $DEBUGFS_DIR/dont_allow_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "y"> "$DEBUGFS_DIR"/dont_allow_reload In devlink.sh line 354: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 357: echo "n"> $DEBUGFS_DIR/dont_allow_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/dont_allow_reload In devlink.sh line 360: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 366: netns_reload_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 375: devlink dev reload $DL_HANDLE netns testns1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" netns testns1 In devlink.sh line 378: devlink -N testns1 dev reload $DL_HANDLE netns testns2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" netns testns2 In devlink.sh line 392: res_val_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 404: resource_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 413: devlink dev reload $DL_HANDLE netns testns1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" netns testns1 In devlink.sh line 418: ip -n testns1 link add name $DUMMYDEV type dummy ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 link add name "$DUMMYDEV" type dummy In devlink.sh line 420: ip -n testns1 link set $DUMMYDEV up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 link set "$DUMMYDEV" up In devlink.sh line 422: ip -n testns1 a a 192.0.1.1/24 dev $DUMMYDEV ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 a a 192.0.1.1/24 dev "$DUMMYDEV" In devlink.sh line 425: local occ=$(res_val_get testns1 IPv4 fib occ) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 430: devlink -N testns1 resource set $DL_HANDLE path IPv4/fib size $limit ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 resource set "$DL_HANDLE" path IPv4/fib size "$limit" In devlink.sh line 432: local size_new=$(res_val_get testns1 IPv4 fib size_new) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 436: devlink -N testns1 dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" In devlink.sh line 438: local size=$(res_val_get testns1 IPv4 fib size) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 456: ip -n testns2 link add name $DUMMYDEV type dummy ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 link add name "$DUMMYDEV" type dummy In devlink.sh line 458: ip -n testns2 link set $DUMMYDEV up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 link set "$DUMMYDEV" up In devlink.sh line 460: ip -n testns2 a a 192.0.1.1/24 dev $DUMMYDEV ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 a a 192.0.1.1/24 dev "$DUMMYDEV" In devlink.sh line 467: devlink -N testns1 dev reload $DL_HANDLE netns testns2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" netns testns2 In devlink.sh line 470: devlink -N testns2 resource set $DL_HANDLE path IPv4/fib size ' -1' ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns2 resource set "$DL_HANDLE" path IPv4/fib size ' -1' In devlink.sh line 473: devlink -N testns2 dev reload $DL_HANDLE netns 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns2 dev reload "$DL_HANDLE" netns 1 In devlink.sh line 485: resource_dump_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 500: info_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 507: dev_info_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 519: empty_reporter_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 523: devlink health show $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health show "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 526: devlink health dump show $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump show "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 529: devlink health diagnose $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health diagnose "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 532: devlink health recover $DL_HANDLE reporter empty ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter empty In devlink.sh line 538: check_reporter_info() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 547: local show=$(devlink health show $DL_HANDLE reporter $name -j | jq -e -r ".[][][]") ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local show=$(devlink health show "$DL_HANDLE" reporter "$name" -j | jq -e -r ".[][][]") In devlink.sh line 550: local state=$(echo $show | jq -r ".state") ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local state=$(echo "$show" | jq -r ".state") In devlink.sh line 554: local error=$(echo $show | jq -r ".error") ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local error=$(echo "$show" | jq -r ".error") In devlink.sh line 558: local recover=`echo $show | jq -r ".recover"` ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local recover=$(echo "$show" | jq -r ".recover") In devlink.sh line 562: local grace_period=$(echo $show | jq -r ".grace_period") ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local grace_period=$(echo "$show" | jq -r ".grace_period") In devlink.sh line 567: local auto_recover=$(echo $show | jq -r ".auto_recover") ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local auto_recover=$(echo "$show" | jq -r ".auto_recover") In devlink.sh line 572: dummy_reporter_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 578: devlink health set $DL_HANDLE reporter dummy auto_recover false ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy auto_recover false In devlink.sh line 584: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 589: local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump=$(devlink health dump show "$DL_HANDLE" reporter dummy -j) In devlink.sh line 592: local dump_break_msg=$(echo $dump | jq -r ".break_message") ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump_break_msg=$(echo "$dump" | jq -r ".break_message") In devlink.sh line 596: devlink health dump clear $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump clear "$DL_HANDLE" reporter dummy In devlink.sh line 599: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 604: devlink health set $DL_HANDLE reporter dummy auto_recover true ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy auto_recover true In devlink.sh line 609: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 614: local diagnose=$(devlink health diagnose $DL_HANDLE reporter dummy -j -p) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local diagnose=$(devlink health diagnose "$DL_HANDLE" reporter dummy -j -p) In devlink.sh line 617: local rcvrd_break_msg=$(echo $diagnose | jq -r ".recovered_break_message") ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rcvrd_break_msg=$(echo "$diagnose" | jq -r ".recovered_break_message") In devlink.sh line 621: devlink health set $DL_HANDLE reporter dummy grace_period 10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy grace_period 10 In devlink.sh line 626: echo "Y"> $DEBUGFS_DIR/health/fail_recover ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "Y"> "$DEBUGFS_DIR"/health/fail_recover In devlink.sh line 629: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 634: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 637: echo "N"> $DEBUGFS_DIR/health/fail_recover ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "N"> "$DEBUGFS_DIR"/health/fail_recover In devlink.sh line 640: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 645: echo 8192 > $DEBUGFS_DIR/health/binary_len ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo 8192 > "$DEBUGFS_DIR"/health/binary_len In devlink.sh line 648: local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump=$(devlink health dump show "$DL_HANDLE" reporter dummy -j) In devlink.sh line 651: devlink health dump clear $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump clear "$DL_HANDLE" reporter dummy In devlink.sh line 657: rate_leafs_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 662: '.[] | to_entries | .[] | select(.value.type == "leaf") | .key | select(contains("'$handle'"))' ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: '.[] | to_entries | .[] | select(.value.type == "leaf") | .key | select(contains("'"$handle"'"))' In devlink.sh line 665: rate_nodes_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 670: '.[] | to_entries | .[] | select(.value.type == "node") | .key | select(contains("'$handle'"))' ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: '.[] | to_entries | .[] | select(.value.type == "node") | .key | select(contains("'"$handle"'"))' In devlink.sh line 673: rate_attr_set() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 680: devlink port function rate set $handle $name $value$units ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate set "$handle" "$name" "$value""$units" In devlink.sh line 683: rate_attr_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 688: cmd_jq "devlink port function rate show $handle -j" '.[][].'$name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cmd_jq "devlink port function rate show $handle -j" '.[][].'"$name" In devlink.sh line 691: rate_attr_tx_rate_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 698: rate_attr_set $handle $name $rate mbit ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_set "$handle" "$name" "$rate" mbit In devlink.sh line 701: local debug_value=$(cat $debug_file) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local debug_value=$(cat "$debug_file") In devlink.sh line 706: local api_value=$(( $(rate_attr_get $handle $name) * 8 / 1000000 )) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local api_value=$(( $(rate_attr_get "$handle" "$name") * 8 / 1000000 )) In devlink.sh line 712: rate_attr_parent_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 718: rate_attr_set $handle parent $parent ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_set "$handle" parent "$parent" In devlink.sh line 721: debug_value=$(cat $debug_file) ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: debug_value=$(cat "$debug_file") In devlink.sh line 726: api_value=$(rate_attr_get $r_obj parent) ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: api_value=$(rate_attr_get "$r_obj" parent) In devlink.sh line 732: rate_attr_tc_bw_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 772: rate_node_add() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 776: devlink port function rate add $handle ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate add "$handle" In devlink.sh line 779: rate_node_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 783: devlink port function rate del $handle ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate del "$handle" In devlink.sh line 786: rate_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 788: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In devlink.sh line 790: echo $VF_COUNT > /sys/bus/netdevsim/devices/$DEV_NAME/sriov_numvfs ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$VF_COUNT" > /sys/bus/netdevsim/devices/"$DEV_NAME"/sriov_numvfs In devlink.sh line 791: devlink dev eswitch set $DL_HANDLE mode switchdev ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev eswitch set "$DL_HANDLE" mode switchdev In devlink.sh line 792: local leafs=`rate_leafs_get $DL_HANDLE` ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local leafs=$(rate_leafs_get "$DL_HANDLE") In devlink.sh line 793: local num_leafs=`echo $leafs | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_leafs=$(echo "$leafs" | wc -w) In devlink.sh line 800: rate_attr_tx_rate_check $r_obj tx_share $rate \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$r_obj" tx_share "$rate" \ In devlink.sh line 801: $DEBUGFS_DIR/ports/${r_obj##*/}/tx_share ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/tx_share In devlink.sh line 802: rate=$(($rate+10)) ^---^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In devlink.sh line 808: rate_attr_tx_rate_check $r_obj tx_max $rate \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$r_obj" tx_max "$rate" \ In devlink.sh line 809: $DEBUGFS_DIR/ports/${r_obj##*/}/tx_max ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/tx_max In devlink.sh line 810: rate=$(($rate+100)) ^---^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In devlink.sh line 825: local num_nodes=`rate_nodes_get $DL_HANDLE | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_nodes=$(rate_nodes_get "$DL_HANDLE" | wc -w) In devlink.sh line 826: [ $num_nodes == 1 ] ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$num_nodes" == 1 ] In devlink.sh line 830: rate_attr_tx_rate_check $node1 tx_share $node_tx_share \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$node1" tx_share "$node_tx_share" \ In devlink.sh line 831: $DEBUGFS_DIR/rate_nodes/${node1##*/}/tx_share ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"/tx_share In devlink.sh line 834: rate_attr_tx_rate_check $node1 tx_max $node_tx_max \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$node1" tx_max "$node_tx_max" \ In devlink.sh line 835: $DEBUGFS_DIR/rate_nodes/${node1##*/}/tx_max ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"/tx_max In devlink.sh line 839: rate_attr_tc_bw_check $node1 "$tc_bw" \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tc_bw_check "$node1" "$tc_bw" \ In devlink.sh line 845: local num_nodes=`rate_nodes_get $DL_HANDLE | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_nodes=$(rate_nodes_get "$DL_HANDLE" | wc -w) In devlink.sh line 846: [ $num_nodes == 0 ] ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$num_nodes" == 0 ] In devlink.sh line 854: rate_attr_parent_check $r_obj $node1_name \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_parent_check "$r_obj" "$node1_name" \ In devlink.sh line 855: $DEBUGFS_DIR/ports/${r_obj##*/}/rate_parent ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/rate_parent In devlink.sh line 862: rate_attr_parent_check $node2 $node1_name \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_parent_check "$node2" "$node1_name" \ In devlink.sh line 863: $DEBUGFS_DIR/rate_nodes/$node2_name/rate_parent ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"$node2_name"/rate_parent In devlink.sh line 881: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 894: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC1091 -- Not following: ./lib.sh: openBina... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/netdevsim/devlink.sh - f1444de82439af96e37a8691454de2b2a7f6ecedf0f4a3b16dfb249a22e93677 In devlink.sh line 4: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In devlink.sh line 6: ALL_TESTS="fw_flash_test params_test \ ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In devlink.sh line 11: NUM_NETIFS=0 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In devlink.sh line 12: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In devlink.sh line 22: wait_for_devlink() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 24: "$@" | grep -q $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$@" | grep -q "$DL_HANDLE" In devlink.sh line 27: devlink_wait() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 34: fw_flash_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 45: echo "10"> $DEBUGFS_DIR/fw_update_flash_chunk_time_ms ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "10"> "$DEBUGFS_DIR"/fw_update_flash_chunk_time_ms In devlink.sh line 47: devlink dev flash $DL_HANDLE file $DUMMYFILE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" In devlink.sh line 50: devlink dev flash $DL_HANDLE file $DUMMYFILE component fw.mgmt ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" component fw.mgmt In devlink.sh line 53: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite settings In devlink.sh line 56: echo "1"> $DEBUGFS_DIR/fw_update_overwrite_mask ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "1"> "$DEBUGFS_DIR"/fw_update_overwrite_mask In devlink.sh line 59: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite settings In devlink.sh line 62: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite identifiers ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite identifiers In devlink.sh line 65: echo "3"> $DEBUGFS_DIR/fw_update_overwrite_mask ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "3"> "$DEBUGFS_DIR"/fw_update_overwrite_mask In devlink.sh line 68: devlink dev flash $DL_HANDLE file $DUMMYFILE overwrite identifiers overwrite settings ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" overwrite identifiers overwrite settings In devlink.sh line 71: echo "n"> $DEBUGFS_DIR/fw_update_status ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/fw_update_status In devlink.sh line 74: devlink dev flash $DL_HANDLE file $DUMMYFILE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev flash "$DL_HANDLE" file "$DUMMYFILE" In devlink.sh line 80: param_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 90: param_set() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 96: devlink dev param set $DL_HANDLE name $name cmode $cmode value $value ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev param set "$DL_HANDLE" name "$name" cmode "$cmode" value "$value" In devlink.sh line 99: param_set_default() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 104: devlink dev param set $DL_HANDLE name $name default cmode $cmode ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev param set "$DL_HANDLE" name "$name" default cmode "$cmode" In devlink.sh line 107: check_value() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 121: value=$(param_get $name $attr $cmode) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: value=$(param_get "$name" "$attr" "$cmode") In devlink.sh line 125: value=$(<$DEBUGFS_DIR/$name) ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: value=$(<"$DEBUGFS_DIR"/"$name") In devlink.sh line 131: params_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 135: local max_macs ^------^ SC2034 (warning): max_macs appears unused. Verify use (or export if used externally). In devlink.sh line 136: local test1 ^---^ SC2034 (warning): test1 appears unused. Verify use (or export if used externally). In devlink.sh line 149: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 157: value_to_debugfs() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 174: test_default() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 184: default_debugfs=$(value_to_debugfs $expected_default) ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: default_debugfs=$(value_to_debugfs "$expected_default") In devlink.sh line 185: new_debugfs=$(value_to_debugfs $new_value) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_debugfs=$(value_to_debugfs "$new_value") In devlink.sh line 188: check_value $param_name initial-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" initial-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 190: param_set $param_name $new_value $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: param_set "$param_name" "$new_value" "$cmode" In devlink.sh line 194: check_value $param_name post-set $new_value $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-set "$new_value" "$expected_debugfs" "$cmode" In devlink.sh line 196: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 200: check_value $param_name post-reload-new-value $new_value $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-reload-new-value "$new_value" "$expected_debugfs" "$cmode" In devlink.sh line 202: param_set_default $param_name $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: param_set_default "$param_name" "$cmode" In devlink.sh line 206: check_value $param_name post-set-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-set-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 208: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 212: check_value $param_name post-reload-default $expected_default $expected_debugfs $cmode ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_value "$param_name" post-reload-default "$expected_default" "$expected_debugfs" "$cmode" In devlink.sh line 215: params_default_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 233: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 243: check_region_size() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 248: size=$(devlink region show $DL_HANDLE/$name -j | jq -e -r '.[][].size') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: size=$(devlink region show "$DL_HANDLE"/"$name" -j | jq -e -r '.[][].size') In devlink.sh line 250: [ $size -eq 32768 ] ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$size" -eq 32768 ] In devlink.sh line 254: check_region_snapshot_count() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 261: count=$(devlink region show $DL_HANDLE/$name -j | jq -e -r '.[][].snapshot | length') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: count=$(devlink region show "$DL_HANDLE"/"$name" -j | jq -e -r '.[][].snapshot | length') In devlink.sh line 262: [ $count -eq $expected_count ] ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$count" -eq "$expected_count" ] In devlink.sh line 266: regions_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 275: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 279: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 283: echo ""> $DEBUGFS_DIR/take_snapshot ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ""> "$DEBUGFS_DIR"/take_snapshot In devlink.sh line 287: devlink region del $DL_HANDLE/dummy snapshot 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot 1 In devlink.sh line 292: devlink region new $DL_HANDLE/dummy snapshot 25 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region new "$DL_HANDLE"/dummy snapshot 25 In devlink.sh line 297: devlink region dump $DL_HANDLE/dummy snapshot 25 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region dump "$DL_HANDLE"/dummy snapshot 25 >> /dev/null In devlink.sh line 300: devlink region read $DL_HANDLE/dummy snapshot 25 addr 0 len 1 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 0 len 1 >> /dev/null In devlink.sh line 303: devlink region read $DL_HANDLE/dummy snapshot 25 addr 128 len 128 >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 128 len 128 >> /dev/null In devlink.sh line 306: devlink region read $DL_HANDLE/dummy snapshot 25 addr 128 len $((1<<32)) >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr 128 len $((1<<32)) >> /dev/null In devlink.sh line 309: devlink region read $DL_HANDLE/dummy snapshot 25 addr $((1<<32)) len 128 >> /dev/null 2>&1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region read "$DL_HANDLE"/dummy snapshot 25 addr $((1<<32)) len 128 >> /dev/null 2>&1 In devlink.sh line 312: devlink region del $DL_HANDLE/dummy snapshot 25 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot 25 In devlink.sh line 317: sid=$(devlink -j region new $DL_HANDLE/dummy | jq '.[][][][]') ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sid=$(devlink -j region new "$DL_HANDLE"/dummy | jq '.[][][][]') In devlink.sh line 322: devlink region dump $DL_HANDLE/dummy snapshot $sid >> /dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region dump "$DL_HANDLE"/dummy snapshot "$sid" >> /dev/null In devlink.sh line 325: devlink region del $DL_HANDLE/dummy snapshot $sid ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink region del "$DL_HANDLE"/dummy snapshot "$sid" In devlink.sh line 333: reload_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 337: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 340: echo "y"> $DEBUGFS_DIR/fail_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "y"> "$DEBUGFS_DIR"/fail_reload In devlink.sh line 343: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 346: echo "n"> $DEBUGFS_DIR/fail_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/fail_reload In devlink.sh line 349: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 352: echo "y"> $DEBUGFS_DIR/dont_allow_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "y"> "$DEBUGFS_DIR"/dont_allow_reload In devlink.sh line 355: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 358: echo "n"> $DEBUGFS_DIR/dont_allow_reload ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "n"> "$DEBUGFS_DIR"/dont_allow_reload In devlink.sh line 361: devlink dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" In devlink.sh line 367: netns_reload_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 376: devlink dev reload $DL_HANDLE netns testns1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" netns testns1 In devlink.sh line 379: devlink -N testns1 dev reload $DL_HANDLE netns testns2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" netns testns2 In devlink.sh line 393: res_val_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 405: resource_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 414: devlink dev reload $DL_HANDLE netns testns1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev reload "$DL_HANDLE" netns testns1 In devlink.sh line 419: ip -n testns1 link add name $DUMMYDEV type dummy ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 link add name "$DUMMYDEV" type dummy In devlink.sh line 421: ip -n testns1 link set $DUMMYDEV up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 link set "$DUMMYDEV" up In devlink.sh line 423: ip -n testns1 a a 192.0.1.1/24 dev $DUMMYDEV ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns1 a a 192.0.1.1/24 dev "$DUMMYDEV" In devlink.sh line 426: local occ=$(res_val_get testns1 IPv4 fib occ) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 431: devlink -N testns1 resource set $DL_HANDLE path IPv4/fib size $limit ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 resource set "$DL_HANDLE" path IPv4/fib size "$limit" In devlink.sh line 433: local size_new=$(res_val_get testns1 IPv4 fib size_new) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 437: devlink -N testns1 dev reload $DL_HANDLE ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" In devlink.sh line 439: local size=$(res_val_get testns1 IPv4 fib size) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink.sh line 457: ip -n testns2 link add name $DUMMYDEV type dummy ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 link add name "$DUMMYDEV" type dummy In devlink.sh line 459: ip -n testns2 link set $DUMMYDEV up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 link set "$DUMMYDEV" up In devlink.sh line 461: ip -n testns2 a a 192.0.1.1/24 dev $DUMMYDEV ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n testns2 a a 192.0.1.1/24 dev "$DUMMYDEV" In devlink.sh line 468: devlink -N testns1 dev reload $DL_HANDLE netns testns2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns1 dev reload "$DL_HANDLE" netns testns2 In devlink.sh line 471: devlink -N testns2 resource set $DL_HANDLE path IPv4/fib size ' -1' ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns2 resource set "$DL_HANDLE" path IPv4/fib size ' -1' In devlink.sh line 474: devlink -N testns2 dev reload $DL_HANDLE netns 1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink -N testns2 dev reload "$DL_HANDLE" netns 1 In devlink.sh line 486: resource_dump_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 501: info_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 508: dev_info_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 520: empty_reporter_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 524: devlink health show $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health show "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 527: devlink health dump show $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump show "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 530: devlink health diagnose $DL_HANDLE reporter empty >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health diagnose "$DL_HANDLE" reporter empty >/dev/null In devlink.sh line 533: devlink health recover $DL_HANDLE reporter empty ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter empty In devlink.sh line 539: check_reporter_info() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 548: local show=$(devlink health show $DL_HANDLE reporter $name -j | jq -e -r ".[][][]") ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local show=$(devlink health show "$DL_HANDLE" reporter "$name" -j | jq -e -r ".[][][]") In devlink.sh line 551: local state=$(echo $show | jq -r ".state") ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local state=$(echo "$show" | jq -r ".state") In devlink.sh line 555: local error=$(echo $show | jq -r ".error") ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local error=$(echo "$show" | jq -r ".error") In devlink.sh line 559: local recover=`echo $show | jq -r ".recover"` ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local recover=$(echo "$show" | jq -r ".recover") In devlink.sh line 563: local grace_period=$(echo $show | jq -r ".grace_period") ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local grace_period=$(echo "$show" | jq -r ".grace_period") In devlink.sh line 568: local auto_recover=$(echo $show | jq -r ".auto_recover") ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local auto_recover=$(echo "$show" | jq -r ".auto_recover") In devlink.sh line 573: dummy_reporter_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 579: devlink health set $DL_HANDLE reporter dummy auto_recover false ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy auto_recover false In devlink.sh line 585: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 590: local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump=$(devlink health dump show "$DL_HANDLE" reporter dummy -j) In devlink.sh line 593: local dump_break_msg=$(echo $dump | jq -r ".break_message") ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump_break_msg=$(echo "$dump" | jq -r ".break_message") In devlink.sh line 597: devlink health dump clear $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump clear "$DL_HANDLE" reporter dummy In devlink.sh line 600: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 605: devlink health set $DL_HANDLE reporter dummy auto_recover true ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy auto_recover true In devlink.sh line 610: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 615: local diagnose=$(devlink health diagnose $DL_HANDLE reporter dummy -j -p) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local diagnose=$(devlink health diagnose "$DL_HANDLE" reporter dummy -j -p) In devlink.sh line 618: local rcvrd_break_msg=$(echo $diagnose | jq -r ".recovered_break_message") ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rcvrd_break_msg=$(echo "$diagnose" | jq -r ".recovered_break_message") In devlink.sh line 622: devlink health set $DL_HANDLE reporter dummy grace_period 10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health set "$DL_HANDLE" reporter dummy grace_period 10 In devlink.sh line 627: echo "Y"> $DEBUGFS_DIR/health/fail_recover ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "Y"> "$DEBUGFS_DIR"/health/fail_recover In devlink.sh line 630: echo "$BREAK_MSG"> $DEBUGFS_DIR/health/break_health ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$BREAK_MSG"> "$DEBUGFS_DIR"/health/break_health In devlink.sh line 635: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 638: echo "N"> $DEBUGFS_DIR/health/fail_recover ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "N"> "$DEBUGFS_DIR"/health/fail_recover In devlink.sh line 641: devlink health recover $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health recover "$DL_HANDLE" reporter dummy In devlink.sh line 646: echo 8192 > $DEBUGFS_DIR/health/binary_len ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo 8192 > "$DEBUGFS_DIR"/health/binary_len In devlink.sh line 649: local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dump=$(devlink health dump show "$DL_HANDLE" reporter dummy -j) In devlink.sh line 652: devlink health dump clear $DL_HANDLE reporter dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink health dump clear "$DL_HANDLE" reporter dummy In devlink.sh line 658: rate_leafs_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 663: '.[] | to_entries | .[] | select(.value.type == "leaf") | .key | select(contains("'$handle'"))' ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: '.[] | to_entries | .[] | select(.value.type == "leaf") | .key | select(contains("'"$handle"'"))' In devlink.sh line 666: rate_nodes_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 671: '.[] | to_entries | .[] | select(.value.type == "node") | .key | select(contains("'$handle'"))' ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: '.[] | to_entries | .[] | select(.value.type == "node") | .key | select(contains("'"$handle"'"))' In devlink.sh line 674: rate_attr_set() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 681: devlink port function rate set $handle $name $value$units ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate set "$handle" "$name" "$value""$units" In devlink.sh line 684: rate_attr_get() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 689: cmd_jq "devlink port function rate show $handle -j" '.[][].'$name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cmd_jq "devlink port function rate show $handle -j" '.[][].'"$name" In devlink.sh line 692: rate_attr_tx_rate_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 699: rate_attr_set $handle $name $rate mbit ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_set "$handle" "$name" "$rate" mbit In devlink.sh line 702: local debug_value=$(cat $debug_file) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local debug_value=$(cat "$debug_file") In devlink.sh line 707: local api_value=$(( $(rate_attr_get $handle $name) * 8 / 1000000 )) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local api_value=$(( $(rate_attr_get "$handle" "$name") * 8 / 1000000 )) In devlink.sh line 713: rate_attr_parent_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 719: rate_attr_set $handle parent $parent ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_set "$handle" parent "$parent" In devlink.sh line 722: debug_value=$(cat $debug_file) ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: debug_value=$(cat "$debug_file") In devlink.sh line 727: api_value=$(rate_attr_get $r_obj parent) ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: api_value=$(rate_attr_get "$r_obj" parent) In devlink.sh line 733: rate_attr_tc_bw_check() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 773: rate_node_add() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 777: devlink port function rate add $handle ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate add "$handle" In devlink.sh line 780: rate_node_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 784: devlink port function rate del $handle ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink port function rate del "$handle" In devlink.sh line 787: rate_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 791: echo $VF_COUNT > /sys/bus/netdevsim/devices/$DEV_NAME/sriov_numvfs ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$VF_COUNT" > /sys/bus/netdevsim/devices/"$DEV_NAME"/sriov_numvfs In devlink.sh line 792: devlink dev eswitch set $DL_HANDLE mode switchdev ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink dev eswitch set "$DL_HANDLE" mode switchdev In devlink.sh line 793: local leafs=`rate_leafs_get $DL_HANDLE` ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local leafs=$(rate_leafs_get "$DL_HANDLE") In devlink.sh line 794: local num_leafs=`echo $leafs | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_leafs=$(echo "$leafs" | wc -w) In devlink.sh line 801: rate_attr_tx_rate_check $r_obj tx_share $rate \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$r_obj" tx_share "$rate" \ In devlink.sh line 802: $DEBUGFS_DIR/ports/${r_obj##*/}/tx_share ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/tx_share In devlink.sh line 803: rate=$(($rate+10)) ^---^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In devlink.sh line 809: rate_attr_tx_rate_check $r_obj tx_max $rate \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$r_obj" tx_max "$rate" \ In devlink.sh line 810: $DEBUGFS_DIR/ports/${r_obj##*/}/tx_max ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/tx_max In devlink.sh line 811: rate=$(($rate+100)) ^---^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In devlink.sh line 826: local num_nodes=`rate_nodes_get $DL_HANDLE | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_nodes=$(rate_nodes_get "$DL_HANDLE" | wc -w) In devlink.sh line 827: [ $num_nodes == 1 ] ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$num_nodes" == 1 ] In devlink.sh line 831: rate_attr_tx_rate_check $node1 tx_share $node_tx_share \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$node1" tx_share "$node_tx_share" \ In devlink.sh line 832: $DEBUGFS_DIR/rate_nodes/${node1##*/}/tx_share ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"/tx_share In devlink.sh line 835: rate_attr_tx_rate_check $node1 tx_max $node_tx_max \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tx_rate_check "$node1" tx_max "$node_tx_max" \ In devlink.sh line 836: $DEBUGFS_DIR/rate_nodes/${node1##*/}/tx_max ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"${node1##*/}"/tx_max In devlink.sh line 840: rate_attr_tc_bw_check $node1 "$tc_bw" \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_tc_bw_check "$node1" "$tc_bw" \ In devlink.sh line 846: local num_nodes=`rate_nodes_get $DL_HANDLE | wc -w` ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local num_nodes=$(rate_nodes_get "$DL_HANDLE" | wc -w) In devlink.sh line 847: [ $num_nodes == 0 ] ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$num_nodes" == 0 ] In devlink.sh line 855: rate_attr_parent_check $r_obj $node1_name \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_parent_check "$r_obj" "$node1_name" \ In devlink.sh line 856: $DEBUGFS_DIR/ports/${r_obj##*/}/rate_parent ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/ports/"${r_obj##*/}"/rate_parent In devlink.sh line 863: rate_attr_parent_check $node2 $node1_name \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_attr_parent_check "$node2" "$node1_name" \ In devlink.sh line 864: $DEBUGFS_DIR/rate_nodes/$node2_name/rate_parent ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$DEBUGFS_DIR"/rate_nodes/"$node2_name"/rate_parent In devlink.sh line 875: port_resource_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 877: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In devlink.sh line 917: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In devlink.sh line 930: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC1091 -- Not following: ./lib.sh: openBina...