WARNING: line length of 91 exceeds 80 columns
#58: FILE: tools/testing/selftests/net/xfrm_state.sh:22:
+# Network topology x: IPsec gateway that generates ICMP response - ns_set_v4x or ns_set_v6x

WARNING: line length of 95 exceeds 80 columns
#116: FILE: tools/testing/selftests/net/xfrm_state.sh:80:
+		# shellcheck disable=SC2030 # fail is read by trap/cleanup within this subshell

WARNING: line length of 81 exceeds 80 columns
#119: FILE: tools/testing/selftests/net/xfrm_state.sh:83:
+		# Since cleanup() relies on variables modified by this sub shell,

WARNING: line length of 100 exceeds 80 columns
#124: FILE: tools/testing/selftests/net/xfrm_state.sh:88:
+			printf "\n#############################################################\n\n"

WARNING: line length of 91 exceeds 80 columns
#129: FILE: tools/testing/selftests/net/xfrm_state.sh:93:
+		# can't use eval and test names shell check will complain about unused code

WARNING: line length of 92 exceeds 80 columns
#199: FILE: tools/testing/selftests/net/xfrm_state.sh:163:
+	[ -n "${NS_A}" ] && ns_a=(ip netns exec "${NS_A}") && ns_active="${ns_active} $NS_A"

WARNING: line length of 96 exceeds 80 columns
#201: FILE: tools/testing/selftests/net/xfrm_state.sh:165:
+	[ -n "${NS_S1}" ] && ns_s1=(ip netns exec "${NS_S1}") && ns_active="${ns_active} $NS_S1"

WARNING: line length of 96 exceeds 80 columns
#202: FILE: tools/testing/selftests/net/xfrm_state.sh:166:
+	[ -n "${NS_R2}" ] && ns_r2=(ip netns exec "${NS_R2}") && ns_active="${ns_active} $NS_R2"

WARNING: line length of 96 exceeds 80 columns
#203: FILE: tools/testing/selftests/net/xfrm_state.sh:167:
+	[ -n "${NS_S2}" ] && ns_s2=(ip netns exec "${NS_S2}") && ns_active="${ns_active} $NS_S2"

WARNING: line length of 96 exceeds 80 columns
#204: FILE: tools/testing/selftests/net/xfrm_state.sh:168:
+	[ -n "${NS_R3}" ] && ns_r3=(ip netns exec "${NS_R3}") && ns_active="${ns_active} $NS_R3"

WARNING: line length of 92 exceeds 80 columns
#224: FILE: tools/testing/selftests/net/xfrm_state.sh:188:
+	run_cmd "${ns_cmd[@]}" ip link add "${ln}" type veth peer name "${rn}" netns "${ns}"

WARNING: line length of 88 exceeds 80 columns
#236: FILE: tools/testing/selftests/net/xfrm_state.sh:200:
+	run_cmd "${ns_r2[@]}" nft add rule inet filter FORWARD counter ip protocol esp \

WARNING: line length of 84 exceeds 80 columns
#238: FILE: tools/testing/selftests/net/xfrm_state.sh:202:
+	run_cmd "${ns_r2[@]}" nft add rule inet filter FORWARD counter ip protocol \

WARNING: line length of 95 exceeds 80 columns
#257: FILE: tools/testing/selftests/net/xfrm_state.sh:221:
+		'{nd-neighbor-solicit,nd-neighbor-advert,nd-router-solicit,nd-router-advert}' \

WARNING: line length of 90 exceeds 80 columns
#345: FILE: tools/testing/selftests/net/xfrm_state.sh:309:
+			# Add addresses: previous gets .1 on eth0, current gets .2 on eth1

WARNING: line length of 87 exceeds 80 columns
#346: FILE: tools/testing/selftests/net/xfrm_state.sh:310:
+			addr_add "${p}" "${prefix}${s}$((i-1))${S}1/${prefix_len}" eth0

WARNING: line length of 88 exceeds 80 columns
#347: FILE: tools/testing/selftests/net/xfrm_state.sh:311:
+			addr_add "${ns}" "${prefix}${s}$((i-1))${S}2/${prefix_len}" eth1

WARNING: line length of 83 exceeds 80 columns
#353: FILE: tools/testing/selftests/net/xfrm_state.sh:317:
+		run_cmd "${ns_cmd[@]}" sysctl -q net/ipv6/conf/default/accept_dad=0

WARNING: line length of 91 exceeds 80 columns
#369: FILE: tools/testing/selftests/net/xfrm_state.sh:333:
+				       	"${prefix}${s}${j}${S}0/${prefix_len}" via "${nhf}"

WARNING: line length of 91 exceeds 80 columns
#378: FILE: tools/testing/selftests/net/xfrm_state.sh:342:
+					"${prefix}${s}${j}${S}0/${prefix_len}" via "${nhr}"

WARNING: line length of 98 exceeds 80 columns
#394: FILE: tools/testing/selftests/net/xfrm_state.sh:358:
+	run_cmd "${ns_s1[@]}" ip xfrm policy add src "${s1_src_net}" dst "${s1_dst_net}" dir out \

WARNING: line length of 85 exceeds 80 columns
#395: FILE: tools/testing/selftests/net/xfrm_state.sh:359:
+		tmpl src "${s1_src}" dst "${s1_dst}" proto esp reqid 1 mode "${MODE}"

WARNING: line length of 98 exceeds 80 columns
#399: FILE: tools/testing/selftests/net/xfrm_state.sh:363:
+	run_cmd "${ns_s1[@]}" ip xfrm policy add src "${s1_dst_net}" dst "${s1_src_net}" dir fwd \

WARNING: line length of 95 exceeds 80 columns
#400: FILE: tools/testing/selftests/net/xfrm_state.sh:364:
+		flag icmp tmpl src "${s1_dst}" dst "${s1_src}" proto esp reqid 2 mode "${MODE}"

WARNING: line length of 97 exceeds 80 columns
#402: FILE: tools/testing/selftests/net/xfrm_state.sh:366:
+	run_cmd "${ns_s1[@]}" ip xfrm state add src "${s1_src}" dst "${s1_dst}" proto esp spi 1 \

WARNING: line length of 97 exceeds 80 columns
#407: FILE: tools/testing/selftests/net/xfrm_state.sh:371:
+	run_cmd "${ns_s1[@]}" ip xfrm state add src "${s1_dst}" dst "${s1_src}" proto esp spi 2 \

WARNING: line length of 91 exceeds 80 columns
#408: FILE: tools/testing/selftests/net/xfrm_state.sh:372:
+		reqid 2 flag icmp replay-window 8 mode "${MODE}" aead 'rfc4106(gcm(aes))' \

WARNING: line length of 98 exceeds 80 columns
#412: FILE: tools/testing/selftests/net/xfrm_state.sh:376:
+	run_cmd "${ns_s2[@]}" ip xfrm policy add src "${s1_dst_net}" dst "${s1_src_net}" dir out \

WARNING: line length of 95 exceeds 80 columns
#413: FILE: tools/testing/selftests/net/xfrm_state.sh:377:
+		flag icmp tmpl src "${s1_dst}" dst "${s1_src}" proto esp reqid 2 mode "${MODE}"

WARNING: line length of 98 exceeds 80 columns
#415: FILE: tools/testing/selftests/net/xfrm_state.sh:379:
+	run_cmd "${ns_s2[@]}" ip xfrm policy add src "${s1_src_net}" dst "${s1_dst_net}" dir fwd \

WARNING: line length of 85 exceeds 80 columns
#416: FILE: tools/testing/selftests/net/xfrm_state.sh:380:
+		tmpl src "${s1_src}" dst "${s1_dst}" proto esp reqid 1 mode "${MODE}"

WARNING: line length of 97 exceeds 80 columns
#418: FILE: tools/testing/selftests/net/xfrm_state.sh:382:
+	run_cmd "${ns_s2[@]}" ip xfrm state add src "${s1_dst}" dst "${s1_src}" proto esp spi 2 \

WARNING: line length of 97 exceeds 80 columns
#423: FILE: tools/testing/selftests/net/xfrm_state.sh:387:
+	run_cmd "${ns_s2[@]}" ip xfrm state add src "${s1_src}" dst "${s1_dst}" proto esp spi 1 \

WARNING: line length of 91 exceeds 80 columns
#424: FILE: tools/testing/selftests/net/xfrm_state.sh:388:
+		reqid 1 flag icmp replay-window 8 mode "${MODE}" aead 'rfc4106(gcm(aes))' \

WARNING: line length of 83 exceeds 80 columns
#434: FILE: tools/testing/selftests/net/xfrm_state.sh:398:
+	[ "$(id -u)" -ne 0 ] && echo "  need to run as root" && return "$ksft_skip"

WARNING: line length of 86 exceeds 80 columns
#475: FILE: tools/testing/selftests/net/xfrm_state.sh:439:
+	[[ "$PAUSE" = "always" || ( "$PAUSE" = "fail" && "$fail" = "yes" ) ]] && pause

WARNING: line length of 84 exceeds 80 columns
#482: FILE: tools/testing/selftests/net/xfrm_state.sh:446:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return "$ksft_skip"

WARNING: line length of 83 exceeds 80 columns
#486: FILE: tools/testing/selftests/net/xfrm_state.sh:450:
+	echo -e "$out" | grep -q -E 'From fc00:5::2 icmp_seq.* Destination' || rc=1

WARNING: line length of 85 exceeds 80 columns
#491: FILE: tools/testing/selftests/net/xfrm_state.sh:455:
+	setup ns_set_v6x namespaces network xfrm icmpv6_filter || return "$ksft_skip"

WARNING: line length of 83 exceeds 80 columns
#495: FILE: tools/testing/selftests/net/xfrm_state.sh:459:
+	echo -e "$out" | grep -q -E 'From fc00:4::2 icmp_seq.* Destination' || rc=1

WARNING: line length of 82 exceeds 80 columns
#500: FILE: tools/testing/selftests/net/xfrm_state.sh:464:
+	setup ns_set_v4 namespaces network icmp_filter xfrm || return "$ksft_skip"

WARNING: line length of 82 exceeds 80 columns
#504: FILE: tools/testing/selftests/net/xfrm_state.sh:468:
+	echo -e "$out" | grep -q -E 'From 10.1.5.2 icmp_seq.* Destination' || rc=1

WARNING: line length of 83 exceeds 80 columns
#509: FILE: tools/testing/selftests/net/xfrm_state.sh:473:
+	setup ns_set_v4x namespaces network icmp_filter xfrm || return "$ksft_skip"

WARNING: line length of 82 exceeds 80 columns
#513: FILE: tools/testing/selftests/net/xfrm_state.sh:477:
+	echo -e "$out" | grep -q -E 'From 10.1.4.2 icmp_seq.* Destination' || rc=1

WARNING: line length of 82 exceeds 80 columns
#518: FILE: tools/testing/selftests/net/xfrm_state.sh:482:
+	setup ns_set_v4 namespaces network icmp_filter xfrm || return "$ksft_skip"

WARNING: line length of 89 exceeds 80 columns
#520: FILE: tools/testing/selftests/net/xfrm_state.sh:484:
+	run_cmd "${ns_r2[@]}" ip route replace 10.1.3.0/24 dev eth1 src 10.1.3.2 mtu 1300

WARNING: line length of 89 exceeds 80 columns
#521: FILE: tools/testing/selftests/net/xfrm_state.sh:485:
+	run_cmd "${ns_r2[@]}" ip route replace 10.1.4.0/24 dev eth0 src 10.1.4.1 mtu 1300

WARNING: line length of 82 exceeds 80 columns
#522: FILE: tools/testing/selftests/net/xfrm_state.sh:486:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 94 exceeds 80 columns
#525: FILE: tools/testing/selftests/net/xfrm_state.sh:489:
+	echo -e "$out" | grep -q -E "From 10.1.2.2 icmp_seq=.* Frag needed and DF set" || rc=1

WARNING: line length of 84 exceeds 80 columns
#530: FILE: tools/testing/selftests/net/xfrm_state.sh:494:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return "$ksft_skip"

WARNING: line length of 82 exceeds 80 columns
#536: FILE: tools/testing/selftests/net/xfrm_state.sh:500:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 97 exceeds 80 columns
#539: FILE: tools/testing/selftests/net/xfrm_state.sh:503:
+	echo -e "$out" | grep -q -E "From fc00:2::2 icmp_seq=.* Packet too big: mtu=1230" || rc=1

WARNING: line length of 82 exceeds 80 columns
#544: FILE: tools/testing/selftests/net/xfrm_state.sh:508:
+	setup ns_set_v4 namespaces network icmp_filter xfrm || return "$ksft_skip"

WARNING: line length of 82 exceeds 80 columns
#547: FILE: tools/testing/selftests/net/xfrm_state.sh:511:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 100 exceeds 80 columns
#550: FILE: tools/testing/selftests/net/xfrm_state.sh:514:
+	echo -e "$out" | grep -q -E "From 10.1.5.2 .* Frag needed and DF set \(mtu = 1300\)" || rc=1

WARNING: line length of 83 exceeds 80 columns
#555: FILE: tools/testing/selftests/net/xfrm_state.sh:519:
+	setup ns_set_v4x namespaces network icmp_filter xfrm || return "$ksft_skip"

WARNING: line length of 89 exceeds 80 columns
#557: FILE: tools/testing/selftests/net/xfrm_state.sh:521:
+	run_cmd "${ns_s2[@]}" ip route replace 10.1.5.0/24 dev eth0 src 10.1.5.1 mtu 1300

WARNING: line length of 82 exceeds 80 columns
#558: FILE: tools/testing/selftests/net/xfrm_state.sh:522:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 98 exceeds 80 columns
#561: FILE: tools/testing/selftests/net/xfrm_state.sh:525:
+	echo -e "$out" | grep -q -E "From 10.1.4.2.*Frag needed and DF set \(mtu = 1300\)" || rc=1

WARNING: line length of 85 exceeds 80 columns
#566: FILE: tools/testing/selftests/net/xfrm_state.sh:530:
+	setup ns_set_v6x namespaces network xfrm icmpv6_filter || return "$ksft_skip"

WARNING: line length of 90 exceeds 80 columns
#568: FILE: tools/testing/selftests/net/xfrm_state.sh:532:
+	run_cmd "${ns_s2[@]}" ip -6 route replace fc00:5::/64 dev eth0 metric 256 mtu 1300

WARNING: line length of 82 exceeds 80 columns
#569: FILE: tools/testing/selftests/net/xfrm_state.sh:533:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 86 exceeds 80 columns
#572: FILE: tools/testing/selftests/net/xfrm_state.sh:536:
+	echo -e "$out" | grep -q -E "From fc00:4::2.*Packet too big: mtu=1300" || rc=1

WARNING: line length of 84 exceeds 80 columns
#577: FILE: tools/testing/selftests/net/xfrm_state.sh:541:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return "$ksft_skip"

WARNING: line length of 90 exceeds 80 columns
#579: FILE: tools/testing/selftests/net/xfrm_state.sh:543:
+	run_cmd "${ns_r3[@]}" ip -6 route replace fc00:6::/64 dev eth1 metric 256 mtu 1300

WARNING: line length of 82 exceeds 80 columns
#580: FILE: tools/testing/selftests/net/xfrm_state.sh:544:
+	# shellcheck disable=SC1010 # -M do: do = dont-fragment, not shell keyword

WARNING: line length of 97 exceeds 80 columns
#583: FILE: tools/testing/selftests/net/xfrm_state.sh:547:
+	echo -e "$out" | grep -q -E "From fc00:5::2 icmp_seq=.* Packet too big: mtu=1300" || rc=1

WARNING: line length of 88 exceeds 80 columns
#596: FILE: tools/testing/selftests/net/xfrm_state.sh:560:
+	echo -e "\t-v Verbose output. Show commands; -vv Show output and nft rules also"

total: 0 errors, 68 warnings, 0 checks, 620 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 0649f5782bb5 ("selftests: net: add ICMP error source address test over xfrm tunnel") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 68 warnings, 0 checks, 620 lines checked