WARNING: 'mesage' may be misspelled - perhaps 'message'? #13: - Fix a typo in the commit mesage. ^^^^^^ WARNING: line length of 90 exceeds 80 columns #63: FILE: include/net/xfrm.h:458: + int (*input_encap)(struct sk_buff *skb, struct xfrm_state *x); WARNING: line length of 95 exceeds 80 columns #67: FILE: include/net/xfrm.h:462: + int (*output_tcp_encap)(struct xfrm_state *x, struct sk_buff *skb); WARNING: please, no space before tabs #1185: FILE: net/ipv4/esp4.c:198: +^I.proto^I ^I^I= IPPROTO_ESP,$ WARNING: line length of 84 exceeds 80 columns #2594: FILE: net/xfrm/xfrm_esp.c:203: + XFRM_INC_STATS(xs_net(x), LINUX_MIB_XFRMOUTSTATEPROTOERROR); WARNING: line length of 94 exceeds 80 columns #2687: FILE: net/xfrm/xfrm_esp.c:296: + /* For ESP with UDP encapsulation, if xo is not null, the skb is in the crypto offload WARNING: line length of 96 exceeds 80 columns #2688: FILE: net/xfrm/xfrm_esp.c:297: + * data path, which means that esp_output_udp_encap is called outside of the XFRM stack. WARNING: line length of 98 exceeds 80 columns #2689: FILE: net/xfrm/xfrm_esp.c:298: + * In this case, the mac header doesn't point to the IPv4 protocol field, so don't set it. CHECK: Please don't use multiple blank lines #2697: FILE: net/xfrm/xfrm_esp.c:306: + + CHECK: Alignment should match open parenthesis #2701: FILE: net/xfrm/xfrm_esp.c:310: +static struct ip_esp_hdr *esp_output_tcp_encap(struct xfrm_state *x, + struct sk_buff *skb, CHECK: Alignment should match open parenthesis #2727: FILE: net/xfrm/xfrm_esp.c:336: +static struct ip_esp_hdr *esp_output_tcp_encap(struct xfrm_state *x, + struct sk_buff *skb, WARNING: line length of 84 exceeds 80 columns #2768: FILE: net/xfrm/xfrm_esp.c:377: +int esp_output_head(struct xfrm_state *x, struct sk_buff *skb, struct esp_info *esp) CHECK: Logical continuations should be on the previous line #2797: FILE: net/xfrm/xfrm_esp.c:406: + } else if ((skb_shinfo(skb)->nr_frags < MAX_SKB_FRAGS) + && !skb_has_frag_list(skb)) { WARNING: line length of 92 exceeds 80 columns #2808: FILE: net/xfrm/xfrm_esp.c:417: + if (unlikely(!skb_page_frag_refill(allocsize, pfrag, GFP_ATOMIC))) { WARNING: line length of 90 exceeds 80 columns #2818: FILE: net/xfrm/xfrm_esp.c:427: + esp_output_fill_trailer(tail, esp->tfclen, esp->plen, esp->proto); WARNING: line length of 83 exceeds 80 columns #2847: FILE: net/xfrm/xfrm_esp.c:456: + esp->esph = (struct ip_esp_hdr *)(skb_transport_header(skb) + esph_offset); WARNING: line length of 84 exceeds 80 columns #2858: FILE: net/xfrm/xfrm_esp.c:467: +int esp_output_tail(struct xfrm_state *x, struct sk_buff *skb, struct esp_info *esp) ERROR: code indent should use tabs where possible #2905: FILE: net/xfrm/xfrm_esp.c:514: +^I^I (unsigned char *)esph - skb->data,$ CHECK: Alignment should match open parenthesis #2905: FILE: net/xfrm/xfrm_esp.c:514: + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, ERROR: code indent should use tabs where possible #2906: FILE: net/xfrm/xfrm_esp.c:515: +^I^I assoclen + ivlen + esp->clen + alen);$ WARNING: line length of 84 exceeds 80 columns #2917: FILE: net/xfrm/xfrm_esp.c:526: + if (unlikely(!skb_page_frag_refill(allocsize, pfrag, GFP_ATOMIC))) { WARNING: line length of 81 exceeds 80 columns #2927: FILE: net/xfrm/xfrm_esp.c:536: + __skb_fill_page_desc(skb, 0, page, pfrag->offset, skb->data_len); ERROR: code indent should use tabs where possible #2933: FILE: net/xfrm/xfrm_esp.c:542: +^I^I^I (unsigned char *)esph - skb->data,$ CHECK: Alignment should match open parenthesis #2933: FILE: net/xfrm/xfrm_esp.c:542: + err = skb_to_sgvec(skb, dsg, + (unsigned char *)esph - skb->data, ERROR: code indent should use tabs where possible #2934: FILE: net/xfrm/xfrm_esp.c:543: +^I^I^I assoclen + ivlen + esp->clen + alen);$ WARNING: line length of 81 exceeds 80 columns #2948: FILE: net/xfrm/xfrm_esp.c:557: + memcpy(iv + ivlen - min(ivlen, 8), (u8 *)&esp->seqno + 8 - min(ivlen, 8), WARNING: line length of 81 exceeds 80 columns #3004: FILE: net/xfrm/xfrm_esp.c:613: + padto = min(x->tfcpad, xfrm_state_mtu(x, dst->child_mtu_cached)); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #3047: FILE: net/xfrm/xfrm_esp.c:656: + BUG(); CHECK: Please don't use multiple blank lines #3073: FILE: net/xfrm/xfrm_esp.c:682: + + CHECK: Please don't use multiple blank lines #3132: FILE: net/xfrm/xfrm_esp.c:741: + + WARNING: line length of 91 exceeds 80 columns #3306: FILE: net/xfrm/xfrm_esp.c:915: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); WARNING: line length of 99 exceeds 80 columns #3349: FILE: net/xfrm/xfrm_esp.c:958: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #3376: FILE: net/xfrm/xfrm_esp.c:985: + BUG_ON(!aalg_desc); WARNING: line length of 107 exceeds 80 columns #3381: FILE: net/xfrm/xfrm_esp.c:990: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); CHECK: Lines should not end with a '(' #3385: FILE: net/xfrm/xfrm_esp.c:994: + err = crypto_aead_setauthsize( WARNING: line length of 107 exceeds 80 columns #3388: FILE: net/xfrm/xfrm_esp.c:997: + NL_SET_ERR_MSG(extack, "Kernel was unable to initialize cryptographic operations"); total: 4 errors, 23 warnings, 9 checks, 3324 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 40ff73c1eb37 ("esp: Consolidate esp4 and esp6.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.