WARNING: line length of 86 exceeds 80 columns #126: FILE: tools/testing/selftests/net/forwarding/ipmr.c:74: +static int nl_sendmsg_mfc(struct __test_metadata *_metadata, FIXTURE_DATA(ipmr) *self, CHECK: spaces preferred around that '*' (ctx:WxV) #126: FILE: tools/testing/selftests/net/forwarding/ipmr.c:74: +static int nl_sendmsg_mfc(struct __test_metadata *_metadata, FIXTURE_DATA(ipmr) *self, ^ WARNING: line length of 86 exceeds 80 columns #135: FILE: tools/testing/selftests/net/forwarding/ipmr.c:83: + /* ipmr does not care about NLM_F_CREATE and NLM_F_EXCL ... */ WARNING: line length of 94 exceeds 80 columns #155: FILE: tools/testing/selftests/net/forwarding/ipmr.c:103: + rta = nl_add_rtattr(nlmsg, rta, RTA_TABLE, &mfc_attr->table, sizeof(mfc_attr->table)); WARNING: line length of 94 exceeds 80 columns #156: FILE: tools/testing/selftests/net/forwarding/ipmr.c:104: + rta = nl_add_rtattr(nlmsg, rta, RTA_SRC, &mfc_attr->origin, sizeof(mfc_attr->origin)); WARNING: line length of 92 exceeds 80 columns #157: FILE: tools/testing/selftests/net/forwarding/ipmr.c:105: + rta = nl_add_rtattr(nlmsg, rta, RTA_DST, &mfc_attr->group, sizeof(mfc_attr->group)); WARNING: line length of 104 exceeds 80 columns #159: FILE: tools/testing/selftests/net/forwarding/ipmr.c:107: + rta = nl_add_rtattr(nlmsg, rta, RTA_IIF, &mfc_attr->ifindex, sizeof(mfc_attr->ifindex)); WARNING: line length of 84 exceeds 80 columns #209: FILE: tools/testing/selftests/net/forwarding/ipmr.c:157: + int err, val = 0; /* any value is ok, but size must be int for MRT_INIT. */ WARNING: line length of 90 exceeds 80 columns #295: FILE: tools/testing/selftests/net/forwarding/ipmr.c:243: + /* MRT_ADD_MFC / MRT_ADD_MFC_PROXY does not need vif to exist (unlike netlink). */ WARNING: line length of 81 exceeds 80 columns #302: FILE: tools/testing/selftests/net/forwarding/ipmr.c:250: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 85 exceeds 80 columns #316: FILE: tools/testing/selftests/net/forwarding/ipmr.c:264: + variant->level, variant->opts[MRT_ADD_MFC_PROXY - MRT_BASE], WARNING: line length of 81 exceeds 80 columns #320: FILE: tools/testing/selftests/net/forwarding/ipmr.c:268: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 85 exceeds 80 columns #324: FILE: tools/testing/selftests/net/forwarding/ipmr.c:272: + variant->level, variant->opts[MRT_DEL_MFC_PROXY - MRT_BASE], WARNING: line length of 81 exceeds 80 columns #352: FILE: tools/testing/selftests/net/forwarding/ipmr.c:300: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 81 exceeds 80 columns #383: FILE: tools/testing/selftests/net/forwarding/ipmr.c:331: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 87 exceeds 80 columns #436: FILE: tools/testing/selftests/net/forwarding/ipmr.c:384: + variant->level, variant->opts[MRT_ADD_VIF - MRT_BASE], WARNING: line length of 81 exceeds 80 columns #445: FILE: tools/testing/selftests/net/forwarding/ipmr.c:393: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 81 exceeds 80 columns #453: FILE: tools/testing/selftests/net/forwarding/ipmr.c:401: + err = system("cat /proc/net/ip_mr_cache | grep -q '00000000 00000000' "); WARNING: line length of 88 exceeds 80 columns #462: FILE: tools/testing/selftests/net/forwarding/ipmr.c:410: + /* It can be removed by setsockopt(), but let cleanup_net() remove this time. */ total: 0 errors, 18 warnings, 1 checks, 465 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1a09168aa263 ("selftest: net: Add basic functionality tests for ipmr.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 18 warnings, 1 checks, 465 lines checked