CHECK: Macro argument 'field' may be better as '(field)' to avoid precedence issues #755: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_dev.h:37: +#define HINIC3_NIC_STATS_INC(nic_dev, field) \ +do { \ + u64_stats_update_begin(&(nic_dev)->stats.syncp); \ + (nic_dev)->stats.field++; \ + u64_stats_update_end(&(nic_dev)->stats.syncp); \ +} while (0) CHECK: Macro argument 'field' may be better as '(field)' to avoid precedence issues #793: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:36: +#define RXQ_STATS_INC(rxq, field) \ +do { \ + u64_stats_update_begin(&(rxq)->rxq_stats.syncp); \ + (rxq)->rxq_stats.field++; \ + u64_stats_update_end(&(rxq)->rxq_stats.syncp); \ +} while (0) CHECK: Macro argument 'field' may be better as '(field)' to avoid precedence issues #955: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_tx.c:19: +#define TXQ_STATS_INC(txq, field) \ +do { \ + u64_stats_update_begin(&(txq)->txq_stats.syncp); \ + (txq)->txq_stats.field++; \ + u64_stats_update_end(&(txq)->txq_stats.syncp); \ +} while (0) total: 0 errors, 0 warnings, 3 checks, 1016 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e0b0dcfada49 ("hinic3: Add ethtool statistic ops") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 3 checks, 1016 lines checked