pylint 3.3.9 astroid 3.3.8 Python 3.14.2 (main, Dec 5 2025, 00:00:00) [GCC 15.2.1 20251111 (Red Hat 15.2.1-4)] Redirect to /tmp/tmp.mo4CiK6w8w and /tmp/tmp.xz7s8E4RSe Tree base: b011b033eef1 ("psp: Support for transmit on logical device when the underlying transport device supports PSP.") Now at: 99b4c66a90c7 ("selftests: drv-net: psp: add test for VLAN sub-interface") ====== Checking before the patch ====== ************* Module psp tools/testing/selftests/drivers/net/psp.py:521:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/psp.py:523:4: W0212: Access to a protected member _ns of a client class (protected-access) tools/testing/selftests/drivers/net/psp.py:525:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) ------------------------------------------------------------------ Your code has been rated at 9.92/10 (previous run: 9.79/10, +0.12) ====== Checking the tree with the patch ====== ************* Module psp tools/testing/selftests/drivers/net/psp.py:604:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/psp.py:522:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/psp.py:524:4: W0212: Access to a protected member _ns of a client class (protected-access) tools/testing/selftests/drivers/net/psp.py:526:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/psp.py:574:0: R0914: Too many local variables (17/15) (too-many-locals) tools/testing/selftests/drivers/net/psp.py:617:4: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/drivers/net/psp.py:617:4: R0902: Too many instance attributes (12/7) (too-many-instance-attributes) tools/testing/selftests/drivers/net/psp.py:621:4: W0201: Attribute 'ifname' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:622:4: W0201: Attribute 'ifindex' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:623:4: W0201: Attribute 'remote_ifname' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:624:4: W0201: Attribute 'addr_v' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:625:4: W0201: Attribute 'remote_addr_v' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:626:4: W0201: Attribute 'addr' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:627:4: W0201: Attribute 'remote_addr' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:628:4: W0201: Attribute 'pspnl' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:629:4: W0201: Attribute 'psp_dev_id' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:630:4: W0201: Attribute 'remote' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:631:4: W0201: Attribute 'comm_port' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:632:4: W0201: Attribute 'comm_sock' defined outside __init__ (attribute-defined-outside-init) tools/testing/selftests/drivers/net/psp.py:617:4: R0903: Too few public methods (0/2) (too-few-public-methods) ------------------------------------------------------------------ Your code has been rated at 9.50/10 (previous run: 9.92/10, -0.41)