ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.HKMiiag2D1 and /tmp/tmp.aO77Z0wvQY
Tree base:
d4f687fbbce4 ("ovpn: tcp - fix packet extraction from stream")
Now at:
e98e66d144fc ("selftests: netfilter: nft_queue.sh: increase udp_gro_ct subtest timeout")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/nft_queue.sh - c76daafa49ffa955e26233c714a88896b91ad24bfa1e78e367fa7eb23d6df1c7


In nft_queue.sh line 15:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 17:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_queue.sh line 18:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_queue.sh line 19:
	ip netns pids "$nsrouter" | xargs kill 2>/dev/null
                       ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_queue.sh line 53:
ip link add veth2 netns "$nsrouter" type veth peer name eth0 netns "$ns3"
                                                                    ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In nft_queue.sh line 211:
nf_queue_wait()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 254:
		if [ x"$last" != x"$expected packets total" ]; then
                     ^------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.

Did you mean:
		if [ "$last" != "$expected packets total" ]; then


In nft_queue.sh line 264:
listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 280:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 295:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 404:
sctp_listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 430:
	local tnow=$(date +%s)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 460:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 495:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 511:
udp_listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 516:
output_files_written()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 669:
	read p preinject b breinject <<EOF
             ^-- SC2034 (warning): p appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- p appears unused. Verify use (or ...
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/nft_queue.sh - c76daafa49ffa955e26233c714a88896b91ad24bfa1e78e367fa7eb23d6df1c7


In nft_queue.sh line 15:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 17:
	ip netns pids "$ns1" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_queue.sh line 18:
	ip netns pids "$ns2" | xargs kill 2>/dev/null
                       ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_queue.sh line 19:
	ip netns pids "$nsrouter" | xargs kill 2>/dev/null
                       ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_queue.sh line 53:
ip link add veth2 netns "$nsrouter" type veth peer name eth0 netns "$ns3"
                                                                    ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In nft_queue.sh line 211:
nf_queue_wait()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 254:
		if [ x"$last" != x"$expected packets total" ]; then
                     ^------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.

Did you mean:
		if [ "$last" != "$expected packets total" ]; then


In nft_queue.sh line 264:
listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 280:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 295:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 404:
sctp_listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 430:
	local tnow=$(date +%s)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 460:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 495:
	local tthen=$(date +%s)
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In nft_queue.sh line 511:
udp_listener_ready()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 516:
output_files_written()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In nft_queue.sh line 670:
	read p preinject b breinject <<EOF
             ^-- SC2034 (warning): p appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- p appears unused. Verify use (or ...
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...