ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.tvrYMpa6qo and /tmp/tmp.wav5LlO7DW
Tree base:
123590783b38 ("netdevsim: Implement basic ptp support")
Now at:
6869848bb5dc ("selftests:net: Implement ptp4l sync test using netdevsim")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/ptp.sh - 251d5b89315d27ebef79746409ccef9756b67a0bef88a0b9dd8936a492ee79bf


In ptp.sh line 21:
	ip netns exec nssv ip addr add '192.168.1.1/24' dev $NSIM_DEV_1_NAME
                                                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec nssv ip addr add '192.168.1.1/24' dev "$NSIM_DEV_1_NAME"


In ptp.sh line 22:
	ip netns exec nscl ip addr add '192.168.1.2/24' dev $NSIM_DEV_2_NAME
                                                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec nscl ip addr add '192.168.1.2/24' dev "$NSIM_DEV_2_NAME"


In ptp.sh line 27:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In ptp.sh line 30:
		kill $PTP4L_LEADER_PID $PTP4L_FOLLOWER_PID 2>/dev/null
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		kill "$PTP4L_LEADER_PID" "$PTP4L_FOLLOWER_PID" 2>/dev/null


In ptp.sh line 31:
		wait $PTP4L_LEADER_PID $PTP4L_FOLLOWER_PID 2>/dev/null
                     ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		wait "$PTP4L_LEADER_PID" "$PTP4L_FOLLOWER_PID" 2>/dev/null


In ptp.sh line 61:
NSIM_DEV_1_IFIDX=$(ip netns exec nssv cat /sys/class/net/$NSIM_DEV_1_NAME/ifindex)
                                                         ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
NSIM_DEV_1_IFIDX=$(ip netns exec nssv cat /sys/class/net/"$NSIM_DEV_1_NAME"/ifindex)


In ptp.sh line 65:
NSIM_DEV_2_IFIDX=$(ip netns exec nscl cat /sys/class/net/$NSIM_DEV_2_NAME/ifindex)
                                                         ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
NSIM_DEV_2_IFIDX=$(ip netns exec nscl cat /sys/class/net/"$NSIM_DEV_2_NAME"/ifindex)

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...