====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ptp.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.tvrYMpa6qo 2026-02-23 07:57:02.856591161 -0500 +++ /tmp/tmp.wav5LlO7DW 2026-02-23 07:57:03.173588316 -0500 @@ -0,0 +1,58 @@ + +In ptp.sh line 21: + ip netns exec nssv ip addr add '192.168.1.1/24' dev $NSIM_DEV_1_NAME + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nssv ip addr add '192.168.1.1/24' dev "$NSIM_DEV_1_NAME" + + +In ptp.sh line 22: + ip netns exec nscl ip addr add '192.168.1.2/24' dev $NSIM_DEV_2_NAME + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nscl ip addr add '192.168.1.2/24' dev "$NSIM_DEV_2_NAME" + + +In ptp.sh line 27: +cleanup() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In ptp.sh line 30: + kill $PTP4L_LEADER_PID $PTP4L_FOLLOWER_PID 2>/dev/null + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + kill "$PTP4L_LEADER_PID" "$PTP4L_FOLLOWER_PID" 2>/dev/null + + +In ptp.sh line 31: + wait $PTP4L_LEADER_PID $PTP4L_FOLLOWER_PID 2>/dev/null + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$PTP4L_LEADER_PID" "$PTP4L_FOLLOWER_PID" 2>/dev/null + + +In ptp.sh line 61: +NSIM_DEV_1_IFIDX=$(ip netns exec nssv cat /sys/class/net/$NSIM_DEV_1_NAME/ifindex) + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +NSIM_DEV_1_IFIDX=$(ip netns exec nssv cat /sys/class/net/"$NSIM_DEV_1_NAME"/ifindex) + + +In ptp.sh line 65: +NSIM_DEV_2_IFIDX=$(ip netns exec nscl cat /sys/class/net/$NSIM_DEV_2_NAME/ifindex) + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +NSIM_DEV_2_IFIDX=$(ip netns exec nscl cat /sys/class/net/"$NSIM_DEV_2_NAME"/ifindex) + +For more information: + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...