ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.b9xUwhegpZ and /tmp/tmp.Cdelyc8bsd Tree base: ac352adb144a ("bridge: Check relevant per-VLAN options in VLAN range grouping") Now at: 661da6fe26bc ("selftests: net: Add bridge VLAN range grouping tests") ====== Checking before the patch ====== ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/bridge_vlan_dump.sh - 07c930a61825f0a7ba5cee8c4f407cf3267658518f5c9cafa7618b1df6cbd520 In bridge_vlan_dump.sh line 22: ip -n $NS link add name br0 type bridge vlan_filtering 1 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$NS" link add name br0 type bridge vlan_filtering 1 \ In bridge_vlan_dump.sh line 24: ip -n $NS link set dev br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$NS" link set dev br0 up In bridge_vlan_dump.sh line 26: ip -n $NS link add name dummy0 type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$NS" link add name dummy0 type dummy In bridge_vlan_dump.sh line 27: ip -n $NS link set dev dummy0 master br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$NS" link set dev dummy0 master br0 In bridge_vlan_dump.sh line 28: ip -n $NS link set dev dummy0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$NS" link set dev dummy0 up In bridge_vlan_dump.sh line 31: vlan_range_neigh_suppress() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_vlan_dump.sh line 36: bridge -n $NS vlan add vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 10 dev dummy0 In bridge_vlan_dump.sh line 37: defer bridge -n $NS vlan del vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 10 dev dummy0 In bridge_vlan_dump.sh line 39: bridge -n $NS vlan add vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 11 dev dummy0 In bridge_vlan_dump.sh line 40: defer bridge -n $NS vlan del vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 11 dev dummy0 In bridge_vlan_dump.sh line 43: bridge -n $NS vlan set vid 10 dev dummy0 neigh_suppress on ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 10 dev dummy0 neigh_suppress on In bridge_vlan_dump.sh line 46: bridge -n $NS vlan set vid 11 dev dummy0 neigh_suppress off ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 11 dev dummy0 neigh_suppress off In bridge_vlan_dump.sh line 50: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 53: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" In bridge_vlan_dump.sh line 56: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" In bridge_vlan_dump.sh line 60: bridge -n $NS vlan set vid 11 dev dummy0 neigh_suppress on ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 11 dev dummy0 neigh_suppress on In bridge_vlan_dump.sh line 63: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 69: vlan_range_mcast_max_groups() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_vlan_dump.sh line 74: bridge -n $NS vlan add vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 10 dev dummy0 In bridge_vlan_dump.sh line 75: defer bridge -n $NS vlan del vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 10 dev dummy0 In bridge_vlan_dump.sh line 77: bridge -n $NS vlan add vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 11 dev dummy0 In bridge_vlan_dump.sh line 78: defer bridge -n $NS vlan del vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 11 dev dummy0 In bridge_vlan_dump.sh line 81: bridge -n $NS vlan set vid 10 dev dummy0 mcast_max_groups 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 10 dev dummy0 mcast_max_groups 100 In bridge_vlan_dump.sh line 84: bridge -n $NS vlan set vid 11 dev dummy0 mcast_max_groups 200 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 11 dev dummy0 mcast_max_groups 200 In bridge_vlan_dump.sh line 88: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 91: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" In bridge_vlan_dump.sh line 94: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" In bridge_vlan_dump.sh line 98: bridge -n $NS vlan set vid 11 dev dummy0 mcast_max_groups 100 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan set vid 11 dev dummy0 mcast_max_groups 100 In bridge_vlan_dump.sh line 101: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 107: vlan_range_mcast_n_groups() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_vlan_dump.sh line 112: bridge -n $NS vlan add vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 10 dev dummy0 In bridge_vlan_dump.sh line 113: defer bridge -n $NS vlan del vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 10 dev dummy0 In bridge_vlan_dump.sh line 115: bridge -n $NS vlan add vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 11 dev dummy0 In bridge_vlan_dump.sh line 116: defer bridge -n $NS vlan del vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 11 dev dummy0 In bridge_vlan_dump.sh line 119: bridge -n $NS mdb add dev br0 port dummy0 grp 239.1.1.1 vid 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" mdb add dev br0 port dummy0 grp 239.1.1.1 vid 10 In bridge_vlan_dump.sh line 121: defer bridge -n $NS mdb del dev br0 port dummy0 grp 239.1.1.1 vid 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" mdb del dev br0 port dummy0 grp 239.1.1.1 vid 10 In bridge_vlan_dump.sh line 123: bridge -n $NS mdb add dev br0 port dummy0 grp 239.1.1.2 vid 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" mdb add dev br0 port dummy0 grp 239.1.1.2 vid 10 In bridge_vlan_dump.sh line 125: defer bridge -n $NS mdb del dev br0 port dummy0 grp 239.1.1.2 vid 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" mdb del dev br0 port dummy0 grp 239.1.1.2 vid 10 In bridge_vlan_dump.sh line 127: bridge -n $NS mdb add dev br0 port dummy0 grp 239.1.1.1 vid 11 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" mdb add dev br0 port dummy0 grp 239.1.1.1 vid 11 In bridge_vlan_dump.sh line 129: defer bridge -n $NS mdb del dev br0 port dummy0 grp 239.1.1.1 vid 11 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" mdb del dev br0 port dummy0 grp 239.1.1.1 vid 11 In bridge_vlan_dump.sh line 132: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 135: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" In bridge_vlan_dump.sh line 138: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" In bridge_vlan_dump.sh line 142: bridge -n $NS mdb add dev br0 port dummy0 grp 239.1.1.2 vid 11 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" mdb add dev br0 port dummy0 grp 239.1.1.2 vid 11 In bridge_vlan_dump.sh line 144: defer bridge -n $NS mdb del dev br0 port dummy0 grp 239.1.1.2 vid 11 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" mdb del dev br0 port dummy0 grp 239.1.1.2 vid 11 In bridge_vlan_dump.sh line 146: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 152: vlan_range_mcast_enabled() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In bridge_vlan_dump.sh line 157: bridge -n $NS vlan add vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 10 dev br0 self In bridge_vlan_dump.sh line 158: defer bridge -n $NS vlan del vid 10 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 10 dev br0 self In bridge_vlan_dump.sh line 160: bridge -n $NS vlan add vid 11 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 11 dev br0 self In bridge_vlan_dump.sh line 161: defer bridge -n $NS vlan del vid 11 dev br0 self ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 11 dev br0 self In bridge_vlan_dump.sh line 163: bridge -n $NS vlan add vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 10 dev dummy0 In bridge_vlan_dump.sh line 164: defer bridge -n $NS vlan del vid 10 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 10 dev dummy0 In bridge_vlan_dump.sh line 166: bridge -n $NS vlan add vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan add vid 11 dev dummy0 In bridge_vlan_dump.sh line 167: defer bridge -n $NS vlan del vid 11 dev dummy0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer bridge -n "$NS" vlan del vid 11 dev dummy0 In bridge_vlan_dump.sh line 171: bridge -n $NS vlan global set dev br0 vid 10 mcast_snooping 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan global set dev br0 vid 10 mcast_snooping 1 In bridge_vlan_dump.sh line 172: bridge -n $NS vlan global set dev br0 vid 11 mcast_snooping 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan global set dev br0 vid 11 mcast_snooping 0 In bridge_vlan_dump.sh line 175: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" In bridge_vlan_dump.sh line 178: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+10$|^\s+10$" In bridge_vlan_dump.sh line 181: bridge -n $NS -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -Eq "^\S+\s+11$|^\s+11$" In bridge_vlan_dump.sh line 185: bridge -n $NS vlan global set dev br0 vid 11 mcast_snooping 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" vlan global set dev br0 vid 11 mcast_snooping 1 In bridge_vlan_dump.sh line 187: bridge -n $NS -d vlan show dev dummy0 | grep -q "10-11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -n "$NS" -d vlan show dev dummy0 | grep -q "10-11" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...