========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/ip6_tunnel.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.TsvkhHjazb 2026-02-21 07:05:45.472379634 -0500 +++ /tmp/tmp.hw8Sho3G4l 2026-02-21 07:05:45.806376040 -0500 @@ -0,0 +1,181 @@ + +In ip6_tunnel.sh line 11: + ip link set transport1 netns $ns1 + ^--^ SC2154 (warning): ns1 is referenced but not assigned. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set transport1 netns "$ns1" + + +In ip6_tunnel.sh line 12: + ip -n $ns1 address add 2001:db8::1/64 dev transport1 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" address add 2001:db8::1/64 dev transport1 nodad + + +In ip6_tunnel.sh line 13: + ip -n $ns1 address add 2001:db8::3/64 dev transport1 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" address add 2001:db8::3/64 dev transport1 nodad + + +In ip6_tunnel.sh line 14: + ip -n $ns1 link set transport1 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link set transport1 up + + +In ip6_tunnel.sh line 15: + ip -n $ns1 link add link transport1 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::1 remote 2001:db8::2 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link add link transport1 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::1 remote 2001:db8::2 + + +In ip6_tunnel.sh line 16: + ip -n $ns1 address add 172.0.0.1/32 peer 172.0.0.2/32 dev tunnel4 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" address add 172.0.0.1/32 peer 172.0.0.2/32 dev tunnel4 + + +In ip6_tunnel.sh line 17: + ip -n $ns1 link set tunnel4 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link set tunnel4 up + + +In ip6_tunnel.sh line 18: + ip -n $ns1 link add link transport1 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::3 remote 2001:db8::4 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link add link transport1 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::3 remote 2001:db8::4 + + +In ip6_tunnel.sh line 19: + ip -n $ns1 address add 2001:db8:6::1/64 dev tunnel6 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" address add 2001:db8:6::1/64 dev tunnel6 + + +In ip6_tunnel.sh line 20: + ip -n $ns1 link set tunnel6 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns1" link set tunnel6 up + + +In ip6_tunnel.sh line 23: + ip link set transport2 netns $ns2 + ^--^ SC2154 (warning): ns2 is referenced but not assigned. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set transport2 netns "$ns2" + + +In ip6_tunnel.sh line 24: + ip -n $ns2 address add 2001:db8::2/64 dev transport2 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" address add 2001:db8::2/64 dev transport2 nodad + + +In ip6_tunnel.sh line 25: + ip -n $ns2 address add 2001:db8::4/64 dev transport2 nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" address add 2001:db8::4/64 dev transport2 nodad + + +In ip6_tunnel.sh line 26: + ip -n $ns2 link set transport2 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link set transport2 up + + +In ip6_tunnel.sh line 27: + ip -n $ns2 link add link transport2 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::2 remote 2001:db8::1 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link add link transport2 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::2 remote 2001:db8::1 + + +In ip6_tunnel.sh line 28: + ip -n $ns2 address add 172.0.0.2/32 peer 172.0.0.1/32 dev tunnel4 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" address add 172.0.0.2/32 peer 172.0.0.1/32 dev tunnel4 + + +In ip6_tunnel.sh line 29: + ip -n $ns2 link set tunnel4 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link set tunnel4 up + + +In ip6_tunnel.sh line 30: + ip -n $ns2 link add link transport2 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::4 remote 2001:db8::3 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link add link transport2 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::4 remote 2001:db8::3 + + +In ip6_tunnel.sh line 31: + ip -n $ns2 address add 2001:db8:6::2/64 dev tunnel6 + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" address add 2001:db8:6::2/64 dev tunnel6 + + +In ip6_tunnel.sh line 32: + ip -n $ns2 link set tunnel6 up + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "$ns2" link set tunnel6 up + + +In ip6_tunnel.sh line 43: +ip netns exec $ns1 ping -q -W1 -c1 172.0.0.2 >/dev/null + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip netns exec "$ns1" ping -q -W1 -c1 172.0.0.2 >/dev/null + + +In ip6_tunnel.sh line 44: +ip netns exec $ns1 ping -q -W1 -c1 2001:db8:6::2 >/dev/null + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +ip netns exec "$ns1" ping -q -W1 -c1 2001:db8:6::2 >/dev/null + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned. + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...