CHECK: No space is necessary after a cast
#75: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:27:
+	const char *pa = *(const char **) ppa;

CHECK: No space is necessary after a cast
#76: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:28:
+	const char *pb = *(const char **) ppb;

WARNING: line length of 84 exceeds 80 columns
#130: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:82:
+		 * We keep pointer for each function name so we can get the original

WARNING: line length of 85 exceeds 80 columns
#131: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:83:
+		 * array index and have the resulting ids array matching the original

WARNING: line length of 81 exceeds 80 columns
#134: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:86:
+		 * Doing it this way allow us to easily test the cookies support,

WARNING: line length of 82 exceeds 80 columns
#161: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:113:
+	ASSERT_EQ(skel->bss->test_result_fentry, FUNCS_CNT, "test_result_fentry");

WARNING: line length of 92 exceeds 80 columns
#196: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:148:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,

CHECK: Alignment should match open parenthesis
#197: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:149:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
+					"bpf_fentry_test*", NULL);

WARNING: line length of 89 exceeds 80 columns
#198: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:150:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))

WARNING: line length of 90 exceeds 80 columns
#201: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:153:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,

CHECK: Alignment should match open parenthesis
#202: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:154:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,
+					"bpf_fentry_test*", NULL);

WARNING: line length of 88 exceeds 80 columns
#203: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:155:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi"))

WARNING: line length of 92 exceeds 80 columns
#232: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:184:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,

CHECK: Alignment should match open parenthesis
#233: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:185:
+	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
+						NULL, &opts);

WARNING: line length of 89 exceeds 80 columns
#234: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:186:
+	if (!ASSERT_OK_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))

WARNING: line length of 90 exceeds 80 columns
#237: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:189:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,

CHECK: Alignment should match open parenthesis
#238: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:190:
+	skel->links.test_fexit = bpf_program__attach_tracing_multi(skel->progs.test_fexit,
+						NULL, &opts);

WARNING: line length of 88 exceeds 80 columns
#239: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi.c:191:
+	if (!ASSERT_OK_PTR(skel->links.test_fexit, "bpf_program__attach_tracing_multi"))

WARNING: line length of 92 exceeds 80 columns
#276: FILE: tools/testing/selftests/bpf/progs/tracing_multi_attach.c:9:
+__hidden extern int tracing_multi_arg_check(__u64 *ctx, __u64 *test_result, bool is_return);

WARNING: externs should be avoided in .c files
#310: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:11:
+extern const void bpf_fentry_test1 __ksym;

WARNING: externs should be avoided in .c files
#311: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:12:
+extern const void bpf_fentry_test2 __ksym;

WARNING: externs should be avoided in .c files
#312: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:13:
+extern const void bpf_fentry_test3 __ksym;

WARNING: externs should be avoided in .c files
#313: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:14:
+extern const void bpf_fentry_test4 __ksym;

WARNING: externs should be avoided in .c files
#314: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:15:
+extern const void bpf_fentry_test5 __ksym;

WARNING: externs should be avoided in .c files
#315: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:16:
+extern const void bpf_fentry_test6 __ksym;

WARNING: externs should be avoided in .c files
#316: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:17:
+extern const void bpf_fentry_test7 __ksym;

WARNING: externs should be avoided in .c files
#317: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:18:
+extern const void bpf_fentry_test8 __ksym;

WARNING: externs should be avoided in .c files
#318: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:19:
+extern const void bpf_fentry_test9 __ksym;

ERROR: "foo0 bar" should be "foo 0 bar"
#319: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:20:
+extern const void bpf_fentry_test10 __ksym;

WARNING: externs should be avoided in .c files
#319: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:20:
+extern const void bpf_fentry_test10 __ksym;

CHECK: No space is necessary after a cast
#323: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:24:
+	void *ip = (void *) bpf_get_func_ip(ctx);

CHECK: No space is necessary after a cast
#337: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:38:
+		a = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#341: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:42:
+		*test_result += err == 0 && a == 1;
 		                         ^

CHECK: No space is necessary after a cast
#347: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:48:
+		a = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#353: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:54:
+		*test_result += err == 0 && a == 2 && b == 3;
 		                         ^

CHECK: No space is necessary after a cast
#360: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:61:
+		a = (char) value;

CHECK: No space is necessary after a cast
#362: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:63:
+		b = (int) value;

ERROR: space prohibited after that '&&' (ctx:WxW)
#368: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:69:
+		*test_result += err == 0 && a == 4 && b == 5 && c == 6;
 		                         ^

CHECK: No space is necessary after a cast
#376: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:77:
+		a = (void *) value;

CHECK: No space is necessary after a cast
#378: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:79:
+		b = (char) value;

CHECK: No space is necessary after a cast
#380: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:81:
+		c = (int) value;

WARNING: line length of 91 exceeds 80 columns
#386: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;

CHECK: No space is necessary after a cast
#386: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;

ERROR: space prohibited after that '&&' (ctx:WxW)
#386: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:87:
+		*test_result += err == 0 && a == (void *) 7 && b == 8 && c == 9 && d == 10;
 		                         ^

CHECK: No space is necessary after a cast
#397: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:98:
+		b = (void *) value;

CHECK: No space is necessary after a cast
#399: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:100:
+		c = (short) value;

CHECK: No space is necessary after a cast
#401: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:102:
+		d = (int) value;

WARNING: line length of 105 exceeds 80 columns
#407: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;

CHECK: No space is necessary after a cast
#407: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;

ERROR: space prohibited after that '&&' (ctx:WxW)
#407: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:108:
+		*test_result += err == 0 && a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15;
 		                         ^

CHECK: No space is necessary after a cast
#419: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:120:
+		b = (void *) value;

CHECK: No space is necessary after a cast
#421: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:122:
+		c = (short) value;

CHECK: No space is necessary after a cast
#423: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:124:
+		d = (int) value;

CHECK: No space is necessary after a cast
#425: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:126:
+		e = (void *) value;

WARNING: line length of 125 exceeds 80 columns
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;

CHECK: No space is necessary after a cast
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;

ERROR: space prohibited after that '&&' (ctx:WxW)
#431: FILE: tools/testing/selftests/bpf/progs/tracing_multi_check.c:132:
+		*test_result += err == 0 && a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21;
 		                         ^

total: 7 errors, 26 warnings, 24 checks, 406 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 21a014633f30 ("selftests/bpf: Add tracing multi skel/pattern/ids attach tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.