CHECK: extern prototypes should be avoided in .h files #43: FILE: include/linux/netfilter/nf_conntrack_amanda.h:10: +extern unsigned int (__rcu *nf_nat_amanda_hook)(struct sk_buff *skb, CHECK: Alignment should match open parenthesis #44: FILE: include/linux/netfilter/nf_conntrack_amanda.h:11: +extern unsigned int (__rcu *nf_nat_amanda_hook)(struct sk_buff *skb, enum ip_conntrack_info ctinfo, CHECK: extern prototypes should be avoided in .h files #56: FILE: include/linux/netfilter/nf_conntrack_ftp.h:29: +extern unsigned int (__rcu *nf_nat_ftp_hook)(struct sk_buff *skb, CHECK: Alignment should match open parenthesis #57: FILE: include/linux/netfilter/nf_conntrack_ftp.h:30: +extern unsigned int (__rcu *nf_nat_ftp_hook)(struct sk_buff *skb, enum ip_conntrack_info ctinfo, CHECK: extern prototypes should be avoided in .h files #69: FILE: include/linux/netfilter/nf_conntrack_irc.h:11: +extern unsigned int (__rcu *nf_nat_irc_hook)(struct sk_buff *skb, CHECK: Alignment should match open parenthesis #70: FILE: include/linux/netfilter/nf_conntrack_irc.h:12: +extern unsigned int (__rcu *nf_nat_irc_hook)(struct sk_buff *skb, enum ip_conntrack_info ctinfo, CHECK: extern prototypes should be avoided in .h files #95: FILE: include/linux/netfilter/nf_conntrack_tftp.h:22: +extern unsigned int (__rcu *nf_nat_tftp_hook)(struct sk_buff *skb, CHECK: Alignment should match open parenthesis #96: FILE: include/linux/netfilter/nf_conntrack_tftp.h:23: +extern unsigned int (__rcu *nf_nat_tftp_hook)(struct sk_buff *skb, enum ip_conntrack_info ctinfo, total: 0 errors, 0 warnings, 8 checks, 126 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 929b8229cbe8 ("netfilter: annotate NAT helper hook pointers with __rcu") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 8 checks, 126 lines checked