WARNING: Prefer __aligned(x) over __attribute__((aligned(x))) #56: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:192: +#define __aligned(x) __attribute__((aligned(x))) ERROR: Macros with complex values should be enclosed in parentheses #88: FILE: tools/testing/selftests/bpf/progs/rbtree_search_kptr.c:21: +#define private(name) SEC(".data." #name) __hidden __aligned(8) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. CHECK: Please don't use multiple blank lines #200: FILE: tools/testing/selftests/bpf/progs/rbtree_search_kptr.c:133: + + total: 1 errors, 1 warnings, 1 checks, 192 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0efc50fec8cf ("selftests/bpf: Add supplementary tests for bpf_kptr_xchg") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.