ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.BDjxC8rfmq and /tmp/tmp.j38dny2NBy
Tree base:
ee5492fd88cf ("fbnic: close fw_log race between users and teardown")
Now at:
4e0c319cf076 ("selftests: tc_actions: don't dump 2MB of \0 to stdout")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/forwarding/tc_actions.sh - 214989032c111433771d451139a9586e0e9bbbdbef2ff7a65015fbb75e1f71b6


In tc_actions.sh line 19:
	simple_if_init $h1 192.0.2.1/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/24


In tc_actions.sh line 20:
	tc qdisc add dev $h1 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h1" clsact


In tc_actions.sh line 23:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 25:
	tc qdisc del dev $h1 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h1" clsact


In tc_actions.sh line 26:
	simple_if_fini $h1 192.0.2.1/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/24


In tc_actions.sh line 31:
	simple_if_init $h2 192.0.2.2/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/24


In tc_actions.sh line 32:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In tc_actions.sh line 35:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 37:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In tc_actions.sh line 38:
	simple_if_fini $h2 192.0.2.2/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/24


In tc_actions.sh line 43:
	simple_if_init $swp1 192.0.2.2/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$swp1" 192.0.2.2/24


In tc_actions.sh line 44:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In tc_actions.sh line 46:
	simple_if_init $swp2 192.0.2.1/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$swp2" 192.0.2.1/24


In tc_actions.sh line 49:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 51:
	simple_if_fini $swp2 192.0.2.1/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$swp2" 192.0.2.1/24


In tc_actions.sh line 53:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In tc_actions.sh line 54:
	simple_if_fini $swp1 192.0.2.2/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$swp1" 192.0.2.2/24


In tc_actions.sh line 57:
mirred_egress_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 66:
	tc filter add dev $h2 ingress protocol ip pref 1 handle 101 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 69:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 75:
	tc filter add dev $swp1 ingress protocol $protocol pref 1 handle 101 \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol "$protocol" pref 1 handle 101 \


In tc_actions.sh line 76:
		$classifier $tcflags $classifier_args \
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$classifier" "$tcflags" "$classifier_args" \


In tc_actions.sh line 77:
		action mirred egress $action dev $swp2
                                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		action mirred egress "$action" dev "$swp2"


In tc_actions.sh line 79:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 85:
	tc filter del dev $swp1 ingress protocol $protocol pref 1 handle 101 \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol "$protocol" pref 1 handle 101 \


In tc_actions.sh line 86:
		$classifier
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$classifier"


In tc_actions.sh line 87:
	tc filter del dev $h2 ingress protocol ip pref 1 handle 101 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 92:
gact_drop_and_ok_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 96:
	tc filter add dev $swp1 ingress protocol ip pref 2 handle 102 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 2 handle 102 flower \


In tc_actions.sh line 97:
		$tcflags dst_ip 192.0.2.2 action drop
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action drop


In tc_actions.sh line 99:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 105:
	tc filter add dev $swp1 ingress protocol ip pref 1 handle 101 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 106:
		$tcflags dst_ip 192.0.2.2 action ok
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action ok


In tc_actions.sh line 108:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 117:
	tc filter del dev $swp1 ingress protocol ip pref 2 handle 102 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 2 handle 102 flower


In tc_actions.sh line 118:
	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 123:
gact_trap_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 131:
	tc filter add dev $swp1 ingress protocol ip pref 1 handle 101 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 133:
	tc filter add dev $swp1 ingress protocol ip pref 3 handle 103 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 3 handle 103 flower \


In tc_actions.sh line 134:
		$tcflags dst_ip 192.0.2.2 action mirred egress redirect \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action mirred egress redirect \


In tc_actions.sh line 135:
		dev $swp2
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		dev "$swp2"


In tc_actions.sh line 137:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 143:
	tc filter add dev $swp1 ingress protocol ip pref 2 handle 102 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 2 handle 102 flower \


In tc_actions.sh line 144:
		$tcflags dst_ip 192.0.2.2 action trap
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action trap


In tc_actions.sh line 146:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 155:
	tc filter del dev $swp1 ingress protocol ip pref 3 handle 103 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 3 handle 103 flower


In tc_actions.sh line 156:
	tc filter del dev $swp1 ingress protocol ip pref 2 handle 102 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 2 handle 102 flower


In tc_actions.sh line 157:
	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 162:
mirred_egress_to_ingress_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 166:
	tc filter add dev $h1 protocol ip pref 100 handle 100 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 100 handle 100 egress flower \


In tc_actions.sh line 171:
			mirred ingress redirect dev $h1
                                                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			mirred ingress redirect dev "$h1"


In tc_actions.sh line 173:
	tc filter add dev $swp1 protocol ip pref 11 handle 111 ingress flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" protocol ip pref 11 handle 111 ingress flower \


In tc_actions.sh line 175:
	tc filter add dev $swp1 protocol ip pref 12 handle 112 ingress flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" protocol ip pref 12 handle 112 ingress flower \


In tc_actions.sh line 178:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 189:
	ping 192.0.2.2 -I$h1 -c1 -w1 -q 1>/dev/null 2>&1
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping 192.0.2.2 -I"$h1" -c1 -w1 -q 1>/dev/null 2>&1


In tc_actions.sh line 198:
	tc filter del dev $h1 egress protocol ip pref 100 handle 100 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 100 handle 100 flower


In tc_actions.sh line 199:
	tc filter del dev $swp1 ingress protocol ip pref 11 handle 111 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 11 handle 111 flower


In tc_actions.sh line 200:
	tc filter del dev $swp1 ingress protocol ip pref 12 handle 112 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 12 handle 112 flower


In tc_actions.sh line 205:
mirred_egress_to_ingress_tcp_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 210:
	dd conv=sparse status=none if=/dev/zero bs=1M count=2 of=$mirred_e2i_tf1
                                                                 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	dd conv=sparse status=none if=/dev/zero bs=1M count=2 of="$mirred_e2i_tf1"


In tc_actions.sh line 211:
	tc filter add dev $h1 protocol ip pref 100 handle 100 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 100 handle 100 egress flower \


In tc_actions.sh line 212:
		$tcflags ip_proto tcp src_ip 192.0.2.1 dst_ip 192.0.2.2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" ip_proto tcp src_ip 192.0.2.1 dst_ip 192.0.2.2 \


In tc_actions.sh line 218:
			action mirred ingress redirect dev $h1
                                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			action mirred ingress redirect dev "$h1"


In tc_actions.sh line 219:
	tc filter add dev $h1 protocol ip pref 101 handle 101 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 101 handle 101 egress flower \


In tc_actions.sh line 220:
		$tcflags ip_proto icmp \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" ip_proto icmp \


In tc_actions.sh line 221:
			action mirred ingress redirect dev $h1
                                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			action mirred ingress redirect dev "$h1"


In tc_actions.sh line 222:
	tc filter add dev $h1 protocol ip pref 102 handle 102 ingress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 102 handle 102 ingress flower \


In tc_actions.sh line 226:
	ip vrf exec v$h1 ncat --recv-only -w10 -l -p 12345 -o $mirred_e2i_tf2 &
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip vrf exec v"$h1" ncat --recv-only -w10 -l -p 12345 -o "$mirred_e2i_tf2" &


In tc_actions.sh line 228:
	ip vrf exec v$h1 ncat -w1 --send-only 192.0.2.2 12345 <$mirred_e2i_tf1
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip vrf exec v"$h1" ncat -w1 --send-only 192.0.2.2 12345 <"$mirred_e2i_tf1"


In tc_actions.sh line 229:
	wait -n $rpid
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	wait -n "$rpid"


In tc_actions.sh line 230:
	cmp -s $mirred_e2i_tf1 $mirred_e2i_tf2
               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	cmp -s "$mirred_e2i_tf1" "$mirred_e2i_tf2"


In tc_actions.sh line 233:
	$MZ $h1 -c 10 -p 64 -a $h1mac -b $h1mac -A 192.0.2.1 -B 192.0.2.1 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 10 -p 64 -a "$h1mac" -b "$h1mac" -A 192.0.2.1 -B 192.0.2.1 \


In tc_actions.sh line 240:
	tc filter del dev $h1 egress protocol ip pref 100 handle 100 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 100 handle 100 flower


In tc_actions.sh line 241:
	tc filter del dev $h1 egress protocol ip pref 101 handle 101 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 101 handle 101 flower


In tc_actions.sh line 242:
	tc filter del dev $h1 ingress protocol ip pref 102 handle 102 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" ingress protocol ip pref 102 handle 102 flower


In tc_actions.sh line 244:
	rm -f $mirred_e2i_tf1 $mirred_e2i_tf2
              ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	rm -f "$mirred_e2i_tf1" "$mirred_e2i_tf2"


In tc_actions.sh line 248:
ingress_2nd_vlan_push()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 250:
	tc filter add dev $swp1 ingress pref 20 chain 0 handle 20 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress pref 20 chain 0 handle 20 flower \


In tc_actions.sh line 251:
		$tcflags num_of_vlans 1 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 1 \


In tc_actions.sh line 253:
	tc filter add dev $swp1 ingress pref 30 chain 5 handle 30 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress pref 30 chain 5 handle 30 flower \


In tc_actions.sh line 254:
		$tcflags num_of_vlans 2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 2 \


In tc_actions.sh line 257:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 263:
	tc filter del dev $swp1 ingress pref 20 chain 0 handle 20 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress pref 20 chain 0 handle 20 flower


In tc_actions.sh line 264:
	tc filter del dev $swp1 ingress pref 30 chain 5 handle 30 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress pref 30 chain 5 handle 30 flower


In tc_actions.sh line 269:
egress_2nd_vlan_push()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 271:
	tc filter add dev $h1 egress pref 20 chain 0 handle 20 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" egress pref 20 chain 0 handle 20 flower \


In tc_actions.sh line 272:
		$tcflags num_of_vlans 0 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 0 \


In tc_actions.sh line 275:
	tc filter add dev $h1 egress pref 30 chain 5 handle 30 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" egress pref 30 chain 5 handle 30 flower \


In tc_actions.sh line 276:
		$tcflags num_of_vlans 2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 2 \


In tc_actions.sh line 279:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 285:
	tc filter del dev $h1 egress pref 20 chain 0 handle 20 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress pref 20 chain 0 handle 20 flower


In tc_actions.sh line 286:
	tc filter del dev $h1 egress pref 30 chain 5 handle 30 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress pref 30 chain 5 handle 30 flower


In tc_actions.sh line 299:
	h1mac=$(mac_get $h1)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h1mac=$(mac_get "$h1")


In tc_actions.sh line 300:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In tc_actions.sh line 302:
	swp1origmac=$(mac_get $swp1)
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	swp1origmac=$(mac_get "$swp1")


In tc_actions.sh line 303:
	swp2origmac=$(mac_get $swp2)
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	swp2origmac=$(mac_get "$swp2")


In tc_actions.sh line 304:
	ip link set $swp1 address $h2mac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" address "$h2mac"


In tc_actions.sh line 305:
	ip link set $swp2 address $h1mac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" address "$h1mac"


In tc_actions.sh line 314:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 326:
	ip link set $swp2 address $swp2origmac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" address "$swp2origmac"


In tc_actions.sh line 327:
	ip link set $swp1 address $swp1origmac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" address "$swp1origmac"


In tc_actions.sh line 329:
	for tf in $mirred_e2i_tf1 $mirred_e2i_tf2; do rm -f $tf; done
                                                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	for tf in $mirred_e2i_tf1 $mirred_e2i_tf2; do rm -f "$tf"; done


In tc_actions.sh line 332:
mirred_egress_redirect_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 337:
mirred_egress_mirror_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 342:
matchall_mirred_egress_mirror_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 355:
if [[ $? -ne 0 ]]; then
      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In tc_actions.sh line 362:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...
  https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/tc_actions.sh - 214989032c111433771d451139a9586e0e9bbbdbef2ff7a65015fbb75e1f71b6


In tc_actions.sh line 19:
	simple_if_init $h1 192.0.2.1/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/24


In tc_actions.sh line 20:
	tc qdisc add dev $h1 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h1" clsact


In tc_actions.sh line 23:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 25:
	tc qdisc del dev $h1 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h1" clsact


In tc_actions.sh line 26:
	simple_if_fini $h1 192.0.2.1/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/24


In tc_actions.sh line 31:
	simple_if_init $h2 192.0.2.2/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/24


In tc_actions.sh line 32:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In tc_actions.sh line 35:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 37:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In tc_actions.sh line 38:
	simple_if_fini $h2 192.0.2.2/24
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/24


In tc_actions.sh line 43:
	simple_if_init $swp1 192.0.2.2/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$swp1" 192.0.2.2/24


In tc_actions.sh line 44:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In tc_actions.sh line 46:
	simple_if_init $swp2 192.0.2.1/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$swp2" 192.0.2.1/24


In tc_actions.sh line 49:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 51:
	simple_if_fini $swp2 192.0.2.1/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$swp2" 192.0.2.1/24


In tc_actions.sh line 53:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In tc_actions.sh line 54:
	simple_if_fini $swp1 192.0.2.2/24
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$swp1" 192.0.2.2/24


In tc_actions.sh line 57:
mirred_egress_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 66:
	tc filter add dev $h2 ingress protocol ip pref 1 handle 101 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 69:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 75:
	tc filter add dev $swp1 ingress protocol $protocol pref 1 handle 101 \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol "$protocol" pref 1 handle 101 \


In tc_actions.sh line 76:
		$classifier $tcflags $classifier_args \
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$classifier" "$tcflags" "$classifier_args" \


In tc_actions.sh line 77:
		action mirred egress $action dev $swp2
                                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		action mirred egress "$action" dev "$swp2"


In tc_actions.sh line 79:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 85:
	tc filter del dev $swp1 ingress protocol $protocol pref 1 handle 101 \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol "$protocol" pref 1 handle 101 \


In tc_actions.sh line 86:
		$classifier
                ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$classifier"


In tc_actions.sh line 87:
	tc filter del dev $h2 ingress protocol ip pref 1 handle 101 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 92:
gact_drop_and_ok_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 96:
	tc filter add dev $swp1 ingress protocol ip pref 2 handle 102 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 2 handle 102 flower \


In tc_actions.sh line 97:
		$tcflags dst_ip 192.0.2.2 action drop
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action drop


In tc_actions.sh line 99:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 105:
	tc filter add dev $swp1 ingress protocol ip pref 1 handle 101 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 106:
		$tcflags dst_ip 192.0.2.2 action ok
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action ok


In tc_actions.sh line 108:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 117:
	tc filter del dev $swp1 ingress protocol ip pref 2 handle 102 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 2 handle 102 flower


In tc_actions.sh line 118:
	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 123:
gact_trap_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 131:
	tc filter add dev $swp1 ingress protocol ip pref 1 handle 101 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 1 handle 101 flower \


In tc_actions.sh line 133:
	tc filter add dev $swp1 ingress protocol ip pref 3 handle 103 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 3 handle 103 flower \


In tc_actions.sh line 134:
		$tcflags dst_ip 192.0.2.2 action mirred egress redirect \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action mirred egress redirect \


In tc_actions.sh line 135:
		dev $swp2
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		dev "$swp2"


In tc_actions.sh line 137:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 143:
	tc filter add dev $swp1 ingress protocol ip pref 2 handle 102 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress protocol ip pref 2 handle 102 flower \


In tc_actions.sh line 144:
		$tcflags dst_ip 192.0.2.2 action trap
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" dst_ip 192.0.2.2 action trap


In tc_actions.sh line 146:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 155:
	tc filter del dev $swp1 ingress protocol ip pref 3 handle 103 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 3 handle 103 flower


In tc_actions.sh line 156:
	tc filter del dev $swp1 ingress protocol ip pref 2 handle 102 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 2 handle 102 flower


In tc_actions.sh line 157:
	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 1 handle 101 flower


In tc_actions.sh line 162:
mirred_egress_to_ingress_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 166:
	tc filter add dev $h1 protocol ip pref 100 handle 100 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 100 handle 100 egress flower \


In tc_actions.sh line 171:
			mirred ingress redirect dev $h1
                                                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			mirred ingress redirect dev "$h1"


In tc_actions.sh line 173:
	tc filter add dev $swp1 protocol ip pref 11 handle 111 ingress flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" protocol ip pref 11 handle 111 ingress flower \


In tc_actions.sh line 175:
	tc filter add dev $swp1 protocol ip pref 12 handle 112 ingress flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" protocol ip pref 12 handle 112 ingress flower \


In tc_actions.sh line 178:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 189:
	ping 192.0.2.2 -I$h1 -c1 -w1 -q 1>/dev/null 2>&1
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping 192.0.2.2 -I"$h1" -c1 -w1 -q 1>/dev/null 2>&1


In tc_actions.sh line 198:
	tc filter del dev $h1 egress protocol ip pref 100 handle 100 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 100 handle 100 flower


In tc_actions.sh line 199:
	tc filter del dev $swp1 ingress protocol ip pref 11 handle 111 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 11 handle 111 flower


In tc_actions.sh line 200:
	tc filter del dev $swp1 ingress protocol ip pref 12 handle 112 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress protocol ip pref 12 handle 112 flower


In tc_actions.sh line 205:
mirred_egress_to_ingress_tcp_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 210:
	dd conv=sparse status=none if=/dev/zero bs=1M count=2 of=$mirred_e2i_tf1
                                                                 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	dd conv=sparse status=none if=/dev/zero bs=1M count=2 of="$mirred_e2i_tf1"


In tc_actions.sh line 211:
	tc filter add dev $h1 protocol ip pref 100 handle 100 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 100 handle 100 egress flower \


In tc_actions.sh line 212:
		$tcflags ip_proto tcp src_ip 192.0.2.1 dst_ip 192.0.2.2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" ip_proto tcp src_ip 192.0.2.1 dst_ip 192.0.2.2 \


In tc_actions.sh line 218:
			action mirred ingress redirect dev $h1
                                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			action mirred ingress redirect dev "$h1"


In tc_actions.sh line 219:
	tc filter add dev $h1 protocol ip pref 101 handle 101 egress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 101 handle 101 egress flower \


In tc_actions.sh line 220:
		$tcflags ip_proto icmp \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" ip_proto icmp \


In tc_actions.sh line 221:
			action mirred ingress redirect dev $h1
                                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			action mirred ingress redirect dev "$h1"


In tc_actions.sh line 222:
	tc filter add dev $h1 protocol ip pref 102 handle 102 ingress flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" protocol ip pref 102 handle 102 ingress flower \


In tc_actions.sh line 226:
	ip vrf exec v$h1 ncat --recv-only -w10 -l -p 12345 > $mirred_e2i_tf2 &
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip vrf exec v"$h1" ncat --recv-only -w10 -l -p 12345 > "$mirred_e2i_tf2" &


In tc_actions.sh line 228:
	ip vrf exec v$h1 ncat -w1 --send-only 192.0.2.2 12345 <$mirred_e2i_tf1
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip vrf exec v"$h1" ncat -w1 --send-only 192.0.2.2 12345 <"$mirred_e2i_tf1"


In tc_actions.sh line 229:
	wait -n $rpid
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	wait -n "$rpid"


In tc_actions.sh line 230:
	cmp -s $mirred_e2i_tf1 $mirred_e2i_tf2
               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	cmp -s "$mirred_e2i_tf1" "$mirred_e2i_tf2"


In tc_actions.sh line 233:
	$MZ $h1 -c 10 -p 64 -a $h1mac -b $h1mac -A 192.0.2.1 -B 192.0.2.1 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 10 -p 64 -a "$h1mac" -b "$h1mac" -A 192.0.2.1 -B 192.0.2.1 \


In tc_actions.sh line 240:
	tc filter del dev $h1 egress protocol ip pref 100 handle 100 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 100 handle 100 flower


In tc_actions.sh line 241:
	tc filter del dev $h1 egress protocol ip pref 101 handle 101 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress protocol ip pref 101 handle 101 flower


In tc_actions.sh line 242:
	tc filter del dev $h1 ingress protocol ip pref 102 handle 102 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" ingress protocol ip pref 102 handle 102 flower


In tc_actions.sh line 244:
	rm -f $mirred_e2i_tf1 $mirred_e2i_tf2
              ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	rm -f "$mirred_e2i_tf1" "$mirred_e2i_tf2"


In tc_actions.sh line 248:
ingress_2nd_vlan_push()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 250:
	tc filter add dev $swp1 ingress pref 20 chain 0 handle 20 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress pref 20 chain 0 handle 20 flower \


In tc_actions.sh line 251:
		$tcflags num_of_vlans 1 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 1 \


In tc_actions.sh line 253:
	tc filter add dev $swp1 ingress pref 30 chain 5 handle 30 flower \
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$swp1" ingress pref 30 chain 5 handle 30 flower \


In tc_actions.sh line 254:
		$tcflags num_of_vlans 2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 2 \


In tc_actions.sh line 257:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 263:
	tc filter del dev $swp1 ingress pref 20 chain 0 handle 20 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress pref 20 chain 0 handle 20 flower


In tc_actions.sh line 264:
	tc filter del dev $swp1 ingress pref 30 chain 5 handle 30 flower
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$swp1" ingress pref 30 chain 5 handle 30 flower


In tc_actions.sh line 269:
egress_2nd_vlan_push()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 271:
	tc filter add dev $h1 egress pref 20 chain 0 handle 20 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" egress pref 20 chain 0 handle 20 flower \


In tc_actions.sh line 272:
		$tcflags num_of_vlans 0 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 0 \


In tc_actions.sh line 275:
	tc filter add dev $h1 egress pref 30 chain 5 handle 30 flower \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h1" egress pref 30 chain 5 handle 30 flower \


In tc_actions.sh line 276:
		$tcflags num_of_vlans 2 \
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"$tcflags" num_of_vlans 2 \


In tc_actions.sh line 279:
	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" -A 192.0.2.1 -B 192.0.2.2 \


In tc_actions.sh line 285:
	tc filter del dev $h1 egress pref 20 chain 0 handle 20 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress pref 20 chain 0 handle 20 flower


In tc_actions.sh line 286:
	tc filter del dev $h1 egress pref 30 chain 5 handle 30 flower
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h1" egress pref 30 chain 5 handle 30 flower


In tc_actions.sh line 299:
	h1mac=$(mac_get $h1)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h1mac=$(mac_get "$h1")


In tc_actions.sh line 300:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In tc_actions.sh line 302:
	swp1origmac=$(mac_get $swp1)
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	swp1origmac=$(mac_get "$swp1")


In tc_actions.sh line 303:
	swp2origmac=$(mac_get $swp2)
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	swp2origmac=$(mac_get "$swp2")


In tc_actions.sh line 304:
	ip link set $swp1 address $h2mac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" address "$h2mac"


In tc_actions.sh line 305:
	ip link set $swp2 address $h1mac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" address "$h1mac"


In tc_actions.sh line 314:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 326:
	ip link set $swp2 address $swp2origmac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" address "$swp2origmac"


In tc_actions.sh line 327:
	ip link set $swp1 address $swp1origmac
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" address "$swp1origmac"


In tc_actions.sh line 329:
	for tf in $mirred_e2i_tf1 $mirred_e2i_tf2; do rm -f $tf; done
                                                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	for tf in $mirred_e2i_tf1 $mirred_e2i_tf2; do rm -f "$tf"; done


In tc_actions.sh line 332:
mirred_egress_redirect_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 337:
mirred_egress_mirror_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 342:
matchall_mirred_egress_mirror_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In tc_actions.sh line 355:
if [[ $? -ne 0 ]]; then
      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In tc_actions.sh line 362:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...
  https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...