ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.gneMCbQP8o and /tmp/tmp.SMekcpVZWk Tree base: 8383522821c6 ("Merge branch 'net-mscc-ocelot-fix-missing-lock-in-ocelot_port_xmit'") Now at: 3105aafb6556 ("selftests: forwarding: vxlan_bridge_1d: fix test failure with br_netfilter enabled") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh - 1cd9fbdd2848b0dfcba83240768117d913f847dcff97fe8acaf32c7c7b42f463 In vxlan_bridge_1d.sh line 64: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d.sh line 67: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d.sh line 87: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In vxlan_bridge_1d.sh line 88: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_bridge_1d.sh line 91: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 93: tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h1" clsact In vxlan_bridge_1d.sh line 94: simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/28 In vxlan_bridge_1d.sh line 99: simple_if_init $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 In vxlan_bridge_1d.sh line 100: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In vxlan_bridge_1d.sh line 103: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 105: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In vxlan_bridge_1d.sh line 106: simple_if_fini $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/28 In vxlan_bridge_1d.sh line 111: ip address add dev $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$rp1" 192.0.2.17/28 In vxlan_bridge_1d.sh line 117: rp1_unset_addr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 122: ip address del dev $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$rp1" 192.0.2.17/28 In vxlan_bridge_1d.sh line 130: ip link set dev br1 address $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1 address $(mac_get "$swp1") In vxlan_bridge_1d.sh line 133: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In vxlan_bridge_1d.sh line 142: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In vxlan_bridge_1d.sh line 143: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In vxlan_bridge_1d.sh line 145: ip link set dev $swp2 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br1 In vxlan_bridge_1d.sh line 146: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In vxlan_bridge_1d.sh line 152: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 155: ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" down In vxlan_bridge_1d.sh line 164: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In vxlan_bridge_1d.sh line 165: ip link set dev $swp2 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" nomaster In vxlan_bridge_1d.sh line 167: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In vxlan_bridge_1d.sh line 168: ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" nomaster In vxlan_bridge_1d.sh line 176: simple_if_init $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 192.0.2.18/28 In vxlan_bridge_1d.sh line 177: __simple_if_init v1 v$rp2 192.0.2.33/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v1 v"$rp2" 192.0.2.33/28 In vxlan_bridge_1d.sh line 178: __simple_if_init v3 v$rp2 192.0.2.49/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v3 v"$rp2" 192.0.2.49/28 In vxlan_bridge_1d.sh line 182: vrp2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 187: simple_if_fini $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$rp2" 192.0.2.18/28 In vxlan_bridge_1d.sh line 190: ns_init_common() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 198: ip link set dev $in_if up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$in_if" up In vxlan_bridge_1d.sh line 199: ip address add dev $in_if $in_addr/28 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$in_if" "$in_addr"/28 In vxlan_bridge_1d.sh line 200: tc qdisc add dev $in_if clsact ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$in_if" clsact In vxlan_bridge_1d.sh line 210: ip link add name vx2 type vxlan id 1000 local $in_addr dstport "$VXPORT" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name vx2 type vxlan id 1000 local "$in_addr" dstport "$VXPORT" In vxlan_bridge_1d.sh line 213: bridge fdb append dev vx2 00:00:00:00:00:00 dst $other_in_addr self ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb append dev vx2 00:00:00:00:00:00 dst "$other_in_addr" self In vxlan_bridge_1d.sh line 218: simple_if_init w2 $host_addr/28 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init w2 "$host_addr"/28 In vxlan_bridge_1d.sh line 220: ip route add 192.0.2.16/28 nexthop via $nh_addr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 192.0.2.16/28 nexthop via "$nh_addr" In vxlan_bridge_1d.sh line 221: ip route add $other_in_addr/32 nexthop via $nh_addr ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add "$other_in_addr"/32 nexthop via "$nh_addr" In vxlan_bridge_1d.sh line 233: ns1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 247: ns2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 279: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In vxlan_bridge_1d.sh line 282: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 304: reapply_config() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 322: ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 324: ping_test $h1 192.0.2.2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.2 ": local->local" In vxlan_bridge_1d.sh line 325: ping_test $h1 192.0.2.3 ": local->remote 1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.3 ": local->remote 1" In vxlan_bridge_1d.sh line 326: ping_test $h1 192.0.2.4 ": local->remote 2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.4 ": local->remote 2" In vxlan_bridge_1d.sh line 329: maybe_in_ns() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 331: echo ${1:+in_ns} $1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ${1:+in_ns} "$1" In vxlan_bridge_1d.sh line 334: __flood_counter_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 349: $(maybe_in_ns $ns) __icmp_capture_add_del \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") __icmp_capture_add_del \ In vxlan_bridge_1d.sh line 350: $add_del 100 "" $dev skip_sw 2>/dev/null || \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$add_del" 100 "" "$dev" skip_sw 2>/dev/null || \ In vxlan_bridge_1d.sh line 351: $(maybe_in_ns $ns) __icmp_capture_add_del \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") __icmp_capture_add_del \ In vxlan_bridge_1d.sh line 352: $add_del 100 "" $dev skip_hw ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$add_del" 100 "" "$dev" skip_hw In vxlan_bridge_1d.sh line 355: flood_counter_install() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 360: flood_counter_uninstall() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 365: flood_fetch_stat() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 370: $(maybe_in_ns $ns) tc_rule_stats_get $dev 100 ingress ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc_rule_stats_get "$dev" 100 ingress In vxlan_bridge_1d.sh line 373: flood_fetch_stats() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 379: flood_fetch_stat $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_fetch_stat "$counter" In vxlan_bridge_1d.sh line 383: vxlan_flood_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 389: local -a counters=($h2 "vx2 ns1" "vx2 ns2") ^-^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In vxlan_bridge_1d.sh line 394: flood_counter_install $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_install "$counter" In vxlan_bridge_1d.sh line 397: local -a t0s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d.sh line 398: $MZ $h1 -c 10 -d 100msec -p 64 -b $mac -B $dst -t icmp -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 10 -d 100msec -p 64 -b "$mac" -B "$dst" -t icmp -q In vxlan_bridge_1d.sh line 400: local -a t1s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d.sh line 402: for key in ${!t0s[@]}; do ^--------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_bridge_1d.sh line 403: local delta=$((t1s[$key] - t0s[$key])) ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d.sh line 411: flood_counter_uninstall $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_uninstall "$counter" In vxlan_bridge_1d.sh line 415: __test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 423: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 428: test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 441: vxlan_fdb_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 448: bridge fdb $add_del dev $dev $mac self static permanent \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" self static permanent \ In vxlan_bridge_1d.sh line 449: ${dst:+dst} $dst 2>/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${dst:+dst} "$dst" 2>/dev/null In vxlan_bridge_1d.sh line 450: bridge fdb $add_del dev $dev $mac master static 2>/dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" master static 2>/dev/null In vxlan_bridge_1d.sh line 453: __test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 463: expects[$hit_idx]=10 ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d.sh line 465: vxlan_flood_test $mac $dst "${expects[@]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" "${expects[@]}" In vxlan_bridge_1d.sh line 470: test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 478: vxlan_fdb_add_del add $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del add "$target" In vxlan_bridge_1d.sh line 481: __test_unicast $h2_mac 192.0.2.2 0 "local MAC unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$h2_mac" 192.0.2.2 0 "local MAC unicast" In vxlan_bridge_1d.sh line 482: __test_unicast $r1_mac 192.0.2.3 1 "remote MAC 1 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r1_mac" 192.0.2.3 1 "remote MAC 1 unicast" In vxlan_bridge_1d.sh line 483: __test_unicast $r2_mac 192.0.2.4 2 "remote MAC 2 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r2_mac" 192.0.2.4 2 "remote MAC 2 unicast" In vxlan_bridge_1d.sh line 486: vxlan_fdb_add_del del $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del del "$target" In vxlan_bridge_1d.sh line 490: vxlan_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 500: local t0=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d.sh line 501: ping_do $ping_dev $ping_dip "$ping_args" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$ping_dev" "$ping_dip" "$ping_args" In vxlan_bridge_1d.sh line 502: local t1=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d.sh line 510: test_ttl() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 516: vxlan_ping_test $h1 192.0.2.3 "" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "" v1 egress 77 10 In vxlan_bridge_1d.sh line 522: test_tos() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 528: vxlan_ping_test $h1 192.0.2.3 "-Q 0x14" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q 0x14" v1 egress 77 10 In vxlan_bridge_1d.sh line 529: vxlan_ping_test $h1 192.0.2.3 "-Q 0x18" v1 egress 77 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q 0x18" v1 egress 77 0 In vxlan_bridge_1d.sh line 535: __test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 543: flower ip_tos $tos ip_proto udp dst_port $VXPORT action pass ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$tos" ip_proto udp dst_port "$VXPORT" action pass In vxlan_bridge_1d.sh line 545: vxlan_ping_test $h1 192.0.2.3 "-Q $q" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q $q" v1 egress 77 10 In vxlan_bridge_1d.sh line 551: test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 560: vxlan_encapped_ping_do() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 570: $MZ $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$dev" -c "$count" -d 100msec -q \ In vxlan_bridge_1d.sh line 571: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_bridge_1d.sh line 572: -t udp tos=$outer_tos,sp=23456,dp=$VXPORT,p=$(: ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp tos="$outer_tos",sp=23456,dp="$VXPORT",p=$(: In vxlan_bridge_1d.sh line 573: )"08:"$( : VXLAN flags ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 574: )"00:00:00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 575: )"00:03:e8:"$( : VXLAN VNI ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 576: )"00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 577: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 578: )"$(mac_get w2):"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 579: )"08:00:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 580: )"45:"$( : IP version + IHL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 581: )"$inner_tos:"$( : IP TOS ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 582: )"00:54:"$( : IP total length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 583: )"99:83:"$( : IP identification ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 584: )"40:00:"$( : IP flags + frag off ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 585: )"40:"$( : IP TTL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 586: )"01:"$( : IP proto ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 587: )"00:00:"$( : IP header csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 588: )"c0:00:02:03:"$( : IP saddr: 192.0.2.3 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 589: )"c0:00:02:01:"$( : IP daddr: 192.0.2.1 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 590: )"08:"$( : ICMP type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 591: )"00:"$( : ICMP code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 592: )"8b:f2:"$( : ICMP csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 593: )"1f:6a:"$( : ICMP request identifier ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 594: )"00:01:"$( : ICMP request sequence number ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 595: )"4f:ff:c5:5b:00:00:00:00:"$( : ICMP payload ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 596: )"6d:74:0b:00:00:00:00:00:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 597: )"10:11:12:13:14:15:16:17:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 598: )"18:19:1a:1b:1c:1d:1e:1f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 599: )"20:21:22:23:24:25:26:27:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 600: )"28:29:2a:2b:2c:2d:2e:2f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 605: vxlan_encapped_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 615: local t0=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 618: vxlan_encapped_ping_do 10 $ping_dev $(mac_get $nh_dev) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_encapped_ping_do 10 "$ping_dev" $(mac_get "$nh_dev") \ In vxlan_bridge_1d.sh line 619: $ping_dip $(mac_get $h1) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$ping_dip" $(mac_get "$h1") \ In vxlan_bridge_1d.sh line 620: $inner_tos $outer_tos ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$inner_tos" "$outer_tos" In vxlan_bridge_1d.sh line 622: local t1=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 631: __test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 639: tc filter add dev $h1 ingress pref 77 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 prot ip \ In vxlan_bridge_1d.sh line 640: flower ip_tos $decapped_tos action drop ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$decapped_tos" action drop In vxlan_bridge_1d.sh line 643: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d.sh line 645: tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h1" ingress pref 77 In vxlan_bridge_1d.sh line 650: test_ecn_decap_error() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 658: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d.sh line 664: test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 686: test_learning() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 700: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 708: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 712: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 714: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 722: vxlan_flood_test $mac $dst 0 10 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 0 10 0 In vxlan_bridge_1d.sh line 730: bridge fdb del dev vx1 $mac master self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb del dev vx1 "$mac" master self In vxlan_bridge_1d.sh line 733: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 740: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 744: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 746: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 749: vxlan_flood_test $mac $dst 0 10 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 0 10 0 In vxlan_bridge_1d.sh line 752: $MZ $h1 -c 50 -d 1sec -p 64 -b $mac -B $dst -t icmp -q & ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 50 -d 1sec -p 64 -b "$mac" -B "$dst" -t icmp -q & In vxlan_bridge_1d.sh line 755: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 757: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 760: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 770: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 774: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 779: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 783: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 807: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh - 1cd9fbdd2848b0dfcba83240768117d913f847dcff97fe8acaf32c7c7b42f463 In vxlan_bridge_1d.sh line 64: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d.sh line 67: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d.sh line 87: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In vxlan_bridge_1d.sh line 88: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_bridge_1d.sh line 91: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 93: tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h1" clsact In vxlan_bridge_1d.sh line 94: simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/28 In vxlan_bridge_1d.sh line 99: simple_if_init $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 In vxlan_bridge_1d.sh line 100: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In vxlan_bridge_1d.sh line 103: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 105: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In vxlan_bridge_1d.sh line 106: simple_if_fini $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/28 In vxlan_bridge_1d.sh line 111: ip address add dev $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$rp1" 192.0.2.17/28 In vxlan_bridge_1d.sh line 117: rp1_unset_addr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 122: ip address del dev $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$rp1" 192.0.2.17/28 In vxlan_bridge_1d.sh line 130: ip link set dev br1 address $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1 address $(mac_get "$swp1") In vxlan_bridge_1d.sh line 133: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In vxlan_bridge_1d.sh line 142: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In vxlan_bridge_1d.sh line 143: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In vxlan_bridge_1d.sh line 145: ip link set dev $swp2 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br1 In vxlan_bridge_1d.sh line 146: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In vxlan_bridge_1d.sh line 152: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 155: ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" down In vxlan_bridge_1d.sh line 164: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In vxlan_bridge_1d.sh line 165: ip link set dev $swp2 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" nomaster In vxlan_bridge_1d.sh line 167: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In vxlan_bridge_1d.sh line 168: ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" nomaster In vxlan_bridge_1d.sh line 176: simple_if_init $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 192.0.2.18/28 In vxlan_bridge_1d.sh line 177: __simple_if_init v1 v$rp2 192.0.2.33/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v1 v"$rp2" 192.0.2.33/28 In vxlan_bridge_1d.sh line 178: __simple_if_init v3 v$rp2 192.0.2.49/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v3 v"$rp2" 192.0.2.49/28 In vxlan_bridge_1d.sh line 182: vrp2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 187: simple_if_fini $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$rp2" 192.0.2.18/28 In vxlan_bridge_1d.sh line 190: ns_init_common() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 198: ip link set dev $in_if up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$in_if" up In vxlan_bridge_1d.sh line 199: ip address add dev $in_if $in_addr/28 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$in_if" "$in_addr"/28 In vxlan_bridge_1d.sh line 200: tc qdisc add dev $in_if clsact ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$in_if" clsact In vxlan_bridge_1d.sh line 210: ip link add name vx2 type vxlan id 1000 local $in_addr dstport "$VXPORT" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name vx2 type vxlan id 1000 local "$in_addr" dstport "$VXPORT" In vxlan_bridge_1d.sh line 213: bridge fdb append dev vx2 00:00:00:00:00:00 dst $other_in_addr self ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb append dev vx2 00:00:00:00:00:00 dst "$other_in_addr" self In vxlan_bridge_1d.sh line 218: simple_if_init w2 $host_addr/28 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init w2 "$host_addr"/28 In vxlan_bridge_1d.sh line 220: ip route add 192.0.2.16/28 nexthop via $nh_addr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 192.0.2.16/28 nexthop via "$nh_addr" In vxlan_bridge_1d.sh line 221: ip route add $other_in_addr/32 nexthop via $nh_addr ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add "$other_in_addr"/32 nexthop via "$nh_addr" In vxlan_bridge_1d.sh line 233: ns1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 247: ns2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 279: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In vxlan_bridge_1d.sh line 282: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 304: reapply_config() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 322: ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 324: ping_test $h1 192.0.2.2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.2 ": local->local" In vxlan_bridge_1d.sh line 325: ping_test $h1 192.0.2.3 ": local->remote 1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.3 ": local->remote 1" In vxlan_bridge_1d.sh line 326: ping_test $h1 192.0.2.4 ": local->remote 2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.4 ": local->remote 2" In vxlan_bridge_1d.sh line 329: maybe_in_ns() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 331: echo ${1:+in_ns} $1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ${1:+in_ns} "$1" In vxlan_bridge_1d.sh line 334: __flood_counter_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 349: $(maybe_in_ns $ns) __icmp_capture_add_del \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") __icmp_capture_add_del \ In vxlan_bridge_1d.sh line 350: $add_del 100 "" $dev skip_sw 2>/dev/null || \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$add_del" 100 "" "$dev" skip_sw 2>/dev/null || \ In vxlan_bridge_1d.sh line 351: $(maybe_in_ns $ns) __icmp_capture_add_del \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") __icmp_capture_add_del \ In vxlan_bridge_1d.sh line 352: $add_del 100 "" $dev skip_hw ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$add_del" 100 "" "$dev" skip_hw In vxlan_bridge_1d.sh line 355: flood_counter_install() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 360: flood_counter_uninstall() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 365: flood_fetch_stat() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 370: $(maybe_in_ns $ns) tc_rule_stats_get $dev 100 ingress ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc_rule_stats_get "$dev" 100 ingress In vxlan_bridge_1d.sh line 373: flood_fetch_stats() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 379: flood_fetch_stat $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_fetch_stat "$counter" In vxlan_bridge_1d.sh line 383: vxlan_flood_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 389: local -a counters=($h2 "vx2 ns1" "vx2 ns2") ^-^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In vxlan_bridge_1d.sh line 394: flood_counter_install $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_install "$counter" In vxlan_bridge_1d.sh line 397: local -a t0s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d.sh line 398: $MZ $h1 -c 10 -d 100msec -p 64 -b $mac -B $dst -t icmp -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 10 -d 100msec -p 64 -b "$mac" -B "$dst" -t icmp -q In vxlan_bridge_1d.sh line 400: local -a t1s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d.sh line 402: for key in ${!t0s[@]}; do ^--------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_bridge_1d.sh line 403: local delta=$((t1s[$key] - t0s[$key])) ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d.sh line 411: flood_counter_uninstall $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_uninstall "$counter" In vxlan_bridge_1d.sh line 415: __test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 423: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 428: test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 441: vxlan_fdb_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 448: bridge fdb $add_del dev $dev $mac self static permanent \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" self static permanent \ In vxlan_bridge_1d.sh line 449: ${dst:+dst} $dst 2>/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${dst:+dst} "$dst" 2>/dev/null In vxlan_bridge_1d.sh line 450: bridge fdb $add_del dev $dev $mac master static 2>/dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" master static 2>/dev/null In vxlan_bridge_1d.sh line 453: __test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 463: expects[$hit_idx]=10 ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d.sh line 465: vxlan_flood_test $mac $dst "${expects[@]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" "${expects[@]}" In vxlan_bridge_1d.sh line 470: test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 478: vxlan_fdb_add_del add $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del add "$target" In vxlan_bridge_1d.sh line 481: __test_unicast $h2_mac 192.0.2.2 0 "local MAC unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$h2_mac" 192.0.2.2 0 "local MAC unicast" In vxlan_bridge_1d.sh line 482: __test_unicast $r1_mac 192.0.2.3 1 "remote MAC 1 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r1_mac" 192.0.2.3 1 "remote MAC 1 unicast" In vxlan_bridge_1d.sh line 483: __test_unicast $r2_mac 192.0.2.4 2 "remote MAC 2 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r2_mac" 192.0.2.4 2 "remote MAC 2 unicast" In vxlan_bridge_1d.sh line 486: vxlan_fdb_add_del del $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del del "$target" In vxlan_bridge_1d.sh line 490: vxlan_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 500: local t0=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d.sh line 501: ping_do $ping_dev $ping_dip "$ping_args" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$ping_dev" "$ping_dip" "$ping_args" In vxlan_bridge_1d.sh line 502: local t1=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d.sh line 510: test_ttl() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 516: vxlan_ping_test $h1 192.0.2.3 "" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "" v1 egress 77 10 In vxlan_bridge_1d.sh line 522: test_tos() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 528: vxlan_ping_test $h1 192.0.2.3 "-Q 0x14" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q 0x14" v1 egress 77 10 In vxlan_bridge_1d.sh line 529: vxlan_ping_test $h1 192.0.2.3 "-Q 0x18" v1 egress 77 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q 0x18" v1 egress 77 0 In vxlan_bridge_1d.sh line 535: __test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 543: flower ip_tos $tos ip_proto udp dst_port $VXPORT action pass ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$tos" ip_proto udp dst_port "$VXPORT" action pass In vxlan_bridge_1d.sh line 545: vxlan_ping_test $h1 192.0.2.3 "-Q $q" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 192.0.2.3 "-Q $q" v1 egress 77 10 In vxlan_bridge_1d.sh line 551: test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 560: vxlan_encapped_ping_do() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 570: local ipv4hdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 571: )"45:"$( : IP version + IHL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 572: )"$inner_tos:"$( : IP TOS ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 573: )"00:54:"$( : IP total length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 574: )"99:83:"$( : IP identification ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 575: )"40:00:"$( : IP flags + frag off ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 576: )"40:"$( : IP TTL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 577: )"01:"$( : IP proto ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 578: )"CHECKSUM:"$( : IP header csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 579: )"c0:00:02:03:"$( : IP saddr: 192.0.2.3 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In vxlan_bridge_1d.sh line 582: local checksum=$(payload_template_calc_checksum "$ipv4hdr") ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 583: ipv4hdr=$(payload_template_expand_checksum "$ipv4hdr" $checksum) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ipv4hdr=$(payload_template_expand_checksum "$ipv4hdr" "$checksum") In vxlan_bridge_1d.sh line 585: $MZ $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$dev" -c "$count" -d 100msec -q \ In vxlan_bridge_1d.sh line 586: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_bridge_1d.sh line 587: -t udp tos=$outer_tos,sp=23456,dp=$VXPORT,p=$(: ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp tos="$outer_tos",sp=23456,dp="$VXPORT",p=$(: In vxlan_bridge_1d.sh line 588: )"08:"$( : VXLAN flags ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 589: )"00:00:00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 590: )"00:03:e8:"$( : VXLAN VNI ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 591: )"00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 592: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 593: )"$(mac_get w2):"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 594: )"08:00:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 595: )"$ipv4hdr:"$( : IPv4 header ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 596: )"08:"$( : ICMP type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 597: )"00:"$( : ICMP code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 598: )"8b:f2:"$( : ICMP csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 599: )"1f:6a:"$( : ICMP request identifier ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 600: )"00:01:"$( : ICMP request sequence number ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 601: )"4f:ff:c5:5b:00:00:00:00:"$( : ICMP payload ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 602: )"6d:74:0b:00:00:00:00:00:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 603: )"10:11:12:13:14:15:16:17:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 604: )"18:19:1a:1b:1c:1d:1e:1f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 605: )"20:21:22:23:24:25:26:27:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 606: )"28:29:2a:2b:2c:2d:2e:2f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d.sh line 611: vxlan_encapped_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 621: local t0=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 624: vxlan_encapped_ping_do 10 $ping_dev $(mac_get $nh_dev) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_encapped_ping_do 10 "$ping_dev" $(mac_get "$nh_dev") \ In vxlan_bridge_1d.sh line 625: $ping_dip $(mac_get $h1) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$ping_dip" $(mac_get "$h1") \ In vxlan_bridge_1d.sh line 626: $inner_tos $outer_tos ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$inner_tos" "$outer_tos" In vxlan_bridge_1d.sh line 628: local t1=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d.sh line 637: __test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 645: tc filter add dev $h1 ingress pref 77 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 prot ip \ In vxlan_bridge_1d.sh line 646: flower ip_tos $decapped_tos action drop ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$decapped_tos" action drop In vxlan_bridge_1d.sh line 649: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d.sh line 651: tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h1" ingress pref 77 In vxlan_bridge_1d.sh line 656: test_ecn_decap_error() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 664: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d.sh line 670: test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 692: test_learning() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d.sh line 706: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 714: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 718: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 720: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 728: vxlan_flood_test $mac $dst 0 10 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 0 10 0 In vxlan_bridge_1d.sh line 736: bridge fdb del dev vx1 $mac master self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb del dev vx1 "$mac" master self In vxlan_bridge_1d.sh line 739: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 746: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 750: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 752: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 755: vxlan_flood_test $mac $dst 0 10 0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 0 10 0 In vxlan_bridge_1d.sh line 758: $MZ $h1 -c 50 -d 1sec -p 64 -b $mac -B $dst -t icmp -q & ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 50 -d 1sec -p 64 -b "$mac" -B "$dst" -t icmp -q & In vxlan_bridge_1d.sh line 761: bridge fdb show brport vx1 | grep $mac | grep -q self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q self In vxlan_bridge_1d.sh line 763: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 766: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d.sh line 776: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 780: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 785: in_ns ns1 $MZ w2 -c 1 -p 64 -a $mac -b ff:ff:ff:ff:ff:ff -B $dst \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: in_ns ns1 "$MZ" w2 -c 1 -p 64 -a "$mac" -b ff:ff:ff:ff:ff:ff -B "$dst" \ In vxlan_bridge_1d.sh line 789: bridge fdb show brport vx1 | grep $mac | grep -q -v self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb show brport vx1 | grep "$mac" | grep -q -v self In vxlan_bridge_1d.sh line 813: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...