CHECK: Prefer using the BIT macro
#61: FILE: tools/testing/selftests/bpf/conctest.c:313:
+#define CTX_TASK_OK	(1 << 0)

CHECK: Prefer using the BIT macro
#62: FILE: tools/testing/selftests/bpf/conctest.c:314:
+#define CTX_NMI_OK	(1 << 1)

WARNING: line length of 112 exceeds 80 columns
#92: FILE: tools/testing/selftests/bpf/conctest.c:333:
+	{ "lock",       "conctest_rqspinlock_task", "conctest_rqspinlock_nmi",       CTX_TASK_OK | CTX_NMI_OK },

WARNING: line length of 112 exceeds 80 columns
#93: FILE: tools/testing/selftests/bpf/conctest.c:334:
+	{ "lock_shift", "conctest_rqspinlock_task", "conctest_rqspinlock_nmi_shift", CTX_TASK_OK | CTX_NMI_OK },

WARNING: line length of 84 exceeds 80 columns
#120: FILE: tools/testing/selftests/bpf/conctest.c:360:
+	same_lock = (test->cfgs[0].task.prog_name == test->cfgs[1].nmi.prog_name) ||

WARNING: line length of 93 exceeds 80 columns
#121: FILE: tools/testing/selftests/bpf/conctest.c:361:
+		    (strcmp(test->cfgs[0].task.prog_name, "conctest_rqspinlock_task") == 0 &&

WARNING: line length of 90 exceeds 80 columns
#122: FILE: tools/testing/selftests/bpf/conctest.c:362:
+		     strcmp(test->cfgs[1].nmi.prog_name, "conctest_rqspinlock_nmi") == 0);

WARNING: line length of 82 exceeds 80 columns
#135: FILE: tools/testing/selftests/bpf/conctest.c:372:
+	state.delay_thresh_ns = (test->nr_cpus >= 3) ? 300000000ULL : 10000000ULL;

WARNING: line length of 82 exceeds 80 columns
#146: FILE: tools/testing/selftests/bpf/conctest.c:379:
+	state.delay_thresh_ns = (test->nr_cpus >= 3) ? 300000000ULL : 10000000ULL;

WARNING: line length of 120 exceeds 80 columns
#174: FILE: tools/testing/selftests/bpf/conctest.c:404:
+	{ "init",         "conctest_timer_task_reinit",     "conctest_timer_nmi_reinit",     CTX_TASK_OK | CTX_NMI_OK },

WARNING: line length of 120 exceeds 80 columns
#175: FILE: tools/testing/selftests/bpf/conctest.c:405:
+	{ "start",        "conctest_timer_task_start",      "conctest_timer_nmi_start",      CTX_TASK_OK | CTX_NMI_OK },

WARNING: line length of 108 exceeds 80 columns
#176: FILE: tools/testing/selftests/bpf/conctest.c:406:
+	{ "cancel",       "conctest_timer_task_cancel",      NULL,                            CTX_TASK_OK },

WARNING: line length of 122 exceeds 80 columns
#177: FILE: tools/testing/selftests/bpf/conctest.c:407:
+	{ "cancel_async", "conctest_timer_task_cancel_async","conctest_timer_nmi_cancel_async",CTX_TASK_OK | CTX_NMI_OK },

ERROR: space required after that ',' (ctx:VxV)
#177: FILE: tools/testing/selftests/bpf/conctest.c:407:
+	{ "cancel_async", "conctest_timer_task_cancel_async","conctest_timer_nmi_cancel_async",CTX_TASK_OK | CTX_NMI_OK },
 	                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#177: FILE: tools/testing/selftests/bpf/conctest.c:407:
+	{ "cancel_async", "conctest_timer_task_cancel_async","conctest_timer_nmi_cancel_async",CTX_TASK_OK | CTX_NMI_OK },
 	                                                                                      ^

WARNING: line length of 121 exceeds 80 columns
#178: FILE: tools/testing/selftests/bpf/conctest.c:408:
+	{ "set_cb",       "conctest_timer_task_set_cb",      "conctest_timer_nmi_set_cb",     CTX_TASK_OK | CTX_NMI_OK },

WARNING: line length of 121 exceeds 80 columns
#179: FILE: tools/testing/selftests/bpf/conctest.c:409:
+	{ "delete",       "conctest_timer_task_delete",      "conctest_timer_nmi_delete",     CTX_TASK_OK | CTX_NMI_OK },

WARNING: static const char * array should probably be static const char * const
#183: FILE: tools/testing/selftests/bpf/conctest.c:413:
+static const char *timer_extra_progs[] = { "conctest_timer_init", NULL };

WARNING: line length of 84 exceeds 80 columns
#205: FILE: tools/testing/selftests/bpf/conctest.c:435:
+static void add_test(const char *suite_name, const char *a_name, const char *b_name,

WARNING: line length of 85 exceeds 80 columns
#208: FILE: tools/testing/selftests/bpf/conctest.c:438:
+		     void (*init)(struct conctest *skel, struct conctest_test *test),

CHECK: Comparison to NULL could be written "nmi_prog"
#228: FILE: tools/testing/selftests/bpf/conctest.c:457:
+	t->vertical = (nmi_prog != NULL);

WARNING: line length of 82 exceeds 80 columns
#288: FILE: tools/testing/selftests/bpf/conctest.c:515:
+				if (!(b->ctx_mask & CTX_TASK_OK) || !b->task_prog)

WARNING: line length of 94 exceeds 80 columns
#349: FILE: tools/testing/selftests/bpf/conctest.c:747:
+		printf("Running test '%s' on %d CPU(s) for %d seconds\n", test->name, nr_cpus,

WARNING: line length of 83 exceeds 80 columns
#363: FILE: tools/testing/selftests/bpf/conctest.c:789:
+			ep_prog = bpf_object__find_program_by_name(skel->obj, *ep);

WARNING: line length of 87 exceeds 80 columns
#365: FILE: tools/testing/selftests/bpf/conctest.c:791:
+				fprintf(stderr, "Extra program '%s' not found\n", *ep);

CHECK: Prefer using the BIT_ULL macro
#476: FILE: tools/testing/selftests/bpf/progs/conctest.c:291:
+#define BPF_F_TIMER_CPU_PIN (1ULL << 1)

WARNING: line length of 82 exceeds 80 columns
#625: FILE: tools/testing/selftests/bpf/progs/conctest.c:440:
+			bpf_timer_init(&elem->timer, &timer_map, CLOCK_MONOTONIC);

WARNING: line length of 82 exceeds 80 columns
#693: FILE: tools/testing/selftests/bpf/progs/conctest.c:508:
+			bpf_timer_init(&elem->timer, &timer_map, CLOCK_MONOTONIC);

total: 2 errors, 22 warnings, 4 checks, 654 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 3b06fe1d6341 ("selftests/bpf: Generate various conctest permutations") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.