ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.Epx7T3uaW2 and /tmp/tmp.3xKaZc7STU
Tree base:
7ce1e5ad5d1e ("selftests: forwarding: vxlan_bridge_1d_ipv6: fix test failure with br_netfilter enabled")
Now at:
19b4941904c1 ("selftests: forwarding: fix pedit tests failure with br_netfilter enabled")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/forwarding/pedit_dsfield.sh - 563dba60b8bf8d62706a1afeec5a0ef25c1178af02b369b27a3fb99f5a908302


In pedit_dsfield.sh line 37:
: ${HIT_TIMEOUT:=2000} # ms
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In pedit_dsfield.sh line 41:
	simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_dsfield.sh line 44:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 46:
	simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_dsfield.sh line 51:
	simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_dsfield.sh line 52:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In pedit_dsfield.sh line 55:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 57:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In pedit_dsfield.sh line 58:
	simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_dsfield.sh line 66:
	ip link set dev $swp1 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" master br1


In pedit_dsfield.sh line 67:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In pedit_dsfield.sh line 68:
	ip link set dev $swp2 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" master br1


In pedit_dsfield.sh line 69:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In pedit_dsfield.sh line 71:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In pedit_dsfield.sh line 72:
	tc qdisc add dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp2" clsact


In pedit_dsfield.sh line 75:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 77:
	tc qdisc del dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp2" clsact


In pedit_dsfield.sh line 78:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In pedit_dsfield.sh line 80:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In pedit_dsfield.sh line 81:
	ip link set dev $swp2 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" nomaster


In pedit_dsfield.sh line 82:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In pedit_dsfield.sh line 83:
	ip link set dev $swp1 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" nomaster


In pedit_dsfield.sh line 95:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In pedit_dsfield.sh line 103:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 113:
ping_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 115:
	ping_test $h1 192.0.2.2
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_test "$h1" 192.0.2.2


In pedit_dsfield.sh line 118:
ping_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 120:
	ping6_test $h1 2001:db8:1::2
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_test "$h1" 2001:db8:1::2


In pedit_dsfield.sh line 123:
do_test_pedit_dsfield_common()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 133:
	$MZ $mz_flags $h1 -c 10 -d 20msec -p 100 \
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$mz_flags" "$h1" -c 10 -d 20msec -p 100 \


In pedit_dsfield.sh line 134:
	    -a own -b $h2mac -q -t tcp tos=0x7d,sp=54321,dp=12345
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	    -a own -b "$h2mac" -q -t tcp tos=0x7d,sp=54321,dp=12345


In pedit_dsfield.sh line 148:
do_test_pedit_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 155:
	local saddr=$1; shift
              ^---^ SC2034 (warning): saddr appears unused. Verify use (or export if used externally).


In pedit_dsfield.sh line 156:
	local daddr=$1; shift
              ^---^ SC2034 (warning): daddr appears unused. Verify use (or export if used externally).


In pedit_dsfield.sh line 158:
	tc filter add $pedit_locus handle 101 pref 1 \
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$pedit_locus" handle 101 pref 1 \


In pedit_dsfield.sh line 159:
	   flower action pedit ex munge $pedit_action
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower action pedit ex munge "$pedit_action"


In pedit_dsfield.sh line 160:
	tc filter add dev $h2 ingress handle 101 pref 1 prot $match_prot \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot "$match_prot" \


In pedit_dsfield.sh line 161:
	   flower skip_hw $match_flower action pass
                          ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower skip_hw "$match_flower" action pass


In pedit_dsfield.sh line 165:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_dsfield.sh line 166:
	tc filter del $pedit_locus pref 1
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$pedit_locus" pref 1


In pedit_dsfield.sh line 169:
do_test_ip_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 182:
test_ip_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 188:
do_test_ip_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 201:
test_ip_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 207:
do_test_ip_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 215:
				      ip "ip_tos $((124 | $ecn))"	\
                                                          ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In pedit_dsfield.sh line 220:
test_ip_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 226:
do_test_ip_dscp_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 230:
	tc filter add $locus handle 101 pref 1				\
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$locus" handle 101 pref 1				\


In pedit_dsfield.sh line 233:
	tc filter add dev $h2 ingress handle 101 pref 1 prot ip		\
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot ip		\


In pedit_dsfield.sh line 239:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_dsfield.sh line 240:
	tc filter del $locus pref 1
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$locus" pref 1


In pedit_dsfield.sh line 243:
test_ip_dscp_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 249:
do_test_ip6_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 262:
test_ip6_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 268:
do_test_ip6_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 281:
test_ip6_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 287:
do_test_ip6_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 295:
				ipv6 "ip_tos $((124 | $ecn))"		\
                                                      ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In pedit_dsfield.sh line 300:
test_ip6_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 313:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- daddr appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

Checking tools/testing/selftests/net/forwarding/pedit_ip.sh - 219deca691cb868dc6604533eaaada367a8ccb70860c5a243deb100fc016a49b


In pedit_ip.sh line 36:
	simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_ip.sh line 39:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 41:
	simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_ip.sh line 46:
	simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_ip.sh line 47:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In pedit_ip.sh line 50:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 52:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In pedit_ip.sh line 53:
	simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_ip.sh line 59:
	ip link set dev $swp1 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" master br1


In pedit_ip.sh line 60:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In pedit_ip.sh line 61:
	ip link set dev $swp2 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" master br1


In pedit_ip.sh line 62:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In pedit_ip.sh line 64:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In pedit_ip.sh line 65:
	tc qdisc add dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp2" clsact


In pedit_ip.sh line 68:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 70:
	tc qdisc del dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp2" clsact


In pedit_ip.sh line 71:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In pedit_ip.sh line 73:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In pedit_ip.sh line 74:
	ip link set dev $swp2 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" nomaster


In pedit_ip.sh line 75:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In pedit_ip.sh line 76:
	ip link set dev $swp1 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" nomaster


In pedit_ip.sh line 88:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In pedit_ip.sh line 96:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 106:
ping_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 108:
	ping_test $h1 192.0.2.2
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_test "$h1" 192.0.2.2


In pedit_ip.sh line 111:
ping_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 113:
	ping6_test $h1 2001:db8:1::2
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_test "$h1" 2001:db8:1::2


In pedit_ip.sh line 116:
do_test_pedit_ip()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 124:
	tc filter add $pedit_locus handle 101 pref 1 \
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$pedit_locus" handle 101 pref 1 \


In pedit_ip.sh line 125:
	   flower action pedit ex munge $pedit_action
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower action pedit ex munge "$pedit_action"


In pedit_ip.sh line 126:
	tc filter add dev $h2 ingress handle 101 pref 1 prot $match_prot \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot "$match_prot" \


In pedit_ip.sh line 127:
	   flower skip_hw $match_flower action pass
                          ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower skip_hw "$match_flower" action pass


In pedit_ip.sh line 131:
	$MZ $mz_flags $h1 -c 10 -d 20msec -p 100 -a own -b $h2mac -q -t ip
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$mz_flags" "$h1" -c 10 -d 20msec -p 100 -a own -b "$h2mac" -q -t ip


In pedit_ip.sh line 144:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_ip.sh line 145:
	tc filter del $pedit_locus pref 1
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$pedit_locus" pref 1


In pedit_ip.sh line 148:
do_test_pedit_ip6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 159:
do_test_pedit_ip4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 170:
test_ip4_src()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 176:
test_ip4_dst()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 182:
test_ip6_src()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 188:
test_ip6_dst()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 201:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/pedit_dsfield.sh - 563dba60b8bf8d62706a1afeec5a0ef25c1178af02b369b27a3fb99f5a908302


In pedit_dsfield.sh line 37:
: ${HIT_TIMEOUT:=2000} # ms
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In pedit_dsfield.sh line 41:
	simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_dsfield.sh line 44:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 46:
	simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_dsfield.sh line 51:
	simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_dsfield.sh line 52:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In pedit_dsfield.sh line 55:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 57:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In pedit_dsfield.sh line 58:
	simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_dsfield.sh line 66:
	ip link set dev $swp1 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" master br1


In pedit_dsfield.sh line 67:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In pedit_dsfield.sh line 68:
	ip link set dev $swp2 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" master br1


In pedit_dsfield.sh line 69:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In pedit_dsfield.sh line 71:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In pedit_dsfield.sh line 72:
	tc qdisc add dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp2" clsact


In pedit_dsfield.sh line 75:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 77:
	tc qdisc del dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp2" clsact


In pedit_dsfield.sh line 78:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In pedit_dsfield.sh line 80:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In pedit_dsfield.sh line 81:
	ip link set dev $swp2 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" nomaster


In pedit_dsfield.sh line 82:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In pedit_dsfield.sh line 83:
	ip link set dev $swp1 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" nomaster


In pedit_dsfield.sh line 95:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In pedit_dsfield.sh line 103:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 113:
ping_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 115:
	ping_test $h1 192.0.2.2
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_test "$h1" 192.0.2.2


In pedit_dsfield.sh line 118:
ping_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 120:
	ping6_test $h1 2001:db8:1::2
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_test "$h1" 2001:db8:1::2


In pedit_dsfield.sh line 123:
do_test_pedit_dsfield_common()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 133:
	$MZ $mz_flags $h1 -c 10 -d 20msec -p 100 \
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$mz_flags" "$h1" -c 10 -d 20msec -p 100 \


In pedit_dsfield.sh line 134:
	    -a own -b $h2mac -q -t tcp tos=0x7d,sp=54321,dp=12345
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	    -a own -b "$h2mac" -q -t tcp tos=0x7d,sp=54321,dp=12345


In pedit_dsfield.sh line 148:
do_test_pedit_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 155:
	local saddr=$1; shift
              ^---^ SC2034 (warning): saddr appears unused. Verify use (or export if used externally).


In pedit_dsfield.sh line 156:
	local daddr=$1; shift
              ^---^ SC2034 (warning): daddr appears unused. Verify use (or export if used externally).


In pedit_dsfield.sh line 158:
	tc filter add $pedit_locus handle 101 pref 1 \
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$pedit_locus" handle 101 pref 1 \


In pedit_dsfield.sh line 159:
	   flower action pedit ex munge $pedit_action pipe action csum ip
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower action pedit ex munge "$pedit_action" pipe action csum ip


In pedit_dsfield.sh line 160:
	tc filter add dev $h2 ingress handle 101 pref 1 prot $match_prot \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot "$match_prot" \


In pedit_dsfield.sh line 161:
	   flower skip_hw $match_flower action pass
                          ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower skip_hw "$match_flower" action pass


In pedit_dsfield.sh line 165:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_dsfield.sh line 166:
	tc filter del $pedit_locus pref 1
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$pedit_locus" pref 1


In pedit_dsfield.sh line 169:
do_test_ip_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 182:
test_ip_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 188:
do_test_ip_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 201:
test_ip_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 207:
do_test_ip_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 215:
				      ip "ip_tos $((124 | $ecn))"	\
                                                          ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In pedit_dsfield.sh line 220:
test_ip_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 226:
do_test_ip_dscp_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 230:
	tc filter add $locus handle 101 pref 1				\
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$locus" handle 101 pref 1				\


In pedit_dsfield.sh line 234:
	tc filter add dev $h2 ingress handle 101 pref 1 prot ip		\
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot ip		\


In pedit_dsfield.sh line 240:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_dsfield.sh line 241:
	tc filter del $locus pref 1
                      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$locus" pref 1


In pedit_dsfield.sh line 244:
test_ip_dscp_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 250:
do_test_ip6_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 263:
test_ip6_dsfield()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 269:
do_test_ip6_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 282:
test_ip6_dscp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 288:
do_test_ip6_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 296:
				ipv6 "ip_tos $((124 | $ecn))"		\
                                                      ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In pedit_dsfield.sh line 301:
test_ip6_ecn()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_dsfield.sh line 314:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- daddr appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

Checking tools/testing/selftests/net/forwarding/pedit_ip.sh - 219deca691cb868dc6604533eaaada367a8ccb70860c5a243deb100fc016a49b


In pedit_ip.sh line 36:
	simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_ip.sh line 39:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 41:
	simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64


In pedit_ip.sh line 46:
	simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_ip.sh line 47:
	tc qdisc add dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$h2" clsact


In pedit_ip.sh line 50:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 52:
	tc qdisc del dev $h2 clsact
                         ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$h2" clsact


In pedit_ip.sh line 53:
	simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64


In pedit_ip.sh line 59:
	ip link set dev $swp1 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" master br1


In pedit_ip.sh line 60:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In pedit_ip.sh line 61:
	ip link set dev $swp2 master br1
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" master br1


In pedit_ip.sh line 62:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In pedit_ip.sh line 64:
	tc qdisc add dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp1" clsact


In pedit_ip.sh line 65:
	tc qdisc add dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc add dev "$swp2" clsact


In pedit_ip.sh line 68:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 70:
	tc qdisc del dev $swp2 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp2" clsact


In pedit_ip.sh line 71:
	tc qdisc del dev $swp1 clsact
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc qdisc del dev "$swp1" clsact


In pedit_ip.sh line 73:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In pedit_ip.sh line 74:
	ip link set dev $swp2 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" nomaster


In pedit_ip.sh line 75:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In pedit_ip.sh line 76:
	ip link set dev $swp1 nomaster
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" nomaster


In pedit_ip.sh line 88:
	h2mac=$(mac_get $h2)
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	h2mac=$(mac_get "$h2")


In pedit_ip.sh line 96:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 106:
ping_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 108:
	ping_test $h1 192.0.2.2
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_test "$h1" 192.0.2.2


In pedit_ip.sh line 111:
ping_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 113:
	ping6_test $h1 2001:db8:1::2
                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_test "$h1" 2001:db8:1::2


In pedit_ip.sh line 116:
do_test_pedit_ip()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 124:
	tc filter add $pedit_locus handle 101 pref 1 \
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add "$pedit_locus" handle 101 pref 1 \


In pedit_ip.sh line 125:
	   flower action pedit ex munge $pedit_action pipe action csum ip
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower action pedit ex munge "$pedit_action" pipe action csum ip


In pedit_ip.sh line 126:
	tc filter add dev $h2 ingress handle 101 pref 1 prot $match_prot \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter add dev "$h2" ingress handle 101 pref 1 prot "$match_prot" \


In pedit_ip.sh line 127:
	   flower skip_hw $match_flower action pass
                          ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	   flower skip_hw "$match_flower" action pass


In pedit_ip.sh line 131:
	$MZ $mz_flags $h1 -c 10 -d 20msec -p 100 -a own -b $h2mac -q -t ip
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ "$mz_flags" "$h1" -c 10 -d 20msec -p 100 -a own -b "$h2mac" -q -t ip


In pedit_ip.sh line 144:
	tc filter del dev $h2 ingress pref 1
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del dev "$h2" ingress pref 1


In pedit_ip.sh line 145:
	tc filter del $pedit_locus pref 1
                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tc filter del "$pedit_locus" pref 1


In pedit_ip.sh line 148:
do_test_pedit_ip6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 159:
do_test_pedit_ip4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 170:
test_ip4_src()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 176:
test_ip4_dst()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 182:
test_ip6_src()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 188:
test_ip6_dst()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In pedit_ip.sh line 201:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...