ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.ikIVbKZ8B5 and /tmp/tmp.pVGQGc2MCF Tree base: 4a04ae6ab74b ("selftests: forwarding: vxlan_bridge_1d: fix test failure with br_netfilter enabled") Now at: 7ce1e5ad5d1e ("selftests: forwarding: vxlan_bridge_1d_ipv6: fix test failure with br_netfilter enabled") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh - 47ffff04640e21ad80f8af9423b68eb4588c8544da1029205f5bf16a182de6a9 In vxlan_bridge_1d_ipv6.sh line 66: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d_ipv6.sh line 69: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d_ipv6.sh line 91: simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64 In vxlan_bridge_1d_ipv6.sh line 92: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_bridge_1d_ipv6.sh line 95: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 97: tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h1" clsact In vxlan_bridge_1d_ipv6.sh line 98: simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64 In vxlan_bridge_1d_ipv6.sh line 103: simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64 In vxlan_bridge_1d_ipv6.sh line 104: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In vxlan_bridge_1d_ipv6.sh line 107: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 109: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In vxlan_bridge_1d_ipv6.sh line 110: simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64 In vxlan_bridge_1d_ipv6.sh line 115: ip address add dev $rp1 2001:db8:3::1/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$rp1" 2001:db8:3::1/64 In vxlan_bridge_1d_ipv6.sh line 121: rp1_unset_addr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 126: ip address del dev $rp1 2001:db8:3::1/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$rp1" 2001:db8:3::1/64 In vxlan_bridge_1d_ipv6.sh line 134: ip link set dev br1 address $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1 address $(mac_get "$swp1") In vxlan_bridge_1d_ipv6.sh line 137: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In vxlan_bridge_1d_ipv6.sh line 139: tc qdisc add dev $rp1 clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$rp1" clsact In vxlan_bridge_1d_ipv6.sh line 147: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In vxlan_bridge_1d_ipv6.sh line 148: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In vxlan_bridge_1d_ipv6.sh line 149: tc qdisc add dev $swp1 clsact ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$swp1" clsact In vxlan_bridge_1d_ipv6.sh line 151: ip link set dev $swp2 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br1 In vxlan_bridge_1d_ipv6.sh line 152: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In vxlan_bridge_1d_ipv6.sh line 158: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 163: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In vxlan_bridge_1d_ipv6.sh line 164: ip link set dev $swp2 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" nomaster In vxlan_bridge_1d_ipv6.sh line 166: tc qdisc del dev $swp1 clsact ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$swp1" clsact In vxlan_bridge_1d_ipv6.sh line 167: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In vxlan_bridge_1d_ipv6.sh line 168: ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" nomaster In vxlan_bridge_1d_ipv6.sh line 174: tc qdisc del dev $rp1 clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$rp1" clsact In vxlan_bridge_1d_ipv6.sh line 176: ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" down In vxlan_bridge_1d_ipv6.sh line 184: simple_if_init $rp2 2001:db8:3::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 2001:db8:3::2/64 In vxlan_bridge_1d_ipv6.sh line 185: __simple_if_init v1 v$rp2 2001:db8:4::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v1 v"$rp2" 2001:db8:4::2/64 In vxlan_bridge_1d_ipv6.sh line 186: __simple_if_init v3 v$rp2 2001:db8:5::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v3 v"$rp2" 2001:db8:5::2/64 In vxlan_bridge_1d_ipv6.sh line 190: vrp2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 195: simple_if_fini $rp2 2001:db8:3::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$rp2" 2001:db8:3::2/64 In vxlan_bridge_1d_ipv6.sh line 198: ns_init_common() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 207: ip link set dev $in_if up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$in_if" up In vxlan_bridge_1d_ipv6.sh line 208: ip address add dev $in_if $in_addr/64 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$in_if" "$in_addr"/64 In vxlan_bridge_1d_ipv6.sh line 209: tc qdisc add dev $in_if clsact ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$in_if" clsact In vxlan_bridge_1d_ipv6.sh line 219: ip link add name vx2 type vxlan id 1000 local $in_addr \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name vx2 type vxlan id 1000 local "$in_addr" \ In vxlan_bridge_1d_ipv6.sh line 223: bridge fdb append dev vx2 00:00:00:00:00:00 dst $other_in_addr self ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb append dev vx2 00:00:00:00:00:00 dst "$other_in_addr" self In vxlan_bridge_1d_ipv6.sh line 228: simple_if_init w2 $host_addr_ipv4/28 $host_addr_ipv6/64 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init w2 "$host_addr_ipv4"/28 "$host_addr_ipv6"/64 In vxlan_bridge_1d_ipv6.sh line 230: ip route add 2001:db8:3::0/64 nexthop via $nh_addr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 2001:db8:3::0/64 nexthop via "$nh_addr" In vxlan_bridge_1d_ipv6.sh line 231: ip route add $other_in_addr/128 nexthop via $nh_addr ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add "$other_in_addr"/128 nexthop via "$nh_addr" In vxlan_bridge_1d_ipv6.sh line 244: ns1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 259: ns2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 291: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In vxlan_bridge_1d_ipv6.sh line 294: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 316: reapply_config() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 334: __ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 345: tc filter add dev $rp1 egress protocol ipv6 pref 1 handle 101 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$rp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 346: flower ip_proto udp src_ip $vxlan_local_ip \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp src_ip "$vxlan_local_ip" \ In vxlan_bridge_1d_ipv6.sh line 347: dst_ip $vxlan_remote_ip dst_port $VXPORT $TC_FLAG action pass ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst_ip "$vxlan_remote_ip" dst_port "$VXPORT" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 351: tc filter add dev $swp1 egress protocol ip pref 1 handle 101 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$swp1" egress protocol ip pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 352: flower src_ip $dst_ip dst_ip $src_ip \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower src_ip "$dst_ip" dst_ip "$src_ip" \ In vxlan_bridge_1d_ipv6.sh line 353: $TC_FLAG action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 357: PING_COUNT=100 PING_TIMEOUT=20 ping_do $dev $dst_ip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: PING_COUNT=100 PING_TIMEOUT=20 ping_do "$dev" "$dst_ip" In vxlan_bridge_1d_ipv6.sh line 368: tc filter del dev $swp1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$swp1" egress In vxlan_bridge_1d_ipv6.sh line 369: tc filter del dev $rp1 egress ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$rp1" egress In vxlan_bridge_1d_ipv6.sh line 372: ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 383: ping_test $h1 192.0.2.2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.2 ": local->local" In vxlan_bridge_1d_ipv6.sh line 385: __ping_ipv4 $local_sw_ip $remote_ns1_ip $h1_ip $w2_ns1_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv4 "$local_sw_ip" "$remote_ns1_ip" "$h1_ip" "$w2_ns1_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 387: __ping_ipv4 $local_sw_ip $remote_ns2_ip $h1_ip $w2_ns2_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv4 "$local_sw_ip" "$remote_ns2_ip" "$h1_ip" "$w2_ns2_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 391: __ping_ipv6() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 402: tc filter add dev $rp1 egress protocol ipv6 pref 1 handle 101 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$rp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 403: flower ip_proto udp src_ip $vxlan_local_ip \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp src_ip "$vxlan_local_ip" \ In vxlan_bridge_1d_ipv6.sh line 404: dst_ip $vxlan_remote_ip dst_port $VXPORT $TC_FLAG action pass ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst_ip "$vxlan_remote_ip" dst_port "$VXPORT" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 408: tc filter add dev $swp1 egress protocol ipv6 pref 1 handle 101 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$swp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 409: flower src_ip $dst_ip dst_ip $src_ip $TC_FLAG action pass ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower src_ip "$dst_ip" dst_ip "$src_ip" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 413: PING_COUNT=100 PING_TIMEOUT=20 ping6_do $dev $dst_ip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: PING_COUNT=100 PING_TIMEOUT=20 ping6_do "$dev" "$dst_ip" In vxlan_bridge_1d_ipv6.sh line 424: tc filter del dev $swp1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$swp1" egress In vxlan_bridge_1d_ipv6.sh line 425: tc filter del dev $rp1 egress ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$rp1" egress In vxlan_bridge_1d_ipv6.sh line 428: ping_ipv6() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 439: ping6_test $h1 2001:db8:1::2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_test "$h1" 2001:db8:1::2 ": local->local" In vxlan_bridge_1d_ipv6.sh line 441: __ping_ipv6 $local_sw_ip $remote_ns1_ip $h1_ip $w2_ns1_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv6 "$local_sw_ip" "$remote_ns1_ip" "$h1_ip" "$w2_ns1_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 443: __ping_ipv6 $local_sw_ip $remote_ns2_ip $h1_ip $w2_ns2_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv6 "$local_sw_ip" "$remote_ns2_ip" "$h1_ip" "$w2_ns2_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 447: maybe_in_ns() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 449: echo ${1:+in_ns} $1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ${1:+in_ns} "$1" In vxlan_bridge_1d_ipv6.sh line 452: __flood_counter_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 468: $(maybe_in_ns $ns) tc filter $add_del dev "$dev" ingress \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc filter "$add_del" dev "$dev" ingress \ In vxlan_bridge_1d_ipv6.sh line 469: proto ipv6 pref 100 flower dst_ip $dst_ip ip_proto \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ipv6 pref 100 flower dst_ip "$dst_ip" ip_proto \ In vxlan_bridge_1d_ipv6.sh line 471: $(maybe_in_ns $ns) tc filter $add_del dev "$dev" ingress \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc filter "$add_del" dev "$dev" ingress \ In vxlan_bridge_1d_ipv6.sh line 472: proto ipv6 pref 100 flower dst_ip $dst_ip ip_proto \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ipv6 pref 100 flower dst_ip "$dst_ip" ip_proto \ In vxlan_bridge_1d_ipv6.sh line 476: flood_counter_install() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 481: flood_counter_uninstall() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 486: flood_fetch_stat() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 491: $(maybe_in_ns $ns) tc_rule_stats_get $dev 100 ingress ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc_rule_stats_get "$dev" 100 ingress In vxlan_bridge_1d_ipv6.sh line 494: flood_fetch_stats() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 500: flood_fetch_stat $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_fetch_stat "$counter" In vxlan_bridge_1d_ipv6.sh line 504: vxlan_flood_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 510: local -a counters=($h2 "vx2 ns1" "vx2 ns2") ^-^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In vxlan_bridge_1d_ipv6.sh line 515: flood_counter_install $dst $counter ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_install "$dst" "$counter" In vxlan_bridge_1d_ipv6.sh line 518: local -a t0s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d_ipv6.sh line 519: $MZ -6 $h1 -c 10 -d 100msec -p 64 -b $mac -B $dst -t icmp6 type=128 -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -6 "$h1" -c 10 -d 100msec -p 64 -b "$mac" -B "$dst" -t icmp6 type=128 -q In vxlan_bridge_1d_ipv6.sh line 521: local -a t1s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d_ipv6.sh line 523: for key in ${!t0s[@]}; do ^--------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_bridge_1d_ipv6.sh line 524: local delta=$((t1s[$key] - t0s[$key])) ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d_ipv6.sh line 532: flood_counter_uninstall $dst $counter ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_uninstall "$dst" "$counter" In vxlan_bridge_1d_ipv6.sh line 536: __test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 544: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d_ipv6.sh line 549: test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 554: vxlan_fdb_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 561: bridge fdb $add_del dev $dev $mac self static permanent \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" self static permanent \ In vxlan_bridge_1d_ipv6.sh line 562: ${dst:+dst} $dst 2>/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${dst:+dst} "$dst" 2>/dev/null In vxlan_bridge_1d_ipv6.sh line 563: bridge fdb $add_del dev $dev $mac master static 2>/dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" master static 2>/dev/null In vxlan_bridge_1d_ipv6.sh line 566: __test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 576: expects[$hit_idx]=10 ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d_ipv6.sh line 578: vxlan_flood_test $mac $dst "${expects[@]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" "${expects[@]}" In vxlan_bridge_1d_ipv6.sh line 583: test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 591: vxlan_fdb_add_del add $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del add "$target" In vxlan_bridge_1d_ipv6.sh line 594: __test_unicast $h2_mac 2001:db8:1::2 0 "local MAC unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$h2_mac" 2001:db8:1::2 0 "local MAC unicast" In vxlan_bridge_1d_ipv6.sh line 595: __test_unicast $r1_mac 2001:db8:1::3 1 "remote MAC 1 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r1_mac" 2001:db8:1::3 1 "remote MAC 1 unicast" In vxlan_bridge_1d_ipv6.sh line 596: __test_unicast $r2_mac 2001:db8:1::4 2 "remote MAC 2 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r2_mac" 2001:db8:1::4 2 "remote MAC 2 unicast" In vxlan_bridge_1d_ipv6.sh line 599: vxlan_fdb_add_del del $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del del "$target" In vxlan_bridge_1d_ipv6.sh line 603: vxlan_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 613: local t0=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d_ipv6.sh line 614: ping6_do $ping_dev $ping_dip "$ping_args" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$ping_dev" "$ping_dip" "$ping_args" In vxlan_bridge_1d_ipv6.sh line 615: local t1=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d_ipv6.sh line 623: test_ttl() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 629: vxlan_ping_test $h1 2001:db8:1::3 "" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 635: test_tos() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 641: vxlan_ping_test $h1 2001:db8:1::3 "-Q 0x14" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q 0x14" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 642: vxlan_ping_test $h1 2001:db8:1::3 "-Q 0x18" v1 egress 77 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q 0x18" v1 egress 77 0 In vxlan_bridge_1d_ipv6.sh line 648: __test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 656: flower ip_tos $tos ip_proto udp dst_port $VXPORT action pass ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$tos" ip_proto udp dst_port "$VXPORT" action pass In vxlan_bridge_1d_ipv6.sh line 658: vxlan_ping_test $h1 2001:db8:1::3 "-Q $q" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q $q" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 664: test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 673: vxlan_encapped_ping_do() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 685: $MZ -6 $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -6 "$dev" -c "$count" -d 100msec -q \ In vxlan_bridge_1d_ipv6.sh line 686: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_bridge_1d_ipv6.sh line 687: -t udp tos=$outer_tos,sp=23456,dp=$VXPORT,p=$(: ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp tos="$outer_tos",sp=23456,dp="$VXPORT",p=$(: In vxlan_bridge_1d_ipv6.sh line 688: )"08:"$( : VXLAN flags ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 689: )"00:00:00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 690: )"00:03:e8:"$( : VXLAN VNI ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 691: )"00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 692: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 693: )"$(mac_get w2):"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 694: )"86:dd:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 695: )"6"$( : IP version ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 696: )"$inner_tos"$( : Traffic class ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 697: )"0:00:00:"$( : Flow label ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 698: )"00:08:"$( : Payload length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 699: )"3a:"$( : Next header ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 700: )"04:"$( : Hop limit ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 701: )"$saddr:"$( : IP saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 702: )"$daddr:"$( : IP daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 703: )"80:"$( : ICMPv6.type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 704: )"00:"$( : ICMPv6.code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 705: )"00:"$( : ICMPv6.checksum ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 710: vxlan_encapped_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 720: local t0=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d_ipv6.sh line 723: vxlan_encapped_ping_do 10 $ping_dev $(mac_get $nh_dev) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_encapped_ping_do 10 "$ping_dev" $(mac_get "$nh_dev") \ In vxlan_bridge_1d_ipv6.sh line 724: $ping_dip $(mac_get $h1) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$ping_dip" $(mac_get "$h1") \ In vxlan_bridge_1d_ipv6.sh line 725: $inner_tos $outer_tos ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$inner_tos" "$outer_tos" In vxlan_bridge_1d_ipv6.sh line 727: local t1=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d_ipv6.sh line 736: __test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 744: tc filter add dev $h1 ingress pref 77 protocol ipv6 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 protocol ipv6 \ In vxlan_bridge_1d_ipv6.sh line 746: ip_tos $decapped_tos action drop ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip_tos "$decapped_tos" action drop In vxlan_bridge_1d_ipv6.sh line 749: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d_ipv6.sh line 751: tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h1" ingress pref 77 In vxlan_bridge_1d_ipv6.sh line 756: test_ecn_decap_error() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 764: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d_ipv6.sh line 770: test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 804: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh - 47ffff04640e21ad80f8af9423b68eb4588c8544da1029205f5bf16a182de6a9 In vxlan_bridge_1d_ipv6.sh line 66: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d_ipv6.sh line 69: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_bridge_1d_ipv6.sh line 91: simple_if_init $h1 192.0.2.1/28 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 2001:db8:1::1/64 In vxlan_bridge_1d_ipv6.sh line 92: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_bridge_1d_ipv6.sh line 95: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 97: tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h1" clsact In vxlan_bridge_1d_ipv6.sh line 98: simple_if_fini $h1 192.0.2.1/28 2001:db8:1::1/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" 192.0.2.1/28 2001:db8:1::1/64 In vxlan_bridge_1d_ipv6.sh line 103: simple_if_init $h2 192.0.2.2/28 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 2001:db8:1::2/64 In vxlan_bridge_1d_ipv6.sh line 104: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In vxlan_bridge_1d_ipv6.sh line 107: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 109: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In vxlan_bridge_1d_ipv6.sh line 110: simple_if_fini $h2 192.0.2.2/28 2001:db8:1::2/64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" 192.0.2.2/28 2001:db8:1::2/64 In vxlan_bridge_1d_ipv6.sh line 115: ip address add dev $rp1 2001:db8:3::1/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$rp1" 2001:db8:3::1/64 In vxlan_bridge_1d_ipv6.sh line 121: rp1_unset_addr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 126: ip address del dev $rp1 2001:db8:3::1/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address del dev "$rp1" 2001:db8:3::1/64 In vxlan_bridge_1d_ipv6.sh line 134: ip link set dev br1 address $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1 address $(mac_get "$swp1") In vxlan_bridge_1d_ipv6.sh line 137: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In vxlan_bridge_1d_ipv6.sh line 139: tc qdisc add dev $rp1 clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$rp1" clsact In vxlan_bridge_1d_ipv6.sh line 147: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In vxlan_bridge_1d_ipv6.sh line 148: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In vxlan_bridge_1d_ipv6.sh line 149: tc qdisc add dev $swp1 clsact ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$swp1" clsact In vxlan_bridge_1d_ipv6.sh line 151: ip link set dev $swp2 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" master br1 In vxlan_bridge_1d_ipv6.sh line 152: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In vxlan_bridge_1d_ipv6.sh line 158: switch_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 163: ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" down In vxlan_bridge_1d_ipv6.sh line 164: ip link set dev $swp2 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" nomaster In vxlan_bridge_1d_ipv6.sh line 166: tc qdisc del dev $swp1 clsact ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$swp1" clsact In vxlan_bridge_1d_ipv6.sh line 167: ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" down In vxlan_bridge_1d_ipv6.sh line 168: ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" nomaster In vxlan_bridge_1d_ipv6.sh line 174: tc qdisc del dev $rp1 clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$rp1" clsact In vxlan_bridge_1d_ipv6.sh line 176: ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" down In vxlan_bridge_1d_ipv6.sh line 184: simple_if_init $rp2 2001:db8:3::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 2001:db8:3::2/64 In vxlan_bridge_1d_ipv6.sh line 185: __simple_if_init v1 v$rp2 2001:db8:4::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v1 v"$rp2" 2001:db8:4::2/64 In vxlan_bridge_1d_ipv6.sh line 186: __simple_if_init v3 v$rp2 2001:db8:5::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init v3 v"$rp2" 2001:db8:5::2/64 In vxlan_bridge_1d_ipv6.sh line 190: vrp2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 195: simple_if_fini $rp2 2001:db8:3::2/64 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$rp2" 2001:db8:3::2/64 In vxlan_bridge_1d_ipv6.sh line 198: ns_init_common() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 207: ip link set dev $in_if up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$in_if" up In vxlan_bridge_1d_ipv6.sh line 208: ip address add dev $in_if $in_addr/64 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address add dev "$in_if" "$in_addr"/64 In vxlan_bridge_1d_ipv6.sh line 209: tc qdisc add dev $in_if clsact ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$in_if" clsact In vxlan_bridge_1d_ipv6.sh line 219: ip link add name vx2 type vxlan id 1000 local $in_addr \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name vx2 type vxlan id 1000 local "$in_addr" \ In vxlan_bridge_1d_ipv6.sh line 223: bridge fdb append dev vx2 00:00:00:00:00:00 dst $other_in_addr self ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb append dev vx2 00:00:00:00:00:00 dst "$other_in_addr" self In vxlan_bridge_1d_ipv6.sh line 228: simple_if_init w2 $host_addr_ipv4/28 $host_addr_ipv6/64 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init w2 "$host_addr_ipv4"/28 "$host_addr_ipv6"/64 In vxlan_bridge_1d_ipv6.sh line 230: ip route add 2001:db8:3::0/64 nexthop via $nh_addr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add 2001:db8:3::0/64 nexthop via "$nh_addr" In vxlan_bridge_1d_ipv6.sh line 231: ip route add $other_in_addr/128 nexthop via $nh_addr ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip route add "$other_in_addr"/128 nexthop via "$nh_addr" In vxlan_bridge_1d_ipv6.sh line 244: ns1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 259: ns2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 291: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In vxlan_bridge_1d_ipv6.sh line 294: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 316: reapply_config() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 334: __ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 345: tc filter add dev $rp1 egress protocol ipv6 pref 1 handle 101 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$rp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 346: flower ip_proto udp src_ip $vxlan_local_ip \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp src_ip "$vxlan_local_ip" \ In vxlan_bridge_1d_ipv6.sh line 347: dst_ip $vxlan_remote_ip dst_port $VXPORT $TC_FLAG action pass ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst_ip "$vxlan_remote_ip" dst_port "$VXPORT" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 351: tc filter add dev $swp1 egress protocol ip pref 1 handle 101 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$swp1" egress protocol ip pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 352: flower src_ip $dst_ip dst_ip $src_ip \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower src_ip "$dst_ip" dst_ip "$src_ip" \ In vxlan_bridge_1d_ipv6.sh line 353: $TC_FLAG action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 357: PING_COUNT=100 PING_TIMEOUT=20 ping_do $dev $dst_ip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: PING_COUNT=100 PING_TIMEOUT=20 ping_do "$dev" "$dst_ip" In vxlan_bridge_1d_ipv6.sh line 368: tc filter del dev $swp1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$swp1" egress In vxlan_bridge_1d_ipv6.sh line 369: tc filter del dev $rp1 egress ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$rp1" egress In vxlan_bridge_1d_ipv6.sh line 372: ping_ipv4() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 383: ping_test $h1 192.0.2.2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.2 ": local->local" In vxlan_bridge_1d_ipv6.sh line 385: __ping_ipv4 $local_sw_ip $remote_ns1_ip $h1_ip $w2_ns1_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv4 "$local_sw_ip" "$remote_ns1_ip" "$h1_ip" "$w2_ns1_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 387: __ping_ipv4 $local_sw_ip $remote_ns2_ip $h1_ip $w2_ns2_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv4 "$local_sw_ip" "$remote_ns2_ip" "$h1_ip" "$w2_ns2_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 391: __ping_ipv6() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 402: tc filter add dev $rp1 egress protocol ipv6 pref 1 handle 101 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$rp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 403: flower ip_proto udp src_ip $vxlan_local_ip \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp src_ip "$vxlan_local_ip" \ In vxlan_bridge_1d_ipv6.sh line 404: dst_ip $vxlan_remote_ip dst_port $VXPORT $TC_FLAG action pass ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dst_ip "$vxlan_remote_ip" dst_port "$VXPORT" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 408: tc filter add dev $swp1 egress protocol ipv6 pref 1 handle 101 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$swp1" egress protocol ipv6 pref 1 handle 101 \ In vxlan_bridge_1d_ipv6.sh line 409: flower src_ip $dst_ip dst_ip $src_ip $TC_FLAG action pass ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower src_ip "$dst_ip" dst_ip "$src_ip" "$TC_FLAG" action pass In vxlan_bridge_1d_ipv6.sh line 413: PING_COUNT=100 PING_TIMEOUT=20 ping6_do $dev $dst_ip ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: PING_COUNT=100 PING_TIMEOUT=20 ping6_do "$dev" "$dst_ip" In vxlan_bridge_1d_ipv6.sh line 424: tc filter del dev $swp1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$swp1" egress In vxlan_bridge_1d_ipv6.sh line 425: tc filter del dev $rp1 egress ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$rp1" egress In vxlan_bridge_1d_ipv6.sh line 428: ping_ipv6() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 439: ping6_test $h1 2001:db8:1::2 ": local->local" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_test "$h1" 2001:db8:1::2 ": local->local" In vxlan_bridge_1d_ipv6.sh line 441: __ping_ipv6 $local_sw_ip $remote_ns1_ip $h1_ip $w2_ns1_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv6 "$local_sw_ip" "$remote_ns1_ip" "$h1_ip" "$w2_ns1_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 443: __ping_ipv6 $local_sw_ip $remote_ns2_ip $h1_ip $w2_ns2_ip $h1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __ping_ipv6 "$local_sw_ip" "$remote_ns2_ip" "$h1_ip" "$w2_ns2_ip" "$h1" \ In vxlan_bridge_1d_ipv6.sh line 447: maybe_in_ns() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 449: echo ${1:+in_ns} $1 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo ${1:+in_ns} "$1" In vxlan_bridge_1d_ipv6.sh line 452: __flood_counter_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 468: $(maybe_in_ns $ns) tc filter $add_del dev "$dev" ingress \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc filter "$add_del" dev "$dev" ingress \ In vxlan_bridge_1d_ipv6.sh line 469: proto ipv6 pref 100 flower dst_ip $dst_ip ip_proto \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ipv6 pref 100 flower dst_ip "$dst_ip" ip_proto \ In vxlan_bridge_1d_ipv6.sh line 471: $(maybe_in_ns $ns) tc filter $add_del dev "$dev" ingress \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc filter "$add_del" dev "$dev" ingress \ In vxlan_bridge_1d_ipv6.sh line 472: proto ipv6 pref 100 flower dst_ip $dst_ip ip_proto \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ipv6 pref 100 flower dst_ip "$dst_ip" ip_proto \ In vxlan_bridge_1d_ipv6.sh line 476: flood_counter_install() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 481: flood_counter_uninstall() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 486: flood_fetch_stat() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 491: $(maybe_in_ns $ns) tc_rule_stats_get $dev 100 ingress ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(maybe_in_ns "$ns") tc_rule_stats_get "$dev" 100 ingress In vxlan_bridge_1d_ipv6.sh line 494: flood_fetch_stats() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 500: flood_fetch_stat $counter ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_fetch_stat "$counter" In vxlan_bridge_1d_ipv6.sh line 504: vxlan_flood_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 510: local -a counters=($h2 "vx2 ns1" "vx2 ns2") ^-^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In vxlan_bridge_1d_ipv6.sh line 515: flood_counter_install $dst $counter ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_install "$dst" "$counter" In vxlan_bridge_1d_ipv6.sh line 518: local -a t0s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d_ipv6.sh line 519: $MZ -6 $h1 -c 10 -d 100msec -p 64 -b $mac -B $dst -t icmp6 type=128 -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -6 "$h1" -c 10 -d 100msec -p 64 -b "$mac" -B "$dst" -t icmp6 type=128 -q In vxlan_bridge_1d_ipv6.sh line 521: local -a t1s=($(flood_fetch_stats "${counters[@]}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In vxlan_bridge_1d_ipv6.sh line 523: for key in ${!t0s[@]}; do ^--------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_bridge_1d_ipv6.sh line 524: local delta=$((t1s[$key] - t0s[$key])) ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. ^--^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d_ipv6.sh line 532: flood_counter_uninstall $dst $counter ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_counter_uninstall "$dst" "$counter" In vxlan_bridge_1d_ipv6.sh line 536: __test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 544: vxlan_flood_test $mac $dst 10 10 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" 10 10 10 In vxlan_bridge_1d_ipv6.sh line 549: test_flood() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 554: vxlan_fdb_add_del() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 561: bridge fdb $add_del dev $dev $mac self static permanent \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" self static permanent \ In vxlan_bridge_1d_ipv6.sh line 562: ${dst:+dst} $dst 2>/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ${dst:+dst} "$dst" 2>/dev/null In vxlan_bridge_1d_ipv6.sh line 563: bridge fdb $add_del dev $dev $mac master static 2>/dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge fdb "$add_del" dev "$dev" "$mac" master static 2>/dev/null In vxlan_bridge_1d_ipv6.sh line 566: __test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 576: expects[$hit_idx]=10 ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In vxlan_bridge_1d_ipv6.sh line 578: vxlan_flood_test $mac $dst "${expects[@]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_flood_test "$mac" "$dst" "${expects[@]}" In vxlan_bridge_1d_ipv6.sh line 583: test_unicast() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 591: vxlan_fdb_add_del add $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del add "$target" In vxlan_bridge_1d_ipv6.sh line 594: __test_unicast $h2_mac 2001:db8:1::2 0 "local MAC unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$h2_mac" 2001:db8:1::2 0 "local MAC unicast" In vxlan_bridge_1d_ipv6.sh line 595: __test_unicast $r1_mac 2001:db8:1::3 1 "remote MAC 1 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r1_mac" 2001:db8:1::3 1 "remote MAC 1 unicast" In vxlan_bridge_1d_ipv6.sh line 596: __test_unicast $r2_mac 2001:db8:1::4 2 "remote MAC 2 unicast" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __test_unicast "$r2_mac" 2001:db8:1::4 2 "remote MAC 2 unicast" In vxlan_bridge_1d_ipv6.sh line 599: vxlan_fdb_add_del del $target ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_fdb_add_del del "$target" In vxlan_bridge_1d_ipv6.sh line 603: vxlan_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 613: local t0=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d_ipv6.sh line 614: ping6_do $ping_dev $ping_dip "$ping_args" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$ping_dev" "$ping_dip" "$ping_args" In vxlan_bridge_1d_ipv6.sh line 615: local t1=$(tc_rule_stats_get $capture_dev $capture_pref $capture_dir) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(tc_rule_stats_get "$capture_dev" "$capture_pref" "$capture_dir") In vxlan_bridge_1d_ipv6.sh line 623: test_ttl() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 629: vxlan_ping_test $h1 2001:db8:1::3 "" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 635: test_tos() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 641: vxlan_ping_test $h1 2001:db8:1::3 "-Q 0x14" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q 0x14" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 642: vxlan_ping_test $h1 2001:db8:1::3 "-Q 0x18" v1 egress 77 0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q 0x18" v1 egress 77 0 In vxlan_bridge_1d_ipv6.sh line 648: __test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 656: flower ip_tos $tos ip_proto udp dst_port $VXPORT action pass ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_tos "$tos" ip_proto udp dst_port "$VXPORT" action pass In vxlan_bridge_1d_ipv6.sh line 658: vxlan_ping_test $h1 2001:db8:1::3 "-Q $q" v1 egress 77 10 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_test "$h1" 2001:db8:1::3 "-Q $q" v1 egress 77 10 In vxlan_bridge_1d_ipv6.sh line 664: test_ecn_encap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 673: vxlan_encapped_ping_do() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 685: $MZ -6 $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ -6 "$dev" -c "$count" -d 100msec -q \ In vxlan_bridge_1d_ipv6.sh line 686: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_bridge_1d_ipv6.sh line 687: -t udp tos=$outer_tos,sp=23456,dp=$VXPORT,p=$(: ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp tos="$outer_tos",sp=23456,dp="$VXPORT",p=$(: In vxlan_bridge_1d_ipv6.sh line 688: )"08:"$( : VXLAN flags ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 689: )"00:00:00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 690: )"00:03:e8:"$( : VXLAN VNI ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 691: )"00:"$( : VXLAN reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 692: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 693: )"$(mac_get w2):"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 694: )"86:dd:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 695: )"6"$( : IP version ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 696: )"$inner_tos"$( : Traffic class ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 697: )"0:00:00:"$( : Flow label ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 698: )"00:03:"$( : Payload length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 699: )"3a:"$( : Next header ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 700: )"04:"$( : Hop limit ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 701: )"$saddr:"$( : IP saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 702: )"$daddr:"$( : IP daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 703: )"80:"$( : ICMPv6.type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 704: )"00:"$( : ICMPv6.code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 705: )"00:"$( : ICMPv6.checksum ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_bridge_1d_ipv6.sh line 710: vxlan_encapped_ping_test() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 720: local t0=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d_ipv6.sh line 723: vxlan_encapped_ping_do 10 $ping_dev $(mac_get $nh_dev) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_encapped_ping_do 10 "$ping_dev" $(mac_get "$nh_dev") \ In vxlan_bridge_1d_ipv6.sh line 724: $ping_dip $(mac_get $h1) \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$ping_dip" $(mac_get "$h1") \ In vxlan_bridge_1d_ipv6.sh line 725: $inner_tos $outer_tos ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$inner_tos" "$outer_tos" In vxlan_bridge_1d_ipv6.sh line 727: local t1=$($stat_get) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_bridge_1d_ipv6.sh line 736: __test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 744: tc filter add dev $h1 ingress pref 77 protocol ipv6 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 protocol ipv6 \ In vxlan_bridge_1d_ipv6.sh line 746: ip_tos $decapped_tos action drop ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip_tos "$decapped_tos" action drop In vxlan_bridge_1d_ipv6.sh line 749: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d_ipv6.sh line 751: tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h1" ingress pref 77 In vxlan_bridge_1d_ipv6.sh line 756: test_ecn_decap_error() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 764: $orig_inner_tos $orig_outer_tos \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$orig_inner_tos" "$orig_outer_tos" \ In vxlan_bridge_1d_ipv6.sh line 770: test_ecn_decap() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In vxlan_bridge_1d_ipv6.sh line 804: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...