WARNING: Improper SPDX comment style for 'include/linux/ml-lib/ml_lib.h', please use '/*' instead #59: FILE: include/linux/ml-lib/ml_lib.h:1: +// SPDX-License-Identifier: GPL-2.0-only WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #59: FILE: include/linux/ml-lib/ml_lib.h:1: +// SPDX-License-Identifier: GPL-2.0-only CHECK: Alignment should match open parenthesis #224: FILE: include/linux/ml-lib/ml_lib.h:166: + int (*extract)(struct ml_lib_model *ml_model, + struct ml_lib_dataset *dataset); CHECK: Alignment should match open parenthesis #226: FILE: include/linux/ml-lib/ml_lib.h:168: + int (*preprocess_data)(struct ml_lib_model *ml_model, + struct ml_lib_dataset *dataset); CHECK: Alignment should match open parenthesis #320: FILE: include/linux/ml-lib/ml_lib.h:262: + int (*re_init)(struct ml_lib_model *ml_model, + struct ml_lib_model_options *options); CHECK: Alignment should match open parenthesis #330: FILE: include/linux/ml-lib/ml_lib.h:272: + int (*preprocess_data)(struct ml_lib_model *ml_model, + struct ml_lib_dataset *dataset); CHECK: Alignment should match open parenthesis #335: FILE: include/linux/ml-lib/ml_lib.h:277: + int (*preprocess_recommendation)(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #338: FILE: include/linux/ml-lib/ml_lib.h:280: + int (*apply_recommendation)(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #340: FILE: include/linux/ml-lib/ml_lib.h:282: + int (*execute_operation)(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #343: FILE: include/linux/ml-lib/ml_lib.h:285: + int (*estimate_efficiency)(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #346: FILE: include/linux/ml-lib/ml_lib.h:288: + int (*error_backpropagation)(struct ml_lib_model *ml_model, + struct ml_lib_backpropagation_feedback *feedback, WARNING: 'susbsystem' may be misspelled - perhaps 'subsystem'? #355: FILE: include/linux/ml-lib/ml_lib.h:297: + * @subsystem_name: name of susbsystem ^^^^^^^^^^ CHECK: spinlock_t definition without comment #375: FILE: include/linux/ml-lib/ml_lib.h:317: + spinlock_t parent_state_lock; CHECK: spinlock_t definition without comment #378: FILE: include/linux/ml-lib/ml_lib.h:320: + spinlock_t options_lock; CHECK: spinlock_t definition without comment #381: FILE: include/linux/ml-lib/ml_lib.h:323: + spinlock_t dataset_lock; CHECK: Alignment should match open parenthesis #432: FILE: include/linux/ml-lib/ml_lib.h:374: +int ml_model_preprocess_recommendation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #435: FILE: include/linux/ml-lib/ml_lib.h:377: +int apply_ml_model_recommendation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #437: FILE: include/linux/ml-lib/ml_lib.h:379: +int execute_ml_model_operation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #440: FILE: include/linux/ml-lib/ml_lib.h:382: +int estimate_ml_model_efficiency(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #443: FILE: include/linux/ml-lib/ml_lib.h:385: +int ml_model_error_backpropagation(struct ml_lib_model *ml_model, + struct ml_lib_backpropagation_feedback *feedback, CHECK: Alignment should match open parenthesis #468: FILE: include/linux/ml-lib/ml_lib.h:410: +int generic_preprocess_recommendation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #471: FILE: include/linux/ml-lib/ml_lib.h:413: +int generic_apply_recommendation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint); CHECK: Alignment should match open parenthesis #473: FILE: include/linux/ml-lib/ml_lib.h:415: +int generic_execute_operation(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #476: FILE: include/linux/ml-lib/ml_lib.h:418: +int generic_estimate_efficiency(struct ml_lib_model *ml_model, + struct ml_lib_user_space_recommendation *hint, CHECK: Alignment should match open parenthesis #479: FILE: include/linux/ml-lib/ml_lib.h:421: +int generic_error_backpropagation(struct ml_lib_model *ml_model, + struct ml_lib_backpropagation_feedback *feedback, total: 0 errors, 3 warnings, 22 checks, 425 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit cae025c912ee ("ml-lib: Introduce Machine Learning (ML) library declarations") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 3 warnings, 22 checks, 425 lines checked