WARNING: Missing commit description - Add an appropriate one WARNING: It's generally not useful to have the filename in the file #74: FILE: drivers/nfc/pn7160/Kconfig:39: +source "drivers/nfc/pn7160/Kconfig" WARNING: Unnecessary ftrace-like logging - prefer using ftrace #255: FILE: drivers/nfc/pn7160/common.c:162: + pr_debug("%s: entry\n", __func__); WARNING: Improper SPDX comment style for 'drivers/nfc/pn7160/common.h', please use '/*' instead #471: FILE: drivers/nfc/pn7160/common.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #471: FILE: drivers/nfc/pn7160/common.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later CHECK: Lines should not end with a '(' #628: FILE: drivers/nfc/pn7160/i2c_drv.c:116: + ret = wait_event_interruptible_timeout( CHECK: Lines should not end with a '(' #639: FILE: drivers/nfc/pn7160/i2c_drv.c:127: + ret = wait_event_interruptible( CHECK: braces {} should be used on all arms of this statement #710: FILE: drivers/nfc/pn7160/i2c_drv.c:198: + if (ret <= 0) { [...] + } else if (ret != count) { [...] + } else if (ret == count) [...] WARNING: Unnecessary ftrace-like logging - prefer using ftrace #787: FILE: drivers/nfc/pn7160/i2c_drv.c:275: + pr_debug("%s: enter\n", __func__); CHECK: Comparison to NULL could be written "!nfc_dev" #803: FILE: drivers/nfc/pn7160/i2c_drv.c:291: + if (nfc_dev == NULL) { CHECK: Comparison to NULL could be written "!i2c_dev" #809: FILE: drivers/nfc/pn7160/i2c_drv.c:297: + if (i2c_dev == NULL) { WARNING: DT compatible string "nxp,nxpnfc" appears un-documented -- check ./Documentation/devicetree/bindings/ #1000: FILE: drivers/nfc/pn7160/i2c_drv.c:488: + { .compatible = "nxp,nxpnfc" }, WARNING: Improper SPDX comment style for 'drivers/nfc/pn7160/i2c_drv.h', please use '/*' instead #1050: FILE: drivers/nfc/pn7160/i2c_drv.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1050: FILE: drivers/nfc/pn7160/i2c_drv.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING: Improper SPDX comment style for 'drivers/nfc/pn7160/platform.h', please use '/*' instead #1082: FILE: drivers/nfc/pn7160/platform.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1082: FILE: drivers/nfc/pn7160/platform.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later CHECK: spinlock_t definition without comment #1169: FILE: drivers/nfc/pn7160/platform.h:88: + spinlock_t irq_enabled_lock; CHECK: spinlock_t definition without comment #1179: FILE: drivers/nfc/pn7160/platform.h:98: + spinlock_t irq_enabled_lock; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1183: FILE: drivers/nfc/pn7160/platform.h:102: + uint8_t *tmp_write_kbuf; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1185: FILE: drivers/nfc/pn7160/platform.h:104: + uint8_t *tmp_read_kbuf; CHECK: struct mutex definition without comment #1191: FILE: drivers/nfc/pn7160/platform.h:110: + struct mutex read_mutex; CHECK: struct mutex definition without comment #1192: FILE: drivers/nfc/pn7160/platform.h:111: + struct mutex write_mutex; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1193: FILE: drivers/nfc/pn7160/platform.h:112: + uint8_t *read_kbuf; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1194: FILE: drivers/nfc/pn7160/platform.h:113: + uint8_t *write_kbuf; CHECK: struct mutex definition without comment #1195: FILE: drivers/nfc/pn7160/platform.h:114: + struct mutex dev_ref_mutex; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1202: FILE: drivers/nfc/pn7160/platform.h:121: + uint8_t interface; CHECK: Prefer kernel type 'u8' over 'uint8_t' #1204: FILE: drivers/nfc/pn7160/platform.h:123: + uint8_t nfc_state; WARNING: From:/Signed-off-by: email address mismatch: 'From: xuchen ' != 'Signed-off-by: xuchen <434779359@qq.com>' total: 0 errors, 12 warnings, 16 checks, 1174 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 6d96165de2de ("nfc: supply: Add PN7160 drivers   This patch adds support for the PN7160 ICs used in Qualcomm reference designs.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 16 checks, 1174 lines checked