ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.IUhvPFZoGg and /tmp/tmp.Vg1XiCORN0
Tree base:
f7936d01c97c ("net: bridge: mcast: export ip{4,6}_active state to netlink")
Now at:
8789a821da90 ("net: bridge: mcast: track active state, adding tests")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/bridge_mdb_active.sh - 2488771f82f1402e95d55c287b38fc65ed6430faf03b039b8393d7f60b67bfc1


In bridge_mdb_active.sh line 58:
		mcast_query_response_interval $((${MCAST_MAX_RESP_IVAL_SEC}*100))\
                                                 ^------------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In bridge_mdb_active.sh line 63:
		mcast_query_response_interval $((${MCAST_MAX_RESP_IVAL_SEC}*100))\
                                                 ^------------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In bridge_mdb_active.sh line 70:
	ip link set dev $swp1 master br0
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" master br0


In bridge_mdb_active.sh line 71:
	ip link set dev $h1 master brq0
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$h1" master brq0


In bridge_mdb_active.sh line 73:
	ip link set dev $h1 up
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$h1" up


In bridge_mdb_active.sh line 74:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In bridge_mdb_active.sh line 77:
switch_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 79:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In bridge_mdb_active.sh line 80:
	ip link set dev $h1 down
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$h1" down


In bridge_mdb_active.sh line 94:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 100:
mcast_active_check()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 112:
mcast_vlan_active_check()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 124:
	if [ $ret -eq 0 -a $state -eq 0 ] || [ $ret -ne 0 -a $state -eq 1 ]; then
             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
                                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if [ "$ret" -eq 0 -a "$state" -eq 0 ] || [ "$ret" -ne 0 -a "$state" -eq 1 ]; then


In bridge_mdb_active.sh line 129:
mcast_assert_active_v4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 134:
mcast_assert_active_v6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 139:
mcast_assert_inactive_v4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 144:
mcast_assert_inactive_v6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 149:
mcast_vlan_assert_active_v4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 154:
mcast_vlan_assert_active_v6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 159:
mcast_vlan_assert_inactive_v4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 164:
mcast_vlan_assert_inactive_v6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 170:
test_inactive_nolog()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 188:
test_inactive()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 196:
wait_lladdr_dad() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 205:
test_active_setup_bridge()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 216:
test_active_setup_config()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 224:
test_active_setup_wait()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 226:
	sleep $((${MCAST_MAX_RESP_IVAL_SEC} * 2))
                 ^------------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In bridge_mdb_active.sh line 229:
test_active_setup_reset_own_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 237:
test_vlan_active_setup_config()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 245:
test_vlan_active_setup_add_vlan()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 247:
	bridge vlan add vid ${MCAST_VLAN_ID} dev $swp1
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add vid "${MCAST_VLAN_ID}" dev "$swp1"


In bridge_mdb_active.sh line 248:
	bridge vlan add vid ${MCAST_VLAN_ID} dev $h1
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add vid "${MCAST_VLAN_ID}" dev "$h1"


In bridge_mdb_active.sh line 249:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev br0\
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0\


In bridge_mdb_active.sh line 250:
		mcast_query_response_interval $((${MCAST_MAX_RESP_IVAL_SEC}*100))
                                                 ^------------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In bridge_mdb_active.sh line 251:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev brq0\
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev brq0\


In bridge_mdb_active.sh line 252:
		mcast_query_response_interval $((${MCAST_MAX_RESP_IVAL_SEC}*100))
                                                 ^------------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In bridge_mdb_active.sh line 253:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_snooping 0
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_snooping 0


In bridge_mdb_active.sh line 254:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev brq0 mcast_snooping 0
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev brq0 mcast_snooping 0


In bridge_mdb_active.sh line 255:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_querier 0
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_querier 0


In bridge_mdb_active.sh line 256:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev brq0 mcast_querier 0
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev brq0 mcast_querier 0


In bridge_mdb_active.sh line 259:
test_vlan_active_setup_config_vlan()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 261:
	[ -n "$1" ] && bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_snooping 1
                                                  ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ -n "$1" ] && bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_snooping 1


In bridge_mdb_active.sh line 262:
	[ -n "$2" ] && bridge vlan global set vid ${MCAST_VLAN_ID} dev brq0 mcast_snooping 1
                                                  ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ -n "$2" ] && bridge vlan global set vid "${MCAST_VLAN_ID}" dev brq0 mcast_snooping 1


In bridge_mdb_active.sh line 263:
	[ -n "$3" ] && bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_querier 1
                                                  ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ -n "$3" ] && bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_querier 1


In bridge_mdb_active.sh line 264:
	[ -n "$4" ] && bridge vlan global set vid ${MCAST_VLAN_ID} dev brq0 mcast_querier 1
                                                  ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	[ -n "$4" ] && bridge vlan global set vid "${MCAST_VLAN_ID}" dev brq0 mcast_querier 1


In bridge_mdb_active.sh line 267:
test_vlan_teardown()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 269:
	bridge vlan del vid ${MCAST_VLAN_ID} dev $swp1
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan del vid "${MCAST_VLAN_ID}" dev "$swp1"


In bridge_mdb_active.sh line 270:
	bridge vlan del vid ${MCAST_VLAN_ID} dev $h1
                            ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan del vid "${MCAST_VLAN_ID}" dev "$h1"


In bridge_mdb_active.sh line 277:
test_vlan_active_setup_reset_own_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 279:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_querier 0
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_querier 0


In bridge_mdb_active.sh line 280:
	bridge vlan global set vid ${MCAST_VLAN_ID} dev br0 mcast_querier 1
                                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan global set vid "${MCAST_VLAN_ID}" dev br0 mcast_querier 1


In bridge_mdb_active.sh line 285:
test_active_other_querier_nolog()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 295:
test_active_other_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 304:
test_active_own_querier_nolog()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 314:
test_active_own_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 323:
test_active_final()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 331:
test_inactive_brdown()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 353:
test_inactive_nov6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 371:
test_inactive_snooping_off()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 389:
test_inactive_querier_off()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 407:
test_inactive_other_querier_norespdelay()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 424:
test_inactive_own_querier_norespdelay()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 441:
test_vlan_inactive()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 471:
test_vlan_active_final()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 482:
test_vlan_active_other_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 497:
test_vlan_active_own_querier()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 512:
test_vlan_inactive_brdown()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 539:
test_vlan_inactive_nov6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 562:
test_vlan_inactive_snooping_off()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 585:
test_vlan_inactive_vlans_snooping_off()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 608:
test_vlan_inactive_vlan_snooping_off()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 631:
test_vlan_inactive_other_querier_norespdelay()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 653:
test_vlan_inactive_own_querier_norespdelay()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bridge_mdb_active.sh line 682:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...