ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.DV7mB4BXlq and /tmp/tmp.DZmEU1t2RK
Tree base:
ace5e3c5376e ("test: Add ext_hdr.py in networking selftests")
Now at:
a4ba931ad650 ("test: Add networking sefltest for eh limits")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/eh_limits.sh - e9cf35e4a5b7743a2a361c03d18581e8097bdcf91e5c2dea37a8c1d4b79f99d1


In eh_limits.sh line 37:
	if [ ${rc} -eq ${expected} ]; then
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                       ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if [ "${rc}" -eq "${expected}" ]; then


In eh_limits.sh line 47:
			read a
                        ^--^ SC2162 (info): read without -r will mangle backslashes.


In eh_limits.sh line 55:
		read a
                ^--^ SC2162 (info): read without -r will mangle backslashes.


In eh_limits.sh line 73:
	ip link set veth1 netns "$ns1"
                                 ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In eh_limits.sh line 74:
	ip link set veth2 netns "$ns2"
                                 ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In eh_limits.sh line 110:
	$NS_EXEC "$ns1" python3 ./eh_limits.py $VERBOSE $ip_addrs
                                                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$NS_EXEC "$ns1" python3 ./eh_limits.py $VERBOSE "$ip_addrs"


In eh_limits.sh line 134:
	$NS_EXEC "$ns1" python3 ./eh_limits.py $VERBOSE $ip_addrs
                                                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$NS_EXEC "$ns1" python3 ./eh_limits.py $VERBOSE "$ip_addrs"


In eh_limits.sh line 170:
PEER_CMD="ip netns exec ${PEER_NS}"
^------^ SC2034 (warning): PEER_CMD appears unused. Verify use (or export if used externally).


In eh_limits.sh line 203:
	printf "\nTests passed: %3d\n" ${nsuccess}
                                       ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	printf "\nTests passed: %3d\n" "${nsuccess}"


In eh_limits.sh line 204:
	printf "Tests failed: %3d\n"   ${nfail}
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	printf "Tests failed: %3d\n"   "${nfail}"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- PEER_CMD appears unused. Verify u...
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...