WARNING: line length of 85 exceeds 80 columns #55: FILE: net/ipv4/tcp_bbr.c:1014: + // overwrite pacing gain in case the sender fails to put enough data inflight ERROR: code indent should use tabs where possible #55: FILE: net/ipv4/tcp_bbr.c:1014: + // overwrite pacing gain in case the sender fails to put enough data inflight$ ERROR: code indent should use tabs where possible #56: FILE: net/ipv4/tcp_bbr.c:1015: + struct tcp_sock *tp = tcp_sk(sk);$ WARNING: please, no spaces at the start of a line #56: FILE: net/ipv4/tcp_bbr.c:1015: + struct tcp_sock *tp = tcp_sk(sk);$ ERROR: code indent should use tabs where possible #57: FILE: net/ipv4/tcp_bbr.c:1016: + u64 real_inflight = tp->bytes_sent - tp->bytes_acked;$ WARNING: please, no spaces at the start of a line #57: FILE: net/ipv4/tcp_bbr.c:1016: + u64 real_inflight = tp->bytes_sent - tp->bytes_acked;$ WARNING: line length of 85 exceeds 80 columns #58: FILE: net/ipv4/tcp_bbr.c:1017: + u32 target_inflight = bbr_inflight(sk, bbr_bw(sk), BBR_UNIT) * tp->mss_cache; ERROR: code indent should use tabs where possible #58: FILE: net/ipv4/tcp_bbr.c:1017: + u32 target_inflight = bbr_inflight(sk, bbr_bw(sk), BBR_UNIT) * tp->mss_cache;$ WARNING: please, no spaces at the start of a line #58: FILE: net/ipv4/tcp_bbr.c:1017: + u32 target_inflight = bbr_inflight(sk, bbr_bw(sk), BBR_UNIT) * tp->mss_cache;$ ERROR: code indent should use tabs where possible #59: FILE: net/ipv4/tcp_bbr.c:1018: + if (real_inflight < target_inflight) {$ WARNING: Missing a blank line after declarations #59: FILE: net/ipv4/tcp_bbr.c:1018: + u32 target_inflight = bbr_inflight(sk, bbr_bw(sk), BBR_UNIT) * tp->mss_cache; + if (real_inflight < target_inflight) { WARNING: please, no spaces at the start of a line #59: FILE: net/ipv4/tcp_bbr.c:1018: + if (real_inflight < target_inflight) {$ WARNING: braces {} are not necessary for single statement blocks #59: FILE: net/ipv4/tcp_bbr.c:1018: + if (real_inflight < target_inflight) { + bbr->pacing_gain = bbr_high_gain; + } ERROR: code indent should use tabs where possible #60: FILE: net/ipv4/tcp_bbr.c:1019: + bbr->pacing_gain = bbr_high_gain;$ WARNING: please, no spaces at the start of a line #60: FILE: net/ipv4/tcp_bbr.c:1019: + bbr->pacing_gain = bbr_high_gain;$ ERROR: code indent should use tabs where possible #61: FILE: net/ipv4/tcp_bbr.c:1020: + }$ WARNING: please, no spaces at the start of a line #61: FILE: net/ipv4/tcp_bbr.c:1020: + }$ WARNING: From:/Signed-off-by: email name mismatch: 'From: kelmenhorst ' != 'Signed-off-by: Kathrin Elmenhorst ' total: 7 errors, 11 warnings, 0 checks, 13 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 16f34aaf16db ("net: tcp_bbr: use high pacing gain when the sender fails to put enough data inflight") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.