====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.TmRoklN4e5 2026-01-28 17:01:05.047939248 -0500 +++ /tmp/tmp.vnv3Uj7eLk 2026-01-28 17:01:05.793931341 -0500 @@ -7 +7 @@ -In basic_features.sh line 21: +In basic_features.sh line 24: @@ -15 +15 @@ -In basic_features.sh line 24: +In basic_features.sh line 27: @@ -20 +20 @@ -In basic_features.sh line 26: +In basic_features.sh line 29: @@ -30 +30 @@ -In basic_features.sh line 31: +In basic_features.sh line 34: @@ -38 +38 @@ -In basic_features.sh line 34: +In basic_features.sh line 37: @@ -43 +43 @@ -In basic_features.sh line 36: +In basic_features.sh line 39: @@ -53 +53 @@ -In basic_features.sh line 39: +In basic_features.sh line 42: @@ -58 +58 @@ -In basic_features.sh line 43: +In basic_features.sh line 46: @@ -67 +67 @@ -In basic_features.sh line 46: +In basic_features.sh line 49: @@ -72,6 +72 @@ -In basic_features.sh line 48: - RET=0 - ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). - - -In basic_features.sh line 51: +In basic_features.sh line 54: @@ -86 +81 @@ -In basic_features.sh line 52: +In basic_features.sh line 55: @@ -91 +86 @@ -In basic_features.sh line 56: +In basic_features.sh line 59: @@ -100 +95 @@ -In basic_features.sh line 57: +In basic_features.sh line 60: @@ -105 +100 @@ -In basic_features.sh line 65: +In basic_features.sh line 68: @@ -113 +108 @@ -In basic_features.sh line 67: +In basic_features.sh line 70: @@ -121 +116 @@ -In basic_features.sh line 71: +In basic_features.sh line 74: @@ -130 +125 @@ -In basic_features.sh line 72: +In basic_features.sh line 75: @@ -139 +134 @@ -In basic_features.sh line 75: +In basic_features.sh line 78: @@ -147 +142 @@ -In basic_features.sh line 77: +In basic_features.sh line 80: @@ -155 +150 @@ -In basic_features.sh line 80: +In basic_features.sh line 83: @@ -164 +159,120 @@ -In basic_features.sh line 88: +In basic_features.sh line 89: +buffer_circulation_test() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In basic_features.sh line 91: + RET=0 + ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). + + +In basic_features.sh line 98: + ping -c 1 -I $h1 $H2_IPV4 >/dev/null + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ping -c 1 -I "$h1" "$H2_IPV4" >/dev/null + + +In basic_features.sh line 99: + if [ $? -ne 0 ]; then + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In basic_features.sh line 105: + local rx_start=$(cat /sys/class/net/$h2/statistics/rx_packets) + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local rx_start=$(cat /sys/class/net/"$h2"/statistics/rx_packets) + + +In basic_features.sh line 106: + local tx_start=$(cat /sys/class/net/$h1/statistics/tx_packets) + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local tx_start=$(cat /sys/class/net/"$h1"/statistics/tx_packets) + + +In basic_features.sh line 113: + iperf3 -s --bind-dev $h2 -p 5201 &>/dev/null & + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + iperf3 -s --bind-dev "$h2" -p 5201 &>/dev/null & + + +In basic_features.sh line 117: + if ! kill -0 $server_pid 2>/dev/null; then + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if ! kill -0 "$server_pid" 2>/dev/null; then + + +In basic_features.sh line 126: + iperf3 -c $H2_IPV4 --bind-dev $h1 -p 5201 -t 5 >/dev/null 2>&1 + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + iperf3 -c "$H2_IPV4" --bind-dev "$h1" -p 5201 -t 5 >/dev/null 2>&1 + + +In basic_features.sh line 129: + kill $server_pid 2>/dev/null || true + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + kill "$server_pid" 2>/dev/null || true + + +In basic_features.sh line 130: + wait $server_pid 2>/dev/null || true + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$server_pid" 2>/dev/null || true + + +In basic_features.sh line 135: + local hold=$(grep -c "page_pool_state_hold" "$trace" 2>/dev/null) + ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In basic_features.sh line 136: + local release=$(grep -c "page_pool_state_release" "$trace" 2>/dev/null) + ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In basic_features.sh line 140: + local rx_end=$(cat /sys/class/net/$h2/statistics/rx_packets) + ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local rx_end=$(cat /sys/class/net/"$h2"/statistics/rx_packets) + + +In basic_features.sh line 141: + local tx_end=$(cat /sys/class/net/$h1/statistics/tx_packets) + ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local tx_end=$(cat /sys/class/net/"$h1"/statistics/tx_packets) + + +In basic_features.sh line 147: + if [ $iperf_ret -ne 0 ]; then + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + if [ "$iperf_ret" -ne 0 ]; then + + +In basic_features.sh line 158: @@ -172 +286 @@ -In basic_features.sh line 89: +In basic_features.sh line 159: @@ -180 +294 @@ -In basic_features.sh line 90: +In basic_features.sh line 160: @@ -188 +302 @@ -In basic_features.sh line 91: +In basic_features.sh line 161: @@ -196 +310 @@ -In basic_features.sh line 99: +In basic_features.sh line 169: @@ -201 +315 @@ -In basic_features.sh line 106: +In basic_features.sh line 176: @@ -209 +323 @@ -In basic_features.sh line 107: +In basic_features.sh line 177: @@ -217 +331 @@ -In basic_features.sh line 108: +In basic_features.sh line 178: @@ -225 +339 @@ -In basic_features.sh line 109: +In basic_features.sh line 179: @@ -233 +347 @@ -In basic_features.sh line 110: +In basic_features.sh line 180: @@ -241 +355 @@ -In basic_features.sh line 111: +In basic_features.sh line 181: @@ -249 +363 @@ -In basic_features.sh line 114: +In basic_features.sh line 184: @@ -254 +368 @@ -In basic_features.sh line 120: +In basic_features.sh line 190: @@ -262 +376 @@ -In basic_features.sh line 121: +In basic_features.sh line 191: @@ -270 +384 @@ -In basic_features.sh line 122: +In basic_features.sh line 192: @@ -278 +392 @@ -In basic_features.sh line 123: +In basic_features.sh line 193: @@ -286,0 +401 @@ + https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... @@ -288 +402,0 @@ - https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...