WARNING: line length of 91 exceeds 80 columns
#58: FILE: tools/testing/selftests/net/xfrm_state.sh:22:
+# Network topology x: IPsec gateway that generates ICMP response - ns_set_v4x or ns_set_v6x

WARNING: line length of 81 exceeds 80 columns
#120: FILE: tools/testing/selftests/net/xfrm_state.sh:84:
+		# Since cleanup() relies on variables modified by this sub shell,

WARNING: line length of 100 exceeds 80 columns
#125: FILE: tools/testing/selftests/net/xfrm_state.sh:89:
+			printf "\n#############################################################\n\n"

WARNING: line length of 90 exceeds 80 columns
#192: FILE: tools/testing/selftests/net/xfrm_state.sh:156:
+	[ -n "${NS_A}" ] && ns_a="ip netns exec ${NS_A}" && ns_active="${ns_active} $NS_A"

WARNING: line length of 94 exceeds 80 columns
#193: FILE: tools/testing/selftests/net/xfrm_state.sh:157:
+	[ -n "${NS_R1}" ] && ns_r1="ip netns exec ${NS_R1}" && ns_active="${ns_active} $NS_R1"

WARNING: line length of 94 exceeds 80 columns
#194: FILE: tools/testing/selftests/net/xfrm_state.sh:158:
+	[ -n "${NS_S1}" ] && ns_s1="ip netns exec ${NS_S1}" && ns_active="${ns_active} $NS_S1"

WARNING: line length of 94 exceeds 80 columns
#195: FILE: tools/testing/selftests/net/xfrm_state.sh:159:
+	[ -n "${NS_R2}" ] && ns_r2="ip netns exec ${NS_R2}" && ns_active="${ns_active} $NS_R2"

WARNING: line length of 94 exceeds 80 columns
#196: FILE: tools/testing/selftests/net/xfrm_state.sh:160:
+	[ -n "${NS_S2}" ] && ns_s2="ip netns exec ${NS_S2}" && ns_active="${ns_active} $NS_S2"

WARNING: line length of 94 exceeds 80 columns
#197: FILE: tools/testing/selftests/net/xfrm_state.sh:161:
+	[ -n "${NS_R3}" ] && ns_r3="ip netns exec ${NS_R3}" && ns_active="${ns_active} $NS_R3"

WARNING: line length of 90 exceeds 80 columns
#198: FILE: tools/testing/selftests/net/xfrm_state.sh:162:
+	[ -n "${NS_B}" ] && ns_b="ip netns exec ${NS_B}" && ns_active="${ns_active} $NS_B"

WARNING: line length of 84 exceeds 80 columns
#225: FILE: tools/testing/selftests/net/xfrm_state.sh:189:
+	run_cmd ${ns_cmd} nft add rule inet filter FORWARD counter ip protocol esp \

WARNING: line length of 91 exceeds 80 columns
#248: FILE: tools/testing/selftests/net/xfrm_state.sh:212:
+				       nd-router-solicit,nd-router-advert} counter log drop

WARNING: line length of 90 exceeds 80 columns
#334: FILE: tools/testing/selftests/net/xfrm_state.sh:298:
+			# Add addresses: previous gets .1 on eth0, current gets .2 on eth1

WARNING: line length of 85 exceeds 80 columns
#335: FILE: tools/testing/selftests/net/xfrm_state.sh:299:
+			addr_add ${p} "${prefix}${s}$((i-1))${S}1/${prefix_len}" eth0

WARNING: line length of 86 exceeds 80 columns
#336: FILE: tools/testing/selftests/net/xfrm_state.sh:300:
+			addr_add ${ns} "${prefix}${s}$((i-1))${S}2/${prefix_len}" eth1

WARNING: line length of 89 exceeds 80 columns
#358: FILE: tools/testing/selftests/net/xfrm_state.sh:322:
+				       	"${prefix}${s}${j}${S}0/${prefix_len}" via ${nhf}

WARNING: line length of 89 exceeds 80 columns
#367: FILE: tools/testing/selftests/net/xfrm_state.sh:331:
+					"${prefix}${s}${j}${S}0/${prefix_len}" via ${nhr}

WARNING: line length of 89 exceeds 80 columns
#383: FILE: tools/testing/selftests/net/xfrm_state.sh:347:
+	run_cmd ${ns_s1} ip xfrm policy add src ${s1_src_net} dst ${s1_dst_net} dir out \

WARNING: line length of 89 exceeds 80 columns
#388: FILE: tools/testing/selftests/net/xfrm_state.sh:352:
+	run_cmd ${ns_s1} ip xfrm policy add src ${s1_dst_net} dst ${s1_src_net} dir fwd \

WARNING: line length of 89 exceeds 80 columns
#389: FILE: tools/testing/selftests/net/xfrm_state.sh:353:
+		flag icmp tmpl src ${s1_dst} dst ${s1_src} proto esp reqid 2 mode ${MODE}

WARNING: line length of 88 exceeds 80 columns
#391: FILE: tools/testing/selftests/net/xfrm_state.sh:355:
+	run_cmd ${ns_s1} ip xfrm state add src ${s1_src} dst ${s1_dst} proto esp spi 1 \

WARNING: line length of 88 exceeds 80 columns
#396: FILE: tools/testing/selftests/net/xfrm_state.sh:360:
+	run_cmd ${ns_s1} ip xfrm state add src ${s1_dst} dst ${s1_src} proto esp spi 2 \

WARNING: line length of 89 exceeds 80 columns
#397: FILE: tools/testing/selftests/net/xfrm_state.sh:361:
+		reqid 2 flag icmp replay-window 8 mode ${MODE} aead 'rfc4106(gcm(aes))' \

WARNING: line length of 89 exceeds 80 columns
#401: FILE: tools/testing/selftests/net/xfrm_state.sh:365:
+	run_cmd ${ns_s2} ip xfrm policy add src ${s1_dst_net} dst ${s1_src_net} dir out \

WARNING: line length of 89 exceeds 80 columns
#402: FILE: tools/testing/selftests/net/xfrm_state.sh:366:
+		flag icmp tmpl src ${s1_dst} dst ${s1_src} proto esp reqid 2 mode ${MODE}

WARNING: line length of 89 exceeds 80 columns
#404: FILE: tools/testing/selftests/net/xfrm_state.sh:368:
+	run_cmd ${ns_s2} ip xfrm policy add src ${s1_src_net} dst ${s1_dst_net} dir fwd \

WARNING: line length of 88 exceeds 80 columns
#407: FILE: tools/testing/selftests/net/xfrm_state.sh:371:
+	run_cmd ${ns_s2} ip xfrm state add src ${s1_dst} dst ${s1_src} proto esp spi 2 \

WARNING: line length of 88 exceeds 80 columns
#412: FILE: tools/testing/selftests/net/xfrm_state.sh:376:
+	run_cmd ${ns_s2} ip xfrm state add src ${s1_src} dst ${s1_dst} proto esp spi 1 \

WARNING: line length of 89 exceeds 80 columns
#413: FILE: tools/testing/selftests/net/xfrm_state.sh:377:
+		reqid 1 flag icmp replay-window 8 mode ${MODE} aead 'rfc4106(gcm(aes))' \

WARNING: line length of 81 exceeds 80 columns
#423: FILE: tools/testing/selftests/net/xfrm_state.sh:387:
+	[ "$(id -u)" -ne 0 ] && echo "  need to run as root" && return $ksft_skip

WARNING: line length of 86 exceeds 80 columns
#448: FILE: tools/testing/selftests/net/xfrm_state.sh:412:
+	[[ "$PAUSE" = "always" || ( "$PAUSE" = "fail" && "$fail" = "yes" ) ]] && pause

WARNING: line length of 82 exceeds 80 columns
#454: FILE: tools/testing/selftests/net/xfrm_state.sh:418:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return $ksft_skip

WARNING: line length of 83 exceeds 80 columns
#458: FILE: tools/testing/selftests/net/xfrm_state.sh:422:
+	echo -e "$out" | grep -q -E 'From fc00:5::2 icmp_seq.* Destination' || rc=1

WARNING: line length of 83 exceeds 80 columns
#463: FILE: tools/testing/selftests/net/xfrm_state.sh:427:
+	setup ns_set_v6x namespaces network xfrm icmpv6_filter || return $ksft_skip

WARNING: line length of 83 exceeds 80 columns
#467: FILE: tools/testing/selftests/net/xfrm_state.sh:431:
+	echo -e "$out" | grep -q -E 'From fc00:4::2 icmp_seq.* Destination' || rc=1

WARNING: line length of 82 exceeds 80 columns
#476: FILE: tools/testing/selftests/net/xfrm_state.sh:440:
+	echo -e "$out" | grep -q -E 'From 10.1.5.2 icmp_seq.* Destination' || rc=1

WARNING: line length of 81 exceeds 80 columns
#481: FILE: tools/testing/selftests/net/xfrm_state.sh:445:
+	setup ns_set_v4x namespaces network icmp_filter xfrm || return $ksft_skip

WARNING: line length of 82 exceeds 80 columns
#485: FILE: tools/testing/selftests/net/xfrm_state.sh:449:
+	echo -e "$out" | grep -q -E 'From 10.1.4.2 icmp_seq.* Destination' || rc=1

WARNING: line length of 84 exceeds 80 columns
#492: FILE: tools/testing/selftests/net/xfrm_state.sh:456:
+	run_cmd ${ns_r2} ip route replace 10.1.3.0/24 dev eth1 src 10.1.3.2 mtu 1300

WARNING: line length of 84 exceeds 80 columns
#493: FILE: tools/testing/selftests/net/xfrm_state.sh:457:
+	run_cmd ${ns_r2} ip route replace 10.1.4.0/24 dev eth0 src 10.1.4.1 mtu 1300

WARNING: line length of 94 exceeds 80 columns
#496: FILE: tools/testing/selftests/net/xfrm_state.sh:460:
+	echo -e "$out" | grep -q -E "From 10.1.2.2 icmp_seq=.* Frag needed and DF set" || rc=1

WARNING: line length of 82 exceeds 80 columns
#501: FILE: tools/testing/selftests/net/xfrm_state.sh:465:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return $ksft_skip

WARNING: line length of 99 exceeds 80 columns
#503: FILE: tools/testing/selftests/net/xfrm_state.sh:467:
+	run_cmd ${ns_r2} ip -6 route replace fc00:3::/64 dev eth1 metric 256 src fc00:3::2 mtu 1300

WARNING: line length of 99 exceeds 80 columns
#504: FILE: tools/testing/selftests/net/xfrm_state.sh:468:
+	run_cmd ${ns_r2} ip -6 route replace fc00:4::/64 dev eth0 metric 256 src fc00:4::1 mtu 1300

WARNING: line length of 97 exceeds 80 columns
#507: FILE: tools/testing/selftests/net/xfrm_state.sh:471:
+	echo -e "$out" | grep -q -E "From fc00:2::2 icmp_seq=.* Packet too big: mtu=1230" || rc=1

WARNING: line length of 100 exceeds 80 columns
#517: FILE: tools/testing/selftests/net/xfrm_state.sh:481:
+	echo -e "$out" | grep -q -E "From 10.1.5.2 .* Frag needed and DF set \(mtu = 1300\)" || rc=1

WARNING: line length of 81 exceeds 80 columns
#522: FILE: tools/testing/selftests/net/xfrm_state.sh:486:
+	setup ns_set_v4x namespaces network icmp_filter xfrm || return $ksft_skip

WARNING: line length of 84 exceeds 80 columns
#524: FILE: tools/testing/selftests/net/xfrm_state.sh:488:
+	run_cmd ${ns_s2} ip route replace 10.1.5.0/24 dev eth0 src 10.1.5.1 mtu 1300

WARNING: line length of 98 exceeds 80 columns
#527: FILE: tools/testing/selftests/net/xfrm_state.sh:491:
+	echo -e "$out" | grep -q -E "From 10.1.4.2.*Frag needed and DF set \(mtu = 1300\)" || rc=1

WARNING: line length of 83 exceeds 80 columns
#532: FILE: tools/testing/selftests/net/xfrm_state.sh:496:
+	setup ns_set_v6x namespaces network xfrm icmpv6_filter || return $ksft_skip

WARNING: line length of 85 exceeds 80 columns
#534: FILE: tools/testing/selftests/net/xfrm_state.sh:498:
+	run_cmd ${ns_s2} ip -6 route replace fc00:5::/64 dev eth0 metric 256 mtu 1300

WARNING: line length of 86 exceeds 80 columns
#537: FILE: tools/testing/selftests/net/xfrm_state.sh:501:
+	echo -e "$out" | grep -q -E "From fc00:4::2.*Packet too big: mtu=1300" || rc=1

WARNING: line length of 82 exceeds 80 columns
#542: FILE: tools/testing/selftests/net/xfrm_state.sh:506:
+	setup ns_set_v6 namespaces network xfrm icmpv6_filter || return $ksft_skip

WARNING: line length of 85 exceeds 80 columns
#544: FILE: tools/testing/selftests/net/xfrm_state.sh:508:
+	run_cmd ${ns_r3} ip -6 route replace fc00:6::/64 dev eth1 metric 256 mtu 1300

WARNING: line length of 97 exceeds 80 columns
#547: FILE: tools/testing/selftests/net/xfrm_state.sh:511:
+	echo -e "$out" | grep -q -E "From fc00:5::2 icmp_seq=.* Packet too big: mtu=1300" || rc=1

total: 0 errors, 55 warnings, 0 checks, 585 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 50c9173d0750 ("selftests: net: add ICMP error source address test over xfrm tunnel") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 55 warnings, 0 checks, 585 lines checked