WARNING: line length of 82 exceeds 80 columns #111: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:81: + /* Freeze the top-level cgroup and enable the memory controller */ WARNING: line length of 87 exceeds 80 columns #113: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:83: + err = write_cgroup_file(cgroups[i].path, "cgroup.freeze", "1"); WARNING: line length of 90 exceeds 80 columns #117: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:87: + err = write_cgroup_file(cgroups[i].path, "cgroup.subtree_control", WARNING: line length of 85 exceeds 80 columns #128: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:98: + err = write_cgroup_file(cgroups[i].path, "memory.high", buf); WARNING: line length of 83 exceeds 80 columns #133: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:103: + write_cgroup_file(cgroups[i].path, "memory.swap.max", buf); WARNING: line length of 86 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:115: + err = write_cgroup_file(cgroups[i].path, "cgroup.procs", buf); CHECK: Unnecessary parentheses around 'pid == cgroups[i].pid' #186: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:156: + if (!ASSERT_OK(cgroups[i].victim != + (pid == cgroups[i].pid), + "correct process was killed")) { WARNING: line length of 81 exceeds 80 columns #197: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:167: + size = read_cgroup_file(cgroups[i].path, "memory.events", CHECK: Comparison to NULL could be written "!strstr" #204: FILE: tools/testing/selftests/bpf/prog_tests/test_psi.c:174: + if (!ASSERT_OK(strstr(buf, "oom_kill 1") == NULL, WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #262: FILE: tools/testing/selftests/bpf/progs/test_psi.c:1: +#include "vmlinux.h" WARNING: externs should be avoided in .c files #277: FILE: tools/testing/selftests/bpf/progs/test_psi.c:16: +extern struct task_struct *bpf_task_from_pid(s32 pid) __ksym; total: 0 errors, 9 warnings, 2 checks, 315 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ba18b86b18f0 ("bpf: selftests: PSI struct ops test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 9 warnings, 2 checks, 315 lines checked