WARNING: line length of 87 exceeds 80 columns #132: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:96: + err = write_cgroup_file(cgroups[i].path, "cgroup.freeze", "1"); CHECK: Blank lines aren't necessary after an open brace '{' #139: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:103: + if (!cgroups[i].target) { + WARNING: line length of 90 exceeds 80 columns #140: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:104: + err = write_cgroup_file(cgroups[i].path, "cgroup.subtree_control", WARNING: line length of 84 exceeds 80 columns #151: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:115: + err = write_cgroup_file(cgroups[i].path, "memory.max", buf); WARNING: line length of 83 exceeds 80 columns #156: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:120: + write_cgroup_file(cgroups[i].path, "memory.swap.max", buf); CHECK: Blank lines aren't necessary before a close brace '}' #158: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:122: + + } WARNING: line length of 86 exceeds 80 columns #169: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:133: + err = write_cgroup_file(cgroups[i].path, "cgroup.procs", buf); CHECK: Unnecessary parentheses around 'pid == cgroups[i].pid' #213: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:177: + if (!ASSERT_OK(cgroups[i].victim != + (pid == cgroups[i].pid), + "correct process was killed")) { CHECK: Comparison to NULL could be written "!strstr" #232: FILE: tools/testing/selftests/bpf/prog_tests/test_oom.c:196: + if (!ASSERT_OK(strstr(buf, "oom_kill 1") == NULL, WARNING: line length of 90 exceeds 80 columns #325: FILE: tools/testing/selftests/bpf/progs/test_oom.c:27: +int BPF_PROG(test_out_of_memory, struct oom_control *oc, struct bpf_struct_ops_link *link) WARNING: line length of 88 exceeds 80 columns #348: FILE: tools/testing/selftests/bpf/progs/test_oom.c:50: + bpf_for_each(css, css_pos, &root_memcg->css, BPF_CGROUP_ITER_DESCENDANTS_POST) { WARNING: line length of 92 exceeds 80 columns #349: FILE: tools/testing/selftests/bpf/progs/test_oom.c:51: + if (css_pos->cgroup->nr_descendants + css_pos->cgroup->nr_dying_descendants) CHECK: Unnecessary parentheses around 'usage > max_usage' #364: FILE: tools/testing/selftests/bpf/progs/test_oom.c:66: + if ((usage > max_usage) && mem_cgroup_killable(memcg)) { total: 0 errors, 8 warnings, 5 checks, 367 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 3193e60a2881 ("bpf: selftests: BPF OOM struct ops test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 5 checks, 367 lines checked